Received-SPF: pass (google.com: domain of linux-kernel+bounces-53928-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240130091300.2968534-1-tj@kernel.org> <ZcACvVz83QFuSLR6@slm.duckdns.org>
In-Reply-To: <ZcACvVz83QFuSLR6@slm.duckdns.org>
From: Allen <allen.lkml@gmail.com>
Date: Mon, 5 Feb 2024 12:50:28 -0800
Message-ID: <CAOMdWSLNMqsZNJ-oCLN2RjckZmJSvdU_Yq0F0frmqMqa67Oy1g@mail.gmail.com>
Subject: Re: [PATCHSET wq/for-6.9] workqueue: Implement BH workqueue and
 convert several tasklet users
To: Tejun Heo <tj@kernel.org>
Cc: torvalds@linux-foundation.org, mpatocka@redhat.com, 
	linux-kernel@vger.kernel.org, dm-devel@lists.linux.dev, msnitzer@redhat.com, 
	ignat@cloudflare.com, damien.lemoal@wdc.com, bob.liu@oracle.com, 
	houtao1@huawei.com, peterz@infradead.org, mingo@kernel.org, 
	netdev@vger.kernel.org, kernel-team@meta.com
Content-Type: text/plain; charset="UTF-8"

> On Mon, Jan 29, 2024 at 11:11:47PM -1000, Tejun Heo wrote:
> >  0001-workqueue-Update-lock-debugging-code.patch
> >  0002-workqueue-Factor-out-init_cpu_worker_pool.patch
> >  0003-workqueue-Implement-BH-workqueues-to-eventually-repl.patch
> >  0004-backtracetest-Convert-from-tasklet-to-BH-workqueue.patch
> >  0005-usb-core-hcd-Convert-from-tasklet-to-BH-workqueue.patch
> >  0006-net-tcp-tsq-Convert-from-tasklet-to-BH-workqueue.patch
> >  0007-dm-crypt-Convert-from-tasklet-to-BH-workqueue.patch
> >  0008-dm-verity-Convert-from-tasklet-to-BH-workqueue.patch
>
> Applied 0001-0003 to wq/for-6.9. Applied 0004-0005 to
> wq/for-6.9-bh-conversions. Will proceed on 0006 and other conversions after
> more perf testing.
>
> Thanks.
>

Thank you. I am basing my work on the branch you have
pushed.(or-6.9-bh-conversions)
https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git/log/?h=for-6.9-bh-conversions

In the order of priority, I have started converting drivers/media/*,
drivers/dma/* followed by drivers/net/*
which constitutes the majority. Putting my plan out here so that the
work is not duplicated.
I will write back in a day and share the branch for review.

W.r.t the conversion, there are drivers which call
tasklet_[disable/enable](), which I suppose
can be ignored in the case of workqueues, I am not entirely sure if
this is the right approach.
Please correct me if I am wrong.


Thanks,

  - Allen