Received-SPF: pass (google.com: domain of linux-kernel+bounces-53962-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Sender: Tejun Heo <htejun@gmail.com>
Date: Mon, 5 Feb 2024 11:12:09 -1000
From: Tejun Heo <tj@kernel.org>
To: Allen <allen.lkml@gmail.com>
Cc: torvalds@linux-foundation.org, mpatocka@redhat.com,
	linux-kernel@vger.kernel.org, dm-devel@lists.linux.dev,
	msnitzer@redhat.com, ignat@cloudflare.com, damien.lemoal@wdc.com,
	bob.liu@oracle.com, houtao1@huawei.com, peterz@infradead.org,
	mingo@kernel.org, netdev@vger.kernel.org, kernel-team@meta.com
Subject: Re: [PATCHSET wq/for-6.9] workqueue: Implement BH workqueue and
 convert several tasklet users
Message-ID: <ZcFPKaWwxJhgy8HQ@slm.duckdns.org>
References: <20240130091300.2968534-1-tj@kernel.org>
 <ZcACvVz83QFuSLR6@slm.duckdns.org>
 <CAOMdWSLNMqsZNJ-oCLN2RjckZmJSvdU_Yq0F0frmqMqa67Oy1g@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAOMdWSLNMqsZNJ-oCLN2RjckZmJSvdU_Yq0F0frmqMqa67Oy1g@mail.gmail.com>

Hello, Allen.

On Mon, Feb 05, 2024 at 12:50:28PM -0800, Allen wrote:
> Thank you. I am basing my work on the branch you have
> pushed.(or-6.9-bh-conversions)
> https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git/log/?h=for-6.9-bh-conversions
> 
> In the order of priority, I have started converting drivers/media/*,
> drivers/dma/* followed by drivers/net/*
> which constitutes the majority. Putting my plan out here so that the
> work is not duplicated.
> I will write back in a day and share the branch for review.

That's great. Thanks.

> W.r.t the conversion, there are drivers which call
> tasklet_[disable/enable](), which I suppose
> can be ignored in the case of workqueues, I am not entirely sure if
> this is the right approach.
> Please correct me if I am wrong.

I don't think we can ignore them. I was just looking at tasklet_kill() and
thought we're good because that seemed to map well to cancel_work_sync().
workqueue doesn't have the counterpart for tasklet_[disable/enable](). I'll
look through them and think on it.

Thanks.

-- 
tejun