Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp2675960rdb; Mon, 5 Feb 2024 14:08:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IGUonXwapMVop9O5TC+Z2+6LkexAaeJAW3ZTR4xd54p0KRRn/bEw4Wn/TKBZvJT+/7PP4i5 X-Received: by 2002:ac8:7c8c:0:b0:42b:f656:c0a5 with SMTP id y12-20020ac87c8c000000b0042bf656c0a5mr482179qtv.18.1707170913395; Mon, 05 Feb 2024 14:08:33 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707170913; cv=pass; d=google.com; s=arc-20160816; b=R2ba6ZP2NzTHQu90yrg3Cytz77wuh10ff3mmCOgQlA9hFxonG/sQBSYX3NwQaGZDFB FRGjKxeQAiiqCsDa8GKWz6E6UDLd5q02+YvAqh8FVtriQ5mwaFgMGelW94YJjKZEBW8Z ia/WyDjoiVW237pZ0WYudyPD/m290oCpJ+A7KfyZ1iqqkn4ffsPHP8TipWPhMvEXab1r P54JtlYomIhj417lO4dKiac+fQ8hq1yYr+tGo8vFdJ/8TZL6l0fgYJ8kFqZAM3/8OPiV uzZchx3mEkreTJQC0UIrjgW8tZnG4QV5jHrOqm9mLOH3MrQrlrpLWjyOaciGCD7l87rr 7hzQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=LGdsQ59zhEVu0ei+TwULfoCVyBdkETX4sgP45thvjdg=; fh=dZkRktJp7uT7hmND5msq4EKtpoZ0JCV8MCWjHgJ8nQg=; b=z3CZ6tvkvCC/VuSsQXg9solRzrPm0NN3n2qiQDJ+a6u3H/ypB+GsNYW/2KPVp371A5 vCPf9b6NjHEfd8DeVqOI446Ku/rHYFD3JnmqgGxco/GCbb5CiSXCzOsN82IozY51iS6q Ia7NXsBs92D8TWz6Vwr52MgAtmyZqElsT6S7zLFeVyCWdEWncJTmn7zv8yYRkjzEeyty 0txGx/lSF76Iy+3afHZUihcBlAu7yJNp4KLjDQBrNKJZUqgNouJecGVNoPAiy+7Omqy3 N6MvCgXZD6Bcn3X4UTvPYbBq3hiVYoHfNv95FhbdrhqESMP7uXYyb70m0i3HcDHS4Cld sYRQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=CTnWI9hQ; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-53975-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-53975-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Forwarded-Encrypted: i=1; AJvYcCWARod2JvKe6wPyuQkuUWKSuTFJzWkr4fvjqzvdu085Xf9vtzXJN9St48R6JcDd7NYIYC6TVLFGqCiXN1/WYfl4/DyiJneZpX9oe6MPng== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id u18-20020a05622a14d200b00429c01f5c42si824701qtx.805.2024.02.05.14.08.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 14:08:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-53975-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=CTnWI9hQ; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-53975-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-53975-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id EC8951C29B05 for ; Mon, 5 Feb 2024 22:08:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B2AAE4F898; Mon, 5 Feb 2024 21:25:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="CTnWI9hQ" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59D651AB81F for ; Mon, 5 Feb 2024 21:25:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707168303; cv=none; b=VdnU/OGyKJpmUbbMysSM615NAn7jZqSI95awixrp8sPBok0aJO70giVM9ejUpIx20bOqQQ36Z2cdKBE03PxFLvlDX3QhcLq0oKc43kPq90er0Wa8DhwkP3QlQnLIPOTHClM0IdLYnpIYH1q2618ockH6Q1UcnvzIP9a8JfDHn3g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707168303; c=relaxed/simple; bh=cLLUzHtVNa9Ni8zK+vujHDtOv0dDf+RtNRn2qD7fUzM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EGuY+/wnZVRjOH8seloXAu1YK65RBRmC905qqMwxrIhLjtI58AEaLKkzi5+g7GJzJSlOleoHHKaOr6cOFzAZbN9fNSIXTV27cwhCOL8x2wCz6NSOVqrbwbn2Fmd9Wc97vvC43iC/orKPIpvdf/G1IVL9gatpvKTbcWrlQT9xDE0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=CTnWI9hQ; arc=none smtp.client-ip=192.198.163.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707168302; x=1738704302; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=cLLUzHtVNa9Ni8zK+vujHDtOv0dDf+RtNRn2qD7fUzM=; b=CTnWI9hQUNTVt7DIE3n5TMOzOJkgPg+62knyrS61NZWyL65oY0MsGO+z eI8thS02icpgMimlmNQ03tj40ivbGmPpNr3ySEbWwHDK0n/lLV04t+vMK ZE5++PGtFRGkNGMWKmQXZzbllI0NauQmfsJZehmjGjJKHvgiJBRicpYo8 YNTIxR3YsKyJcZXwW34UETekJqw3XXGVEsZiu4FdNEsgsoZZCHMPEuOPY EoVtK3zHcJ1caJsH8bHwJj5YjPRkBIOp1pW2XkjMPzWxa0D1lTfgncjWo aCM5fBAwwdVv/3BH2FU850+hRuPfa1oL0W/Qo8QHlzxRflPEMoOonuGCL Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10975"; a="11347103" X-IronPort-AV: E=Sophos;i="6.05,245,1701158400"; d="scan'208";a="11347103" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2024 13:25:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,245,1701158400"; d="scan'208";a="1100845" Received: from ranerica-svr.sc.intel.com ([172.25.110.23]) by fmviesa006.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2024 13:25:01 -0800 Date: Mon, 5 Feb 2024 13:26:20 -0800 From: Ricardo Neri To: Valentin Schneider Cc: alexs@kernel.org, Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Daniel Bristot de Oliveira , linux-kernel@vger.kernel.org, sshegde@linux.ibm.com Subject: Re: [PATCH v3 2/4] sched/fair: remove unused parameters Message-ID: <20240205212620.GA17461@ranerica-svr.sc.intel.com> References: <20240201115447.522627-1-alexs@kernel.org> <20240201115447.522627-2-alexs@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) On Fri, Feb 02, 2024 at 03:27:24PM +0100, Valentin Schneider wrote: > On 01/02/24 19:54, alexs@kernel.org wrote: > > From: Alex Shi > > > > sds isn't used in function sched_asym(), so remove it to cleanup code. > > > > Signed-off-by: Alex Shi > > Reviewed-by: Ricardo Neri > > AFAICT this is unsused as of: > c9ca07886aaa ("sched/fair: Do not even the number of busy CPUs via asym_packing") Maybe a Fixes: c9ca07886aaa ("sched/fair: Do not even the number of busy CPUs via asym_packing") is in order?