Received-SPF: pass (google.com: domain of linux-kernel+bounces-54000-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <33d241bf-e360-44c5-b63d-550da3cc66d9@intel.com>
Date: Mon, 5 Feb 2024 15:07:29 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] cxl: remove CONFIG_CXL_PMU entry in drivers/cxl/Kconfig
Content-Language: en-US
To: Masahiro Yamada <masahiroy@kernel.org>,
 Davidlohr Bueso <dave@stgolabs.net>,
 Jonathan Cameron <jonathan.cameron@huawei.com>,
 Alison Schofield <alison.schofield@intel.com>,
 Vishal Verma <vishal.l.verma@intel.com>, Ira Weiny <ira.weiny@intel.com>,
 Dan Williams <dan.j.williams@intel.com>, linux-cxl@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
References: <20240204094613.40687-1-masahiroy@kernel.org>
From: Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20240204094613.40687-1-masahiroy@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 2/4/24 2:46 AM, Masahiro Yamada wrote:
> Commit 5d7107c72796 ("perf: CXL Performance Monitoring Unit driver")
> added the config entries for CXL_PMU in drivers/cxl/Kconfig and
> drivers/perf/Kconfig, so it can be toggled from multiple locations:
> 
> [1] Device Drivers
>      -> PCI support
>        -> CXL (Compute Expres Link) Devices
>          -> CXL Performance Monitoring Unit
> 
> [2] Device Drivers
>      -> Performance monitor support
>        -> CXL Performance Monitoring Unit
> 
> This complicates things, and nobody else does this.
> 
> I kept the one in drivers/perf/Kconfig because CONFIG_CXL_PMU controls
> the compilation of drivers/perf/cxl_pmu.c.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> 
>  drivers/cxl/Kconfig | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/drivers/cxl/Kconfig b/drivers/cxl/Kconfig
> index 67998dbd1d46..5f3c9c5529b9 100644
> --- a/drivers/cxl/Kconfig
> +++ b/drivers/cxl/Kconfig
> @@ -144,17 +144,4 @@ config CXL_REGION_INVALIDATION_TEST
>  	  If unsure, or if this kernel is meant for production environments,
>  	  say N.
>  
> -config CXL_PMU
> -	tristate "CXL Performance Monitoring Unit"
> -	default CXL_BUS
> -	depends on PERF_EVENTS
> -	help
> -	  Support performance monitoring as defined in CXL rev 3.0
> -	  section 13.2: Performance Monitoring. CXL components may have
> -	  one or more CXL Performance Monitoring Units (CPMUs).
> -
> -	  Say 'y/m' to enable a driver that will attach to performance
> -	  monitoring units and provide standard perf based interfaces.
> -
> -	  If unsure say 'm'.
>  endif