Received-SPF: pass (google.com: domain of linux-kernel+bounces-54015-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Valentin Obst <kernel@valentinobst.de>
To: gregkh@linuxfoundation.org
Cc: a.hindborg@samsung.com,
	alex.gaynor@gmail.com,
	aliceryhl@google.com,
	arve@android.com,
	benno.lossin@proton.me,
	bjorn3_gh@protonmail.com,
	boqun.feng@gmail.com,
	brauner@kernel.org,
	cmllamas@google.com,
	dan.j.williams@intel.com,
	dxu@dxuuu.xyz,
	gary@garyguo.net,
	joel@joelfernandes.org,
	keescook@chromium.org,
	linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	maco@android.com,
	ojeda@kernel.org,
	peterz@infradead.org,
	rust-for-linux@vger.kernel.org,
	surenb@google.com,
	tglx@linutronix.de,
	tkjos@android.com,
	viro@zeniv.linux.org.uk,
	wedsonaf@gmail.com,
	willy@infradead.org,
	Valentin Obst <kernel@valentinobst.de>
Subject: Re: [PATCH v4 7/9] rust: file: add `Kuid` wrapper
Date: Mon,  5 Feb 2024 23:06:30 +0100
Message-ID: <20240205220630.16170-1-kernel@valentinobst.de>
In-Reply-To: <2024020214-concierge-rework-2ac5@gregkh>
References: <2024020214-concierge-rework-2ac5@gregkh>
Precedence: bulk
MIME-Version: 1.0
UI-OutboundReport: notjunk:1;M01:P0:RMvkSGwKUzo=;tyOEVgAKLOaDrnCdu4yT369T2Bm
 SpuPO8flQUVlLZeAgr+mv4wCHAsdhVJY03l8PvneEeKEGlwn6CN0MHQBJwbAGabIqgetLzaVB
 RnqiCZc57DYcIJ8RSKNJqelSequ7IDC/jwqIk7mt4h5nF7aYFmme8nWvh4mKsCb6bAFy1kgnI
 iBLhLFOiLknuKZMObcK+pG7uxNuZ/g4URQq+619gDh1Q7MPY+8kyzPb9IFGOWDqxHWdZ+6GmJ
 xXkGb+ihpW7YxNzWyL1Sa/AQUIt5Pknom86T8tL64UOTgd717V9lwj2noa3g78lB6373RZDZv
 0Bzmh0im/EqZyP02bueNIkqJ6HwT4i3qzjOR581AlQV5I0NlbuvsiuC6x/7KgmWoYQIf4+uql
 TGvF9E7Dm/tDEpOMcNJAGHfFuUujJHRjx4l/A+9TVJY566REVyVkEM8OHsJFmJ02nJKaPQZ02
 leC8G8nrnUquS4xEpEBpaTZX1WB5/rtBGrUcEHud5KwqENFr52+s2BpZZbufNkFZSbeRZ8ScI
 rbXvOURaOmEYsqpre9MEBWxGutfZ0plxvtWtiFP1eDOtsgyG7SG0IFb/Xymszerm7mTHDs4xu
 N7Ft1AT5ylZPWyg7hRmSA++Vv4kR2QaN0NrBcvB2SFfsVQR7tGamrOagWCK4EZAUYdZNZvR/2
 uYetrIXGQPjVQPBfUYs3p3pv+/uqrENnbRjK8Z9bpIRdkbi3WAKYhUJJr+wN3vpuAeEJTyGhX
 RKvZeZ5J1Rib1XLz9wCZlCugG/wg4m4h5oGp/JLJBsyhWadqyrW3eA=

> > +    /// Returns the given task's pid in the current pid namespace.
> > +    pub fn pid_in_current_ns(&self) -> Pid {
> > +        let current = Task::current_raw();
> > +        // SAFETY: Calling `task_active_pid_ns` with the current task is always safe.
> > +        let namespace = unsafe { bindings::task_active_pid_ns(current) };
> > +        // SAFETY: We know that `self.0.get()` is valid by the type invariant, and the namespace
> > +        // pointer is not dangling since it points at this task's namespace.
> > +        unsafe { bindings::task_tgid_nr_ns(self.0.get(), namespace) }
> > +    }
>
> pids are reference counted in the kernel, how does this deal with that?
> Are they just ignored somehow?  Where is the reference count given back?
>
> thanks,
>
> greg k-h

As far as I can see, neither `task_active_pid_ns` nor `task_active_pid_ns`
return with an incremented refcount. However, looking at the above code,
it looks like it could be simplified to:

```rust
pub fn pid_in_current_ns(&self) -> Pid {
    // SAFETY: We know that `self.0.get()` is valid by the type invariant.
    // Passing a null pointer in the second argument defaults to the current ns.
    unsafe { bindings::task_tgid_nr_ns(self.0.get(), ptr::null_mut()) }
}
```

Since:

```C
static inline pid_t task_tgid_nr_ns(struct task_struct *tsk, struct pid_namespace *ns)
{
	return __task_pid_nr_ns(tsk, PIDTYPE_TGID, ns);
}
..
pid_t __task_pid_nr_ns(struct task_struct *task, enum pid_type type,
			struct pid_namespace *ns)
{
	pid_t nr = 0;

	rcu_read_lock();
	if (!ns)
		ns = task_active_pid_ns(current);
	nr = pid_nr_ns(rcu_dereference(*task_pid_ptr(task, type)), ns);
	rcu_read_unlock();

	return nr;
}
EXPORT_SYMBOL(__task_pid_nr_ns);
```

anyway defaults to current's pid ns (plus some RCU lock protection, not sure if
that is relevant here).

	- Best Valentin