Received-SPF: pass (google.com: domain of linux-kernel+bounces-54019-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <7bb19ffd-0262-42bc-8123-c91e8d5b14e5@intel.com>
Date: Mon, 5 Feb 2024 15:32:09 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] device-dax: make dax_bus_type const
Content-Language: en-US
To: "Ricardo B. Marliere" <ricardo@marliere.net>,
 Dan Williams <dan.j.williams@intel.com>,
 Vishal Verma <vishal.l.verma@intel.com>
Cc: nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org,
 linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>
References: <20240204-bus_cleanup-dax-v1-1-69a6e4a8553b@marliere.net>
From: Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20240204-bus_cleanup-dax-v1-1-69a6e4a8553b@marliere.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 2/4/24 9:07 AM, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the dax_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
>  drivers/dax/bus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c
> index 1659b787b65f..fe0a415c854d 100644
> --- a/drivers/dax/bus.c
> +++ b/drivers/dax/bus.c
> @@ -222,7 +222,7 @@ static void dax_bus_remove(struct device *dev)
>  		dax_drv->remove(dev_dax);
>  }
>  
> -static struct bus_type dax_bus_type = {
> +static const struct bus_type dax_bus_type = {
>  	.name = "dax",
>  	.uevent = dax_bus_uevent,
>  	.match = dax_bus_match,
> 
> ---
> base-commit: 73bf93edeeea866b0b6efbc8d2595bdaaba7f1a5
> change-id: 20240204-bus_cleanup-dax-52c34f72615f
> 
> Best regards,