Received-SPF: pass (google.com: domain of linux-kernel+bounces-54102-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <3c344e06-ac15-abe2-4fd6-5735090a1f58@quicinc.com>
Date: Mon, 5 Feb 2024 15:42:59 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] spmi: pmic-arb: Replace three IS_ERR() calls by null
 pointer checks in spmi_pmic_arb_probe()
Content-Language: en-US
To: Markus Elfring <Markus.Elfring@web.de>, <kernel-janitors@vger.kernel.org>,
        AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>,
        Bjorn
 Andersson <andersson@kernel.org>, Fei Shao <fshao@chromium.org>,
        Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>,
        Peng Wu <wupeng58@huawei.com>, Stephen Boyd <sboyd@kernel.org>,
        Vinod Koul <vkoul@kernel.org>
CC: LKML <linux-kernel@vger.kernel.org>,
        Dmitry Baryshkov
	<dmitry.baryshkov@linaro.org>
References: <82a0768e-95b0-4091-bdd1-14c3e893726b@web.de>
From: David Collins <quic_collinsd@quicinc.com>
In-Reply-To: <82a0768e-95b0-4091-bdd1-14c3e893726b@web.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On 2/4/24 01:24, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 4 Feb 2024 09:39:48 +0100
> 
> The devm_ioremap() function does not return error pointers.
> It returns NULL on error.
> This issue was detected once more also by using the Coccinelle software.
> 
> Update three checks (and corresponding error codes) for failed
> function calls accordingly.
> 
> Fixes: ffdfbafdc4f4 ("spmi: Use devm_spmi_controller_alloc()")
> Fixes: 231601cd22bd ("spmi: pmic-arb: Add support for PMIC v7")
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> 
> See also:
> Suggestion by Peng Wu
> [PATCH -next] spmi: pmic-arb: fix a NULL vs IS_ERR() check in spmi_pmic_arb_probe()
> https://lore.kernel.org/lkml/20221115090927.47143-1-wupeng58@huawei.com/
> https://lkml.org/lkml/2022/11/15/197
> 
> 
>  drivers/spmi/spmi-pmic-arb.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Reviewed-by: David Collins <quic_collinsd@quicinc.com>

Thanks for making this fix.

Take care,
David