Received-SPF: pass (google.com: domain of linux-kernel+bounces-54129-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240205090552.40567-1-zhaoyang.huang@unisoc.com> <ZcFbl0zP2pK6vEmh@casper.infradead.org>
In-Reply-To: <ZcFbl0zP2pK6vEmh@casper.infradead.org>
From: Zhaoyang Huang <huangzhaoyang@gmail.com>
Date: Tue, 6 Feb 2024 08:44:09 +0800
Message-ID: <CAGWkznGzWW6yORWvKt5p=2O4S1FtkNe4W42SwYduE70hVkiuBg@mail.gmail.com>
Subject: Re: [PATCHv8 1/1] block: introduce content activity based ioprio
To: Matthew Wilcox <willy@infradead.org>
Cc: "zhaoyang.huang" <zhaoyang.huang@unisoc.com>, Jens Axboe <axboe@kernel.dk>, 
	Yu Zhao <yuzhao@google.com>, linux-block@vger.kernel.org, 
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, 
	steve.kang@unisoc.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 6, 2024 at 6:05=E2=80=AFAM Matthew Wilcox <willy@infradead.org>=
 wrote:
>
> On Mon, Feb 05, 2024 at 05:05:52PM +0800, zhaoyang.huang wrote:
> > +void bio_set_active_ioprio(struct bio *bio)
>
> why does this still exist?  i said no.
I supplied two sets of APIs in v8, this one is for iterating the bio.
The reason is bio_add_page/folio could return success without adding a
page which can not be dealt with bio_set_active_ioprio_folio
>
> > +void bio_set_active_ioprio_page(struct bio *bio, struct page *page)
>
> this function should not exist.
>
> > +void bio_set_active_ioprio_folio(struct bio *bio, struct folio *folio)
>
> this is the only one which should.  did you even look at the
> implementation of PageWorkingset?
>
> > +extern void bio_set_active_ioprio(struct bio *bio);
> > +extern void bio_set_active_ioprio_folio(struct bio *bio, struct folio =
*folio);
> > +extern void bio_set_active_ioprio_page(struct bio *bio, struct page *p=
age);
>
> do not mark function prototypes with extern.
>
> > +#ifdef CONFIG_BLK_CONT_ACT_BASED_IOPRIO
> > +     /*
> > +      * bi_cont_act record total activities of bi_io_vec->pages
> > +      */
> > +     u64                     bi_cont_act;
> > +#endif
>
> what?
>
> look, you just don't understand.  i've spent too much time replying to
> you trying to help you.  i give up.  everything to do with this idea is
> NAKed.  go away.
Sorry for the confusion, but I have to find a place to record the
historic bio's activities for bio_set_active_ioprio_folio. There could
be many bio_add_folios before submit_bio