Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp2749927rdb; Mon, 5 Feb 2024 17:14:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IGGBtmeps9lreTgxT04jM9q0vsCaj7CsbOYhYOFhd+b/EKc4h60ZyBGVgazWCV/XaSrgwoZ X-Received: by 2002:a05:620a:9ce:b0:783:6eae:547 with SMTP id y14-20020a05620a09ce00b007836eae0547mr12261362qky.22.1707182071581; Mon, 05 Feb 2024 17:14:31 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707182071; cv=pass; d=google.com; s=arc-20160816; b=eHxodOoZSJuie+b5LAHf4dSB1m293ZJCKCINh9hHkaOmtNnUqRI5reIoSIxji2ph4D 7c0VmE9Lmw6z4F8trbCvnWRNhNIlpLcYjtjAok6EiNxIKzqX8/Svpr8Xhrf47LbbZv2U Ah8LDa7cjo4PFH7Ernoqc0/e7fRnkwnZuGqfHTxtqH+QcVApC7NJ6bI1iZYhb0hSknnl hwfjqeQ4s46XAe1ii732umO37uNH5hV8Q+p494hjRRpfecf28BjSxfYOe26kxpQdd6/M /TIIjs9+Yy8LCrONMQYuzOQ7vE3IoILyA9tMoautm5oVHsdiPPDulqTidGBOoeUIR6It F8eA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature :dkim-signature:dkim-signature:dkim-signature; bh=UiIFSjMANUa+9UeiEF/545Jd5pXGZvoSBum87AnCT2E=; fh=tvGS/19Dd3sDNLW/6grMMSW3knYK2DyKMNu5Ss3D+sQ=; b=DJtjZcDLWkCdtv+cbtsO0RxSTQzIxmBfiHFhz6cCi3o0zSwZSA2qJ8p0i3SlVEMh0X xesq7rIH480KB/xkQrooFV/fHqQMkNt07CLSgyaQbA2DT65hEeI8bc6C/cOuC8OQTpqt FZmUwQG9tDEjpxgLg834VwKj6N4i7Y2YYkp4gduwm5r11HNHtVifqzarYI5gWRmCDnzZ M5IFM+CcQf8eKvOubg9n9m+1cLWGr9Cf25kxPbdNwBPHeVc4l5V6x/Jp8X94lcHGS9uM +kTUHzKmWOsF/PPzJpGydgYEI5xIjyER+dUEQC4+ydnlK8BJi1/jMv/pXSvVX6oU8ZUx vhOg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=aex2GQHF; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=C5YAA1RZ; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=aex2GQHF; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-54144-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54144-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de X-Forwarded-Encrypted: i=1; AJvYcCU9uc2AnBsvuH7nbVlKZqpqiiQ7R4+Okev9PBzKS8v+W+/lL6d0Tt+jVBPcMFZrtJGK+TgyCOLeGUfmLnI8tUbFBtWH4qplZDt3RPXu7w== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id h18-20020ac87d52000000b0042c2a78d9absi1251912qtb.373.2024.02.05.17.14.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 17:14:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-54144-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=aex2GQHF; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=C5YAA1RZ; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=aex2GQHF; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-54144-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54144-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 495011C23174 for ; Tue, 6 Feb 2024 01:14:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EACB346A2; Tue, 6 Feb 2024 01:14:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="aex2GQHF"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="C5YAA1RZ"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="aex2GQHF"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="C5YAA1RZ" Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D2091361; Tue, 6 Feb 2024 01:14:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707182060; cv=none; b=tikYGiTDFREEC1Ev4XYd1MFA+a6dKach7i1gs9OuwqK1plRA3DlRb5IB3lI7SIEXA8oC8Lf62BcLTQ0QpFp9jtTvS6SeSsx7JJ9+Sw3y7/jhf81Uj0IZh1GE2Qkssa/J3tg/FdCtnZt8eLX60bn7Z2SM/hsWCuK3cN2U+nl2ahE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707182060; c=relaxed/simple; bh=F8Hvf1QeiETO7+L1PqIcHzakau86I1STWf/wMtgoTJg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FAn5OXGUY3yR851qMlKbTgPM/sHO4eT5hMYSR1z+otooFEKqZ2CNpMCEBdPOfFYyUTltTkkA9oWvFLmq8QB5GJHTJrdA4JXep3cdmyMyRIj7xyUCzhMocnG7lg+BulULAOFWpk5mgisqJqDoUkE1IvQhN57y699GBPpXwnIUzOk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=aex2GQHF; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=C5YAA1RZ; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=aex2GQHF; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=C5YAA1RZ; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 90AE922124; Tue, 6 Feb 2024 01:14:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707182055; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UiIFSjMANUa+9UeiEF/545Jd5pXGZvoSBum87AnCT2E=; b=aex2GQHFdr90InjB1m0y0FRlXWW8krJ+6UcQ3j+vV0RZdafKAHt2MVJI8tZdpnw3OVAbpD oYeInO7pwp4wjZ8vAOWlYmxK2+QOBwM7sorh9RY7ne87Ybu3za0e2Qhp/XN1ruohkJoJxK uQlmmdUswax/yL+C2+wn8aMG41kvUIE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707182055; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UiIFSjMANUa+9UeiEF/545Jd5pXGZvoSBum87AnCT2E=; b=C5YAA1RZf/zgENhOoR9KJ9cDyTo0p4LoEopNJ5wbHnP9HgXWkJYla7yFVET0TUUN1GBBnq mfbAMXBTi3xQXQDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707182055; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UiIFSjMANUa+9UeiEF/545Jd5pXGZvoSBum87AnCT2E=; b=aex2GQHFdr90InjB1m0y0FRlXWW8krJ+6UcQ3j+vV0RZdafKAHt2MVJI8tZdpnw3OVAbpD oYeInO7pwp4wjZ8vAOWlYmxK2+QOBwM7sorh9RY7ne87Ybu3za0e2Qhp/XN1ruohkJoJxK uQlmmdUswax/yL+C2+wn8aMG41kvUIE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707182055; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UiIFSjMANUa+9UeiEF/545Jd5pXGZvoSBum87AnCT2E=; b=C5YAA1RZf/zgENhOoR9KJ9cDyTo0p4LoEopNJ5wbHnP9HgXWkJYla7yFVET0TUUN1GBBnq mfbAMXBTi3xQXQDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3F729132DD; Tue, 6 Feb 2024 01:14:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id YexqO+WHwWXrAgAAD6G6ig (envelope-from ); Tue, 06 Feb 2024 01:14:13 +0000 Message-ID: Date: Tue, 6 Feb 2024 10:14:11 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] Revert "scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock" Content-Language: en-US To: Lee Duncan , linux-scsi@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Lee Duncan References: <83489c47c973bdf7c47e4bf3acbc57dfca1e5dd7.1706632031.git.lduncan@suse.com> From: Hannes Reinecke In-Reply-To: <83489c47c973bdf7c47e4bf3acbc57dfca1e5dd7.1706632031.git.lduncan@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Authentication-Results: smtp-out1.suse.de; none X-Spamd-Result: default: False [-0.09 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_SOME(0.00)[]; BAYES_HAM(-0.00)[41.51%]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.com:email]; FREEMAIL_TO(0.00)[gmail.com,vger.kernel.org]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Level: X-Spam-Flag: NO X-Spam-Score: -0.09 On 1/31/24 00:42, Lee Duncan wrote: > From: Lee Duncan > > This reverts commit 1a1975551943f681772720f639ff42fbaa746212 > > This commit causes interrupts to be lost for FCoE devices, > since it changed sping locks from "bh" to "irqsave". > > Instead, a work queue should be used, and will be addressed > in a separate patch. > > Fixes: 1a1975551943f681772720f639ff42fbaa746212 > Signed-off-by: Lee Duncan > --- > drivers/scsi/fcoe/fcoe_ctlr.c | 20 ++++++++------------ > 1 file changed, 8 insertions(+), 12 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), GF: Ivo Totev, Andrew McDonald, Werner Knoblich