Received-SPF: pass (google.com: domain of linux-kernel+bounces-54148-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <ad231c28-c451-4b1d-9d96-c0245d77da28@suse.de>
Date: Tue, 6 Feb 2024 10:23:43 +0900
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] fnic: move fnic_fnic_flush_tx() to a work queue
Content-Language: en-US
To: Lee Duncan <leeman.duncan@gmail.com>, linux-scsi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Lee Duncan <lduncan@suse.com>
References: <cover.1706632031.git.lduncan@suse.com>
 <9c51ef07a04413fb2f2bd20f1534f96e004e4e59.1706632031.git.lduncan@suse.com>
From: Hannes Reinecke <hare@suse.de>
In-Reply-To: <9c51ef07a04413fb2f2bd20f1534f96e004e4e59.1706632031.git.lduncan@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 1/31/24 00:42, Lee Duncan wrote:
> From: Hannes Reinecke <hare@suse.de>
> 
> Rather than call 'fnic_flush_tx()' from interrupt context we should
> be moving it onto a work queue to avoid any locking issues.
> 
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Lee Duncan <lduncan@suse.com>
> ---
>   drivers/scsi/fnic/fnic.h      | 3 ++-
>   drivers/scsi/fnic/fnic_fcs.c  | 3 ++-
>   drivers/scsi/fnic/fnic_main.c | 1 +
>   drivers/scsi/fnic/fnic_scsi.c | 4 ++--
>   4 files changed, 7 insertions(+), 4 deletions(-)
> 
Can you please add the 'fixes' tag to this one, too?
Just the first patch doesn't fix anything, one really would
need to apply both to get the issue fixed.

And, of course, fix the kbuild robot warning :-)

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Ivo Totev, Andrew McDonald,
Werner Knoblich