Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp2769167rdb; Mon, 5 Feb 2024 18:09:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IGMi5mkKuuCCD3zvU9lbP8X8V8+tG6EOKMqT7HqcM9yPYiNGhxL7qoJfXuIFdM46JQ25eLJ X-Received: by 2002:a05:6214:d6a:b0:68c:9b50:b6a4 with SMTP id 10-20020a0562140d6a00b0068c9b50b6a4mr1095041qvs.33.1707185380297; Mon, 05 Feb 2024 18:09:40 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707185380; cv=pass; d=google.com; s=arc-20160816; b=GKHCPBVxAV/gv/7gp66lXORTSzY5Aj/+1lGjHHu9eR+KQ9Y+g3a7HiKc6R5xpK5Vry 9Tmo4m8yHaFF0QqbDT4UJT3Mxbt2AGeZckz8BTWuSN85xtEOYku4KNxKE9OeJYZt9JtQ er1Yd+dKkAQdGsQ1B/jv1OKkCJw+0g5EZbEbb3cWSQHO90j/wJqDo7gD3pO9agfiQSVU J3LsVMDd7C9Aeu22VrXSTbL7ozNdNzvuaxuh42+sdvtMPXZ0XRMMwlr7fmvRBcoStVad yPmCOeMV53xMe+Xyjem3cE3b1Q1VHtKF8jx4gExNUGraH+9/xBQ+GcFa2hOgaVUmA60w 8kuQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=TNBqmrMN0GKiz0meyol2MTt7jK7ZOMX41ADnOQ7L/UU=; fh=nwSEOsF8F2ZY2XjTe2E+h4TgC+/1Whya0p0DurPkTQ0=; b=0aaVw5zYHAixjJsrBpjDR3v8mBqNU2Ag3zMxJ+MCrNKSSa65TJle7HgS2tep/VXhFu 3MNmTBrW0g81kYfNkFB236uXR6jA27YMSGMps1kV2bHG5zXThAAkjB/3M6l009dM92qE aTCxEHWoje2mNr04rNLdWZPAGN5iV7W35VvQNtml6bsvof6vRIKgn9wfMtXjUsbZWofJ 0ySSRR3cglowdSEcj4cpcAzOA1zTpwgQq1aCV6Bby5LuKSl+NEOvy8+p8254sNVUVomL us7BApLTulGICGI1PknP0RPL0BYSDwm0yvU30HjubttS84gYA005aSTBS1SRzEZq5/WM DfPg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-11-20 header.b=b+KMj6tv; arc=pass (i=1 spf=pass spfdomain=oracle.com dkim=pass dkdomain=oracle.com dmarc=pass fromdomain=oracle.com); spf=pass (google.com: domain of linux-kernel+bounces-54182-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54182-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com X-Forwarded-Encrypted: i=1; AJvYcCWv0I4vlnIwOKZAJannpo8T1yHDRZPD/hwtG4E6uBl4qFMMFEjgsjNUPKxAEcRoBt8lbZKjq24mZRBmpcz3+IXLi3HLEmyvesFTkx0qNQ== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id j5-20020a0cc345000000b0068c3515c906si1357037qvi.273.2024.02.05.18.09.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 18:09:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-54182-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-11-20 header.b=b+KMj6tv; arc=pass (i=1 spf=pass spfdomain=oracle.com dkim=pass dkdomain=oracle.com dmarc=pass fromdomain=oracle.com); spf=pass (google.com: domain of linux-kernel+bounces-54182-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54182-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id F2EAF1C23DC5 for ; Tue, 6 Feb 2024 02:09:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 60A2C56B9C; Tue, 6 Feb 2024 02:09:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="b+KMj6tv" Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78EBA56B6F; Tue, 6 Feb 2024 02:09:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.177.32 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707185358; cv=none; b=E7PEzjVEZxWqzIHGlJ7z4Na+iQX7i8W99HKf7Su6+Mi6X7v0F3QzWHRZl3DFV8/M82VMIQter1OaQqFNxhyRkwI9MVVmFFoMHvJll2QaRqWktz79YKJv368I7gGhrVHY06aRlpznxQK3BF7Q+jgP9oKaEhJidVe4r9/hXO1i8Ng= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707185358; c=relaxed/simple; bh=WYfoRPya76Tqck0ScDgB0y5w0roJ0OYNP1LTT+2qcEk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=JeHGi5PkP5aBV4JD0Kmh/1Gmst9kmQ2fRsukbqwjuNpgEyp7RogdrwtIfOvTuRdrwHH175kx2jFIXfCvTML7bcW/xYA6k+K17lVx6pZ+DK/N07YfD5MCMpAVyafzxXHUPk465qrTImGkkJgSIoeIM9leUAJv3wGldj3E1pUyh3s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=b+KMj6tv; arc=none smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 4161EYUn020918; Tue, 6 Feb 2024 02:08:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2023-11-20; bh=TNBqmrMN0GKiz0meyol2MTt7jK7ZOMX41ADnOQ7L/UU=; b=b+KMj6tvO4efzEbKZhSG/xzlHnsPmbgMlBfcTWawkZTnAIffaQla4J5cVDofspUuJqWS /o00HHnk0n3gN9qp3mx/3E4gJC1I52m2sdoqn6JFMG+i8UwxEXr0NcQnIWxdhEFBJn+E /x8af1pQLtk1k1AM1L7u822p8aQ15VNJPSq8MPE9D4515Gx5HixPyTgAvA3/EgoqxoHI QgW4sF8UUf5WKq6QgWwluTQ92vNZ9x/szjLyibVmDwZBAu8ox17jHGO02Dm+ih1uUcH6 DGK4SsClE47m3SK3AzW4xYXw6GyPWvrQpLAswBi0lOq+tWmzWKU14KToHTtMKtqix0Tu 5w== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3w1bwengt7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 06 Feb 2024 02:08:03 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 4160ucci039478; Tue, 6 Feb 2024 02:08:02 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3w1bx6cdtw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 06 Feb 2024 02:08:02 +0000 Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 41627qHJ034652; Tue, 6 Feb 2024 02:08:01 GMT Received: from ca-mkp2.ca.oracle.com.com (mpeterse-ol9.allregionaliads.osdevelopmeniad.oraclevcn.com [100.100.251.135]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 3w1bx6cdrb-2; Tue, 06 Feb 2024 02:08:01 +0000 From: "Martin K. Petersen" To: linux-kernel@vger.kernel.org, Li Zhijian Cc: "Martin K . Petersen" , Adaptec OEM Raid Solutions , Adrian Hunter , Alexander Shishkin , Alistar Popple , "Aneesh Kumar K.V" , Arnaldo Carvalho de Melo , Artur Paszkiewicz , Benjamin Tissoires , Borislav Petkov , =?UTF-8?q?Bruno=20Pr=C3=A9mont?= , Chandrakanth patil , Christian Gromm , Christophe Leroy , cocci@inria.fr, Dave Hansen , Don Brace , dri-devel@lists.freedesktop.org, Eddie James , GR-QLogic-Storage-Upstream@marvell.com, Hannes Reinecke , Hannes Reinecke , Hans de Goede , Helge Deller , HighPoint Linux Team , "H. Peter Anvin" , Ian Rogers , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Ingo Molnar , Jack Wang , "James E.J. Bottomley" , "James E.J. Bottomley" , James Morse , Jeremy Kerr , Jiri Kosina , Jiri Olsa , Joel Stanley , Jonathan Cameron , Julia Lawall , Karan Tilak Kumar , Kashyap Desai , Ketan Mukadam , Laurentiu Tudor , linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-fsi@lists.ozlabs.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-scsi@vger.kernel.org, Manish Rangankar , Mark Rutland , Mauro Carvalho Chehab , megaraidlinux.pdl@broadcom.com, Michael Cyr , Michael Ellerman , Michal Januszewski , MPT-FusionLinux.pdl@broadcom.com, Namhyung Kim , "Naveen N. Rao" , netdev@vger.kernel.org, Nicholas Piggin , Nicolas Palix , Nilesh Javali , Parthiban Veerasooran , Peter Zijlstra , platform-driver-x86@vger.kernel.org, Richard Cochran , Robert Richter , Russell King , Sathya Prakash , Satish Kharat , Sesidhar Baddela , Shivasharan S , Sreekanth Reddy , Srinivas Pandruvada , Stefan Achatz , storagedev@microchip.com, Stuart Yoder , Suganath Prabu Subramani , Sumit Saxena , target-devel@vger.kernel.org, Thomas Gleixner , Tony Luck , Tyrel Datwyler , Vadim Pasternak , x86@kernel.org Subject: Re: (subset) [PATCH 00/42] Fix coccicheck warnings Date: Mon, 5 Feb 2024 21:07:38 -0500 Message-ID: <170715263710.945763.16540743989774199712.b4-ty@oracle.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20240116041129.3937800-1-lizhijian@fujitsu.com> References: <20240116041129.3937800-1-lizhijian@fujitsu.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-05_18,2024-01-31_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 phishscore=0 spamscore=0 adultscore=0 mlxlogscore=999 malwarescore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402060013 X-Proofpoint-ORIG-GUID: pTT_U64MvKVXcaNppMcpJ2F1AhkrIKYI X-Proofpoint-GUID: pTT_U64MvKVXcaNppMcpJ2F1AhkrIKYI On Tue, 16 Jan 2024 12:10:47 +0800, Li Zhijian wrote: > make coccicheck COCCI=$PWD/scripts/coccinelle/api/device_attr_show.cocci` > complians some warnnings as following[1]: > > Not sure if someone had tried these fixes, feel free to ignore this > patch set if we have come to a *NOT-FIX* conclusion before :) > > This patch set also fix a few snprintf() beside coccicheck reported. > For example, some thing like > xxx_show() { > rc = snprintf(); > ... > return rc; > } > > [...] Applied to 6.9/scsi-queue, thanks! [22/42] drivers/scsi/fnic: Convert snprintf to sysfs_emit https://git.kernel.org/mkp/scsi/c/1ad717c92925 [25/42] drivers/scsi/ibmvscsi: Convert snprintf to sysfs_emit https://git.kernel.org/mkp/scsi/c/29ff822f466e [26/42] drivers/scsi/ibmvscsi_tgt: Convert snprintf to sysfs_emit https://git.kernel.org/mkp/scsi/c/01105c23de42 [27/42] drivers/scsi/isci: Convert snprintf to sysfs_emit https://git.kernel.org/mkp/scsi/c/5fbf37e53091 [34/42] drivers/scsi/pm8001: Convert snprintf to sysfs_emit https://git.kernel.org/mkp/scsi/c/8179041f801d -- Martin K. Petersen Oracle Linux Engineering