Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp2769273rdb; Mon, 5 Feb 2024 18:09:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IFc46u5St86BrcRpXi1JjI/Q3Fq7cE9lxFPu8k96E/3LF81DOgP4/By9FZnQLlswHVCgw3z X-Received: by 2002:a05:6902:e0b:b0:dc2:2dee:b139 with SMTP id df11-20020a0569020e0b00b00dc22deeb139mr337838ybb.18.1707185394068; Mon, 05 Feb 2024 18:09:54 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707185394; cv=pass; d=google.com; s=arc-20160816; b=rGmDnL4fr23NCp/C3lKJDzqd1eqlafvsp7dtgLPwddJzetFAxBlRPzSDMca9p1xVyt c1R7zz5A55TK14wWOkiSK+5P9li7Fkg/HrdJlvO5E3BcTRD/b5NZcU0InbXzp34q9ozv 2hI1h6d2Jb7Veq7wbcqHtm46IoeHHCrsbX2lhoggiTY5JfQQrjDMMlpuyu2+u5t+IFEU 4eWjwJoSUAa7n93wFYPEvMRPTtoEzbX6AckbrcEDVUW3Yu6nWCCthGtNSlWa7TdyiHwy qC7aWxXMrAKIU3CNeashZc/9Ft8Z9BsmKCSckTVYsoO/m+dRZKDzFXnuQhqzyB1AfvD0 sGDQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=G7HdZBkNz5lLne62b3vVRjDKdnTLtIWxgUypQkVo4AA=; fh=Y20NITCB7KogvmAgzbvGAfAEntD34TTh+8VNGg7QhO0=; b=HJWb/sOD7Q9ybsezjRzwFmavaYW1fnKU/3PsITiZaK04j6N1vSXbHTkwMDYipQLRGk ebsg9WzYPlGAc5NkS2IF5oGNZEKZR8bPv2ghPHm5cJju5NsRnSmkIuX8l9e6111HiepU JDMBD/3XEEc5yptbuznYcT6iBZgtv+FHkqDwzJjPeEdLkb9S9gxgfEhLpfZyvpbB5ql7 qi8iTI2+LaUnBlzmCeJQFIUelUmmblIbYZPqH8KYHgmPDD54wtKIXzd9eYcDD/3TtS+e SspC6NFkEH7ll+FC19o7M0cUqULmCxb+eMWI6odaURCWxgofHs3ypPonBoIvUuoEBGjH h3NA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-11-20 header.b=ljjohSHb; arc=pass (i=1 spf=pass spfdomain=oracle.com dkim=pass dkdomain=oracle.com dmarc=pass fromdomain=oracle.com); spf=pass (google.com: domain of linux-kernel+bounces-54183-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54183-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com X-Forwarded-Encrypted: i=1; AJvYcCXMyNp6jt6NgvKbnAeQZHxkb6WX9y0M4mEL47wOnEC65dr+GO765OZ3btoPh6VdF7B7ihkL2Jq27n76pGLOj8JTrZ48++dzDTWIfWqw6A== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id j5-20020a0cc345000000b0068c3515c906si1357037qvi.273.2024.02.05.18.09.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 18:09:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-54183-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-11-20 header.b=ljjohSHb; arc=pass (i=1 spf=pass spfdomain=oracle.com dkim=pass dkdomain=oracle.com dmarc=pass fromdomain=oracle.com); spf=pass (google.com: domain of linux-kernel+bounces-54183-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54183-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id CF3631C23E03 for ; Tue, 6 Feb 2024 02:09:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 485AE58113; Tue, 6 Feb 2024 02:09:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="ljjohSHb" Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D82D857323; Tue, 6 Feb 2024 02:09:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.165.32 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707185360; cv=none; b=hbNWvRrHTiSH1Tq73YROHw6PTE1txeR3YCHtOh9u7bFAL/SEXRHZhMAK1SmU2QqXLPTo62kNDB88ul4DeRnbUksaJ/S1lmQ7xAKVQX/OlCUnbFJImi+aU5VuYrf2vpluYrMwzgbEVdxR8l03CJZeQGs7KVQLShTDCdq830ELj9E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707185360; c=relaxed/simple; bh=wdnYagnlXJL8GHTWDPK85zAJiKUOzaiblB/nDgI8EEs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lb8Cbrzeg8qPbcmDADL0Uim81V/bfKCenUI13M7CmfYIkU4RT/3eQ6MTXuvo0GLGpZG+SbkIAWG9BLRaT6IMbXhmLL336G73tbL/hzzOVGueMGzBuAoCky0N36odJB372CeNKX4AhO6mYiaG6tMWdrHG9V+/Wt6vW/2XXh8PbGU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=ljjohSHb; arc=none smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 4161EldR002551; Tue, 6 Feb 2024 02:09:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2023-11-20; bh=G7HdZBkNz5lLne62b3vVRjDKdnTLtIWxgUypQkVo4AA=; b=ljjohSHb7RahFnjBOG3x3E09HIb0dVEAJ5eP8bgI8ZbBWSbbF+Uzs43DI6tol6B8J3rw 4G8IWAIJ4YMlrteZlnJLyOq6eIiHF3pE1kAr6moWhdRwsinO9IJaq2r9pBJR5XmxIOAy +wOSob4GU/QFymEoKbLMFp5AyIX1VsHZdWSXBqy78eoH5pFOYjQNmK7QYejzKEBxh6FE I+UkB/31hDerT3kT8SoTFPYW2BwZKD51F1T07kyPthXPneaBq00FpGdu31BCnVAddxpA gHWniid75jMySMshfWofBluu4mGxkXMDEiJIgReaP1Khp4p1fFfsbRzKTGO6i2f4pVGS NQ== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3w1cdcwkn5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 06 Feb 2024 02:09:12 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 4161o9cD039427; Tue, 6 Feb 2024 02:09:11 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3w1bx6ceh0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 06 Feb 2024 02:09:11 +0000 Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 416297CM038970; Tue, 6 Feb 2024 02:09:10 GMT Received: from ca-mkp2.ca.oracle.com.com (mpeterse-ol9.allregionaliads.osdevelopmeniad.oraclevcn.com [100.100.251.135]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 3w1bx6cef6-3; Tue, 06 Feb 2024 02:09:10 +0000 From: "Martin K. Petersen" To: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, alim.akhtar@samsung.com, avri.altman@wdc.com, jejb@linux.ibm.com, beanhuo@micron.com, bvanassche@acm.org, kwangwon.min@samsung.com, kwmad.kim@samsung.com, sh425.lee@samsung.com, sc.suh@samsung.com, quic_nguyenb@quicinc.com, cpgs@samsung.com, grant.jung@samsung.com, junwoo80.lee@samsung.com, SEO HOYOUNG Cc: "Martin K . Petersen" Subject: Re: [PATCH v1] scsi: ufs: core: Remove the ufshcd_release in ufshcd_err_handling_prepare Date: Mon, 5 Feb 2024 21:08:57 -0500 Message-ID: <170718504185.1101069.1333761980481958791.b4-ty@oracle.com> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20240122083324.11797-1-hy50.seo@samsung.com> References: <20240122083324.11797-1-hy50.seo@samsung.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-05_18,2024-01-31_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 phishscore=0 spamscore=0 adultscore=0 mlxlogscore=723 malwarescore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402060014 X-Proofpoint-GUID: T7j6YWOXvAeiB03GXynNiuLI1jWPZs40 X-Proofpoint-ORIG-GUID: T7j6YWOXvAeiB03GXynNiuLI1jWPZs40 On Mon, 22 Jan 2024 17:33:24 +0900, SEO HOYOUNG wrote: > If err_handler is performed in the suspend/resume situation, ufs_release > can be called twice and active_reqs valid can be negative. > This is because ufshcd_errhandling_prepare() and > ufshcd_err_handling_unprepare() repeatedly release calls. > Eventually, active_reqs have a value different from the intention. > To prevent this, release duplication processing was removed. > > [...] Applied to 6.8/scsi-fixes, thanks! [1/1] scsi: ufs: core: Remove the ufshcd_release in ufshcd_err_handling_prepare https://git.kernel.org/mkp/scsi/c/17e94b258541 -- Martin K. Petersen Oracle Linux Engineering