Received-SPF: pass (google.com: domain of linux-kernel+bounces-54187-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <f15f0df1-92be-4bc9-82a2-1d8fa3275dd7@web.de> <daf2172a-8d54-4097-acf3-cc539fe281e5@web.de>
In-Reply-To: <daf2172a-8d54-4097-acf3-cc539fe281e5@web.de>
From: Namhyung Kim <namhyung@kernel.org>
Date: Mon, 5 Feb 2024 18:12:50 -0800
Message-ID: <CAM9d7ciHGv9s92Yz4VuFUhuN9HCHe=Bq7dMD_XSBTkg1+tYw+w@mail.gmail.com>
Subject: Re: [RFC] perf: Reconsider an error code selection in bpf_map__fprintf()
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-perf-users@vger.kernel.org, kernel-janitors@vger.kernel.org, 
	Adrian Hunter <adrian.hunter@intel.com>, 
	Alexander Shishkin <alexander.shishkin@linux.intel.com>, Alexei Starovoitov <ast@kernel.org>, 
	Andrii Nakryiko <andrii@kernel.org>, Arnaldo Carvalho de Melo <acme@kernel.org>, Christy Lee <christylee@fb.com>, 
	Daniel Borkmann <daniel@iogearbox.net>, Ian Rogers <irogers@google.com>, 
	Ingo Molnar <mingo@redhat.com>, Jiri Olsa <jolsa@kernel.org>, 
	John Fastabend <john.fastabend@gmail.com>, KP Singh <kpsingh@kernel.org>, 
	Mark Rutland <mark.rutland@arm.com>, Martin KaFai Lau <kafai@fb.com>, 
	Peter Zijlstra <peterz@infradead.org>, Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>, 
	YueHaibing <yuehaibing@huawei.com>, bpf@vger.kernel.org, netdev@vger.kernel.org, 
	LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello,

On Thu, Feb 1, 2024 at 10:49=E2=80=AFPM Markus Elfring <Markus.Elfring@web.=
de> wrote:
>
> > A null pointer check is performed for the input parameter =E2=80=9Cmap=
=E2=80=9D.
> > It looks suspicious that the function =E2=80=9CPTR_ERR=E2=80=9D is appl=
ied then for
> > a corresponding return statement.
>
> Are contributions also by YueHaibing still waiting on further development=
 considerations?
>
> [PATCH -next] perf: Fix pass 0 to PTR_ERR
> https://lore.kernel.org/lkml/20220611040719.8160-1-yuehaibing@huawei.com/
> https://lkml.org/lkml/2022/6/11/3

I think we dropped the bpf-loader and it seems bpf_map.[ch] is
leftover.  I don't see any users of bpf_map__fprintf() in the tree.
Maybe we can drop it too.

Thanks,
Namhyung