Received-SPF: pass (google.com: domain of linux-kernel+bounces-54206-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 5 Feb 2024 12:54:43 -0800
From: Davidlohr Bueso <dave@stgolabs.net>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Jonathan Cameron <jonathan.cameron@huawei.com>,
	Dave Jiang <dave.jiang@intel.com>,
	Alison Schofield <alison.schofield@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Ira Weiny <ira.weiny@intel.com>,
	Dan Williams <dan.j.williams@intel.com>, linux-cxl@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cxl: remove CONFIG_CXL_PMU entry in drivers/cxl/Kconfig
Message-ID: <20240205205443.sottm4g4ywl55ujr@offworld>
References: <20240204094613.40687-1-masahiroy@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20240204094613.40687-1-masahiroy@kernel.org>
User-Agent: NeoMutt/20220429

On Sun, 04 Feb 2024, Masahiro Yamada wrote:

>Commit 5d7107c72796 ("perf: CXL Performance Monitoring Unit driver")
>added the config entries for CXL_PMU in drivers/cxl/Kconfig and
>drivers/perf/Kconfig, so it can be toggled from multiple locations:
>
>[1] Device Drivers
>     -> PCI support
>       -> CXL (Compute Expres Link) Devices
>         -> CXL Performance Monitoring Unit
>
>[2] Device Drivers
>     -> Performance monitor support
>       -> CXL Performance Monitoring Unit
>
>This complicates things, and nobody else does this.
>
>I kept the one in drivers/perf/Kconfig because CONFIG_CXL_PMU controls
>the compilation of drivers/perf/cxl_pmu.c.

Completely agree. In general we should try to keep config
options minimal where possible.

Acked-by: Davidlohr Bueso <dave@stgolabs.net>

>
>Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
>---
>
> drivers/cxl/Kconfig | 13 -------------
> 1 file changed, 13 deletions(-)
>
>diff --git a/drivers/cxl/Kconfig b/drivers/cxl/Kconfig
>index 67998dbd1d46..5f3c9c5529b9 100644
>--- a/drivers/cxl/Kconfig
>+++ b/drivers/cxl/Kconfig
>@@ -144,17 +144,4 @@ config CXL_REGION_INVALIDATION_TEST
>	  If unsure, or if this kernel is meant for production environments,
>	  say N.
>
>-config CXL_PMU
>-	tristate "CXL Performance Monitoring Unit"
>-	default CXL_BUS
>-	depends on PERF_EVENTS
>-	help
>-	  Support performance monitoring as defined in CXL rev 3.0
>-	  section 13.2: Performance Monitoring. CXL components may have
>-	  one or more CXL Performance Monitoring Units (CPMUs).
>-
>-	  Say 'y/m' to enable a driver that will attach to performance
>-	  monitoring units and provide standard perf based interfaces.
>-
>-	  If unsure say 'm'.
> endif
>--
>2.40.1
>