Received-SPF: pass (google.com: domain of linux-kernel+bounces-54213-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <CAJNi4rMpt88Gz+149wR9crzApmfUEfpS05sbOgAvOhzh2+Brbg@mail.gmail.com>
 <20240205053819.3cf848f0@rorschach.local.home>
In-Reply-To: <20240205053819.3cf848f0@rorschach.local.home>
From: richard clark <richard.xnu.clark@gmail.com>
Date: Tue, 6 Feb 2024 10:47:55 +0800
Message-ID: <CAJNi4rN+hRg0UxhNus727t7f_D5XPMOyCdpJM2WoZH4yfw8kmQ@mail.gmail.com>
Subject: Re: Question about the ipi_raise filter usage and output
To: Steven Rostedt <rostedt@goodmis.org>
Cc: nico@fluxnic.net, Mark Rutland <mark.rutland@arm.com>, mhiramat@kernel.org, 
	linux-arm-kernel@lists.infradead.org, linux-trace-kernel@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Steve,

On Mon, Feb 5, 2024 at 6:38=E2=80=AFPM Steven Rostedt <rostedt@goodmis.org>=
 wrote:
>
> On Mon, 5 Feb 2024 17:57:29 +0800
> richard clark <richard.xnu.clark@gmail.com> wrote:
>
> > I try to write below:
> > echo 'target_cpus =3D=3D 11 && reason =3D=3D "Function call interrupts"=
' >
> > events/ipi/ipi_raise/filter
>
> You mean when it is sent only to CPU 11? Not when the event is
> happening on CPU 11. Like the above example, the event was triggered on
> CPU 10, but the mask was for all the other CPUs.
>
> If you are looking for just CPU 11, you can do:
>
>   echo 'target_cpus =3D=3D 0x800 && reason =3D=3D "Function call interrup=
ts"'
>

Seems both 'target_cpus =3D=3D 0x800 && reason =3D=3D "Function call
interrupts"' and 'target_cpus & 0x800 && reason =3D=3D "Function call
interrupts"' don't work:

# cat events/ipi/ipi_raise/enable
1
# cat events/ipi/ipi_raise/filter
target_cpus =3D=3D 0x800 && reason =3D=3D "Function call interrupts"

The kernel module code snippet:

void ipi_func_run_cpu(void *info)
{
        pr_info("remote function runs on cpu[%d].\n", smp_processor_id());
}
static int __init ipi_send_init(void)
{
        int target =3D (smp_processor_id() + 1) % nr_cpu_ids;
        int ret =3D smp_call_function_single(target, ipi_func_run_cpu,
NULL, true);
        pr_info("ipi cpu[%d --> %d] ret =3D %d\n", smp_processor_id(),
target, ret);
        return 0;
}
..
module_init(ipi_send_init);
module_exit(ipi_send_exit);

$ sudo taskset -c 10 insmod ipi_send.ko
$ dmesg
..
[84931.864273] remote function runs on cpu[11].
[84931.864282] ipi cpu[10 --> 11] ret =3D 0

The 'cat trace' will output the below message with 'reason =3D=3D
"Function call interrupts"' filter:
..
            sudo-5726    [007] dn.h1.. 84302.833545: ipi_raise:
target_mask=3D00000000,00000001 (Function call interrupts)
            sudo-5726    [007] dn.h2.. 84302.837544: ipi_raise:
target_mask=3D00000000,00000001 (Function call interrupts)
          insmod-5727    [011] dn.h1.. 84302.841545: ipi_raise:
target_mask=3D00000000,00000001 (Function call interrupts)
          insmod-5727    [010] ....1.. 84302.843966: ipi_raise:
target_mask=3D00000000,00000bff (Function call interrupts)
          insmod-5727    [010] ....1.. 84302.843975: ipi_raise:
target_mask=3D00000000,00000bff (Function call interrupts)
          insmod-5727    [010] ....1.. 84302.844184: ipi_raise:
target_mask=3D00000000,00000800 (Function call interrupts)
..

I find that 'target_cpus =3D=3D 0xfff && reason =3D=3D "Function call
interrupts"' doesn't have output in the buffer, but 'target_cpus &
0xfff && reason =3D=3D "Function call interrupts"' does. I also tried to
use 'target_cpus & 0xf00 && reason =3D=3D "Function call interrupts"' in
my case, the trace buffer has nothing after the kmod inserted.

Any comments?

>
>
> -- Steve