Received-SPF: pass (google.com: domain of linux-kernel+bounces-54293-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <17fd1cd7-6b52-4c5a-af6d-2a2c0973cc58@intel.com>
Date: Mon, 5 Feb 2024 20:17:48 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 4/5] selftests/resctrl: Add resource_info_file_exists()
Content-Language: en-US
To: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
	<fenghua.yu@intel.com>, <shuah@kernel.org>
CC: <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<ilpo.jarvinen@linux.intel.com>
References: <cover.1707130307.git.maciej.wieczor-retman@intel.com>
 <9c38bb317d4246182f87e376926b61adbb7e20fd.1707130307.git.maciej.wieczor-retman@intel.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <9c38bb317d4246182f87e376926b61adbb7e20fd.1707130307.git.maciej.wieczor-retman@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?czJXWVpFcldFUmwrQ3FlODI1TFF1TGhqMElSKzRBZXdIbjJoQjhCcW50U2pk?=
 =?utf-8?B?SlNCZkc2elZ6blJPVUlyNHVnUm1vN2k3dmtIbjgzeGtNUlRXZVk4ZSs4enNX?=
 =?utf-8?B?UmRWV2l2b0pudXdUbFB4bUtYYVVkekVIcE5JSk1lWVA2eWk4ZDNhUmc3WVNC?=
 =?utf-8?B?Y0RzVFBuOCs4L0txd21uUGZnbkpRWGVNTUx4NFRZVXczZzhJaXVVTTVBSWMr?=
 =?utf-8?B?RVZwdGlXaGhSSGlCYUowTzZ3VmdnK3c3UU5maHRoa0ZpRUM1RGRiZ0FpWitL?=
 =?utf-8?B?dUZ2Vi9PZkFvSmZUTzNhWnZjbTlQZ09qTUczaWo0SXhZVCtrL3VINHNIU3J3?=
 =?utf-8?B?K0JVcEhPZ1hWRFpCZHhTL0lMVmVEOWpKa2VjVGl3aDcycy9Gckphc2paM1Vx?=
 =?utf-8?B?ZHVuNkl3anFROHl6YVIzeHovZzMxOFRwQkZQYzRtUUlkc0hDTEtNWmRoOWZ6?=
 =?utf-8?B?WnZ1dTRMTTdmeEhQcEhkd0lwcGJ2cEdmRFdYYVVmcGpESHZGaElmS3dmK3A1?=
 =?utf-8?B?TGdDYm9OUkRQWE5zK0YrVmJLUnQ2WEUxQXNrTFRPWS9CY3l6OUdHRDEzdjg4?=
 =?utf-8?B?MVVhMUVzeUhteVdtYVI4YUpxYjcwV3A5akhSUjdkZTVBL1pRSXIyWEp1MkFK?=
 =?utf-8?B?cU4xdXdYR2Zpd2k4NGE1Yk1kMGZ5c0ZEc2tyY3ljTFVHWWVjVE1pYnRNWUdv?=
 =?utf-8?B?bmViMXJJZVF4ZFZnbXZmWTQzbllrYjkyY3NJbzZzK29pMGlhTk1aUDZhTVFh?=
 =?utf-8?B?VU81SkxGa2w4YTk4OW5QeUZNWXpaRVphQkJ4SGI0bkJMRTMxS2RkRmVuL0xm?=
 =?utf-8?B?OGFsQU1hY29XNW5tcGUwQ1NRUHFySnA1SUp3b2tLMzJMUUo2S1RPZlJIVTJs?=
 =?utf-8?B?bG5lWUdiM0xHQkJUTU5GQ1NVMDFKZU9XLzdwN28rbzVKREVEOHpUYVN6VDRa?=
 =?utf-8?B?MUFkN1U1eU11SmdIQkpldmZUYTVBMnBvUHdoTjJwbngrVTB2TWlReThlT3FU?=
 =?utf-8?B?RmJVZ0l5Wm9FREp3WUY1YVZleEpQYXZFeUV6WmtDR1JQNTFjMENnVzNXT0Zq?=
 =?utf-8?B?Y0lFZjNMS25YaGwyN2gvcGp5Z3lWZnZFU1JMejNKYTI3UEJZaHFHb0lBa3Rq?=
 =?utf-8?B?WUhMaVpucmlCWm9VejZhUmo4T2hjc2p1SVhKazNHeVl2STluaGpPcTc0Yis1?=
 =?utf-8?B?QXp1MjVRejNqaUhMMXhSaDBFN0QxU2pRZ3FpUXErVHlORmJDT2p3Y2RZclBQ?=
 =?utf-8?B?TXRJSE14R1NweVlvNXp0VzI1L1c3UHgyWGdsTTJESlpBSTVRbmIxRkloSW0y?=
 =?utf-8?B?RVFuelhLWnc5MDV4V3ZDaDhhajlma21OODhoY1ozVnl5TDNUVkNIQ0szMm4r?=
 =?utf-8?B?S29nZUNIdmdiV3RrRGdKTEc4WmQxcGVKUFhTN3gzdm1lOTdaTnI3bWk2UmF2?=
 =?utf-8?B?blFtS0pPNG15MkNFSTJsMGxlRzBhLzQraDdBMTR5N3ovWG11S25JQzFBYTlM?=
 =?utf-8?B?dnNMT0NDcTcxT0pKV2Uwd2JlTnRTbGNqbC9oMDdBRHVLcEpqK3BWZ2hvQXZn?=
 =?utf-8?B?T0ovYS96bkJhQkQrUTVMN1hmRVVhYkE1eXFzM1J0OWU5RkNFZk5sVmdJQk9j?=
 =?utf-8?B?citCVGVDSlg4T2N6OG84UEFzSXVnWUtwOStPUTZrdk9BT20yb0lEVlF3WVJj?=
 =?utf-8?B?U21LOUtZNFpVL25CRzN2N1doSzhKT3I3dEg0bnZCc2h4Vk50blkyOG9PY1Bj?=
 =?utf-8?B?c25ycHl1L2JySUpyc2lQcklocHFscFpuZ0RIaVZlNVlEaFNJdmluekNtMnYv?=
 =?utf-8?B?RTRwaFRweit4WGxBbE1yZC90RlQ1TGdEaHpqbktXNnVLTStpbnkycG5QVTNN?=
 =?utf-8?B?WEJGWGZTRkhiK2NIT0hsZmFCRlNLaFBrNmltZkt2N0FxdGdoRUxDN0xHSXNM?=
 =?utf-8?B?OUNteWphM2lHejJYeW16ekhUaFFRNExFWVlxN1drUDhyTEpKejBXRnE4LzV0?=
 =?utf-8?B?dnlMbVdmZWJadW1uZm13WGdjWk40MFUvcnQrRE9ZRkdqRVBORGJ5eEsxeklS?=
 =?utf-8?B?YlRsei90NXJwekJtNitwZy9kWDZiMTFlcGpvSFZjalV5MTNURllia1R2OTMv?=
 =?utf-8?B?M0hmeUZ6RGN6U05YS2hrZjJycEhsZVlPQnRjUmx2WElPcS8xMXBjK2UyWktZ?=
 =?utf-8?B?Qnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9956c20f-ae5c-4616-8583-08dc26ca9422
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2024 04:17:49.1285
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Tmx0ucI2Wvf6GqHwThii54BEPDsZuP6MCwpNgZ3dioYf6WfpeY3ShdScEjxJjPabqEAouRi0IyAhpqO1Lu20T8EkZvGUy81tOMBpQnANcLM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7956
X-OriginatorOrg: intel.com

Hi Maciej,

On 2/5/2024 4:08 AM, Maciej Wieczor-Retman wrote:
> Feature checking done by resctrl_mon_feature_exists() covers features
> represented by the feature name presence inside the 'mon_features' file
> in /sys/fs/resctrl/info/L3_MON directory. There exists a different way
> to represent feature support and that is by the presence of 0 or 1 in a
> single file in the info/resource directory. In this case the filename
> represents what feature support is being indicated.
> 
> Add a generic function to check file presence in the
> /sys/fs/resctrl/info/<RESOURCE> directory.
> 
> Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
> Changelog v4:
> - Remove unnecessary new lines.
> - Change 'feature' -> 'file' to keep things generic. (Reinette)
> - Add Ilpo's reviewed-by tag.
> 
> Changelog v3:
> - Split off the new function into this patch. (Reinette)
> 
> Changelog v2:
> - Add this patch.
> 
>  tools/testing/selftests/resctrl/resctrl.h   |  1 +
>  tools/testing/selftests/resctrl/resctrlfs.c | 25 +++++++++++++++++++++
>  2 files changed, 26 insertions(+)
> 
> diff --git a/tools/testing/selftests/resctrl/resctrl.h b/tools/testing/selftests/resctrl/resctrl.h
> index 4603b215b97e..2b9a3d0570c7 100644
> --- a/tools/testing/selftests/resctrl/resctrl.h
> +++ b/tools/testing/selftests/resctrl/resctrl.h
> @@ -138,6 +138,7 @@ int umount_resctrlfs(void);
>  int validate_bw_report_request(char *bw_report);
>  bool resctrl_resource_exists(const char *resource);
>  bool resctrl_mon_feature_exists(const char *feature);
> +bool resource_info_file_exists(const char *resource, const char *feature);

One stray "feature" usage.

>  bool test_resource_feature_check(const struct resctrl_test *test);
>  char *fgrep(FILE *inf, const char *str);
>  int taskset_benchmark(pid_t bm_pid, int cpu_no, cpu_set_t *old_affinity);
> diff --git a/tools/testing/selftests/resctrl/resctrlfs.c b/tools/testing/selftests/resctrl/resctrlfs.c
> index 0cfec8bb23fd..6a3082ca58b5 100644
> --- a/tools/testing/selftests/resctrl/resctrlfs.c
> +++ b/tools/testing/selftests/resctrl/resctrlfs.c
> @@ -760,6 +760,31 @@ bool resctrl_mon_feature_exists(const char *feature)
>  	return !!res;
>  }
>  
> +/*
> + * resource_info_file_exists - Check if a file is present inside
> + * /sys/fs/resctrl/info/RESOURCE.
> + * @resource:	Required resource (Eg: MB, L3, L2, etc.)
> + * @file:	Required file.
> + *
> + * Return: True if the file exists, else false.

How about "True if /sys/fs/resctrl/info/@resource/@file exists, else false"?

Reinette