Received-SPF: pass (google.com: domain of linux-kernel+bounces-54422-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 6 Feb 2024 08:34:09 +0100
From: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
To: Reinette Chatre <reinette.chatre@intel.com>
CC: <fenghua.yu@intel.com>, <shuah@kernel.org>,
	<linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<ilpo.jarvinen@linux.intel.com>
Subject: Re: [PATCH v4 4/5] selftests/resctrl: Add resource_info_file_exists()
Message-ID: <5b5uw43oj6i3sw56xocsqkvvqv6vvdjitekq3koou5oaoq6lf3@irolbzyiljbs>
References: <cover.1707130307.git.maciej.wieczor-retman@intel.com>
 <9c38bb317d4246182f87e376926b61adbb7e20fd.1707130307.git.maciej.wieczor-retman@intel.com>
 <17fd1cd7-6b52-4c5a-af6d-2a2c0973cc58@intel.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <17fd1cd7-6b52-4c5a-af6d-2a2c0973cc58@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?ZsgTaa7DOun53Hqxa5cmxXJh1CmFg2BswzyJCFDC/k485GcmmDUax8NOZ+?=
 =?iso-8859-1?Q?ZYGTJpaegZRC1nGRFPUKNHLC7XMkXB/Yq/G3b3TTDxittPjK7RBVGaGj4o?=
 =?iso-8859-1?Q?cntpTr3VFy9dwpaydhOUiUKe/SL4PRuFiIQJlD+Ly8UcS0sMHENQcnGoAg?=
 =?iso-8859-1?Q?aSB6yiomU2175yYJ3FsU2lwOxlQ50WlrYLSdPjQnwaw/SyLAdU3Bu8ksVF?=
 =?iso-8859-1?Q?eKbGNgxFtQI8EF6qr5uAmaZpOdhXdzY7Sxi790dx2kqRmv249RJaMCMCUl?=
 =?iso-8859-1?Q?DbJp9lbfZw6uR1A78V2lEGDLSfjnTLnoy6XtfXFH0WRm03txSOvNmhGpfa?=
 =?iso-8859-1?Q?OEKzuG38vLtAa/xkJ/h6PDy8mCXK7osREIW+HBmeO+1OWq9Ke15J393sVS?=
 =?iso-8859-1?Q?318T2URmMrPBe+7Q/FNimXDHKAuwvNx4wPvq8uGnxH+DOvQhQgh2zcw4MI?=
 =?iso-8859-1?Q?/rEB14AyAo/2tGrLPrwcoXVS1wF6LFKSJM0gKPbvSdgNAV7Ui1pvwRyhfm?=
 =?iso-8859-1?Q?SnBCqlto9JvG1l0vOn3EbTmNeT+UQ7vxBSplbotM1GncUGcT2OTK4hcMWH?=
 =?iso-8859-1?Q?3l1natrAxC3Mm61IZavbdcPhQT4PrIZVjXthKu47arJ3sR3WhL37b09wi2?=
 =?iso-8859-1?Q?BkEBfOaVYyd3uMzgdHcg/uU4yHGFWdV9WHPse/T+Xadx44o0kfY50c0GWs?=
 =?iso-8859-1?Q?Mjy860qON4jnqrkyH5KlFJzDYGfyyL1SYu6BKqkGNcbcuYhsu/odgJG6X0?=
 =?iso-8859-1?Q?vBkQLw88QJPq14vC3zxe5RjPfi2Xb1ZjA02NbYHgOr13JPeutSclyaA0yf?=
 =?iso-8859-1?Q?+TkGAzirz/PG89qut+n+EHdslhuBWJxdYGaSvU9sPU/3DNZ9Je+u2qJHaU?=
 =?iso-8859-1?Q?bkLLsGIXi8AkagZ6QHfrp5zpCYJ71xwJt2NIy9cd9Jvgdc+SpzJVkA8rIo?=
 =?iso-8859-1?Q?9w+dmzQoh5K6/gPWJ3ybmopERm+Gqtk7JD3Wd6SnMLlyeN68c+5aRHVZ2y?=
 =?iso-8859-1?Q?KolXG2RclrCSaZGem73UC1shx7GFe+tczaE6YH9Bu6WDRkeRRu12k7BUdl?=
 =?iso-8859-1?Q?TmgrpbDHmXRAyrMZy1a6qmwu2UJziAeBmtp0871cz8uKPStHnA4Dxu9qZh?=
 =?iso-8859-1?Q?t7tB+tIUiyT+t3f0KX/rp27L+3zII+TPe7rZWsq/3DdDSm8a69pkJ2M0kL?=
 =?iso-8859-1?Q?yWxDRghcAnvbSiyPUprTAhjFWijDs6qu8SrouwYqGOq+nd/xOme/4WQFv5?=
 =?iso-8859-1?Q?Qoo9VIpjFKFNmGPnONp+YjhkNZM5V39K62ulAI1KOfJ1166TpFlImHaFGq?=
 =?iso-8859-1?Q?mXJiku9oAn1ILMvtUqL2uK6/jA98gh26PifJsoXLWdE5lglQmZiiFYlu7v?=
 =?iso-8859-1?Q?hocoJf/qvqQc1vVNSufYP+mEP+yxKqM2OXxtROjWiCSRsjh3sYs92EbHl0?=
 =?iso-8859-1?Q?QiFBeOXrQzRD8Zdx1gVx0V1ZEMNRuoxM/cStRAdt8JtuF8/K5m+4I1qsLb?=
 =?iso-8859-1?Q?2U1zX7SfiPjOoX53WlSBdB3WYclUyZ/ZMXlXegiK6xjtV4shmXlotvp+Je?=
 =?iso-8859-1?Q?TMwv3xPSG/393nAKs4/md50iUEHha6tuLN7Nf1zMGYh8urOok8FYsZ7PGN?=
 =?iso-8859-1?Q?R2a7qLGQt3SvwPnfQDPMmGOhaitv4oge8I+Td9xlEMuk6yEAqAIb/usr8H?=
 =?iso-8859-1?Q?+fb/SiyxRhvX06OqKWs=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bcc725af-5ed6-476a-85e4-08dc26e60657
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6231.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2024 07:34:17.5902
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ORH5s2FQKGMVH0KpasdCukX+8mQfF8nA0S1kLtPiWIz6VcxgVK1w7P+wGpVbi4VNMmfxofDbCo0iSpc+A43FNg7QIKoiglVqMN5lSeEkOiI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6507
X-OriginatorOrg: intel.com

Hi Reinette!

On 2024-02-05 at 20:17:48 -0800, Reinette Chatre wrote:
>Hi Maciej,
>
>On 2/5/2024 4:08 AM, Maciej Wieczor-Retman wrote:
>> Feature checking done by resctrl_mon_feature_exists() covers features
>> represented by the feature name presence inside the 'mon_features' file
>> in /sys/fs/resctrl/info/L3_MON directory. There exists a different way
>> to represent feature support and that is by the presence of 0 or 1 in a
>> single file in the info/resource directory. In this case the filename
>> represents what feature support is being indicated.
>> 
>> Add a generic function to check file presence in the
>> /sys/fs/resctrl/info/<RESOURCE> directory.
>> 
>> Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
>> Reviewed-by: Ilpo J?rvinen <ilpo.jarvinen@linux.intel.com>
>> ---
>> Changelog v4:
>> - Remove unnecessary new lines.
>> - Change 'feature' -> 'file' to keep things generic. (Reinette)
>> - Add Ilpo's reviewed-by tag.
>> 
>> Changelog v3:
>> - Split off the new function into this patch. (Reinette)
>> 
>> Changelog v2:
>> - Add this patch.
>> 
>>  tools/testing/selftests/resctrl/resctrl.h   |  1 +
>>  tools/testing/selftests/resctrl/resctrlfs.c | 25 +++++++++++++++++++++
>>  2 files changed, 26 insertions(+)
>> 
>> diff --git a/tools/testing/selftests/resctrl/resctrl.h b/tools/testing/selftests/resctrl/resctrl.h
>> index 4603b215b97e..2b9a3d0570c7 100644
>> --- a/tools/testing/selftests/resctrl/resctrl.h
>> +++ b/tools/testing/selftests/resctrl/resctrl.h
>> @@ -138,6 +138,7 @@ int umount_resctrlfs(void);
>>  int validate_bw_report_request(char *bw_report);
>>  bool resctrl_resource_exists(const char *resource);
>>  bool resctrl_mon_feature_exists(const char *feature);
>> +bool resource_info_file_exists(const char *resource, const char *feature);
>
>One stray "feature" usage.

Thank you for catching that!

>
>>  bool test_resource_feature_check(const struct resctrl_test *test);
>>  char *fgrep(FILE *inf, const char *str);
>>  int taskset_benchmark(pid_t bm_pid, int cpu_no, cpu_set_t *old_affinity);
>> diff --git a/tools/testing/selftests/resctrl/resctrlfs.c b/tools/testing/selftests/resctrl/resctrlfs.c
>> index 0cfec8bb23fd..6a3082ca58b5 100644
>> --- a/tools/testing/selftests/resctrl/resctrlfs.c
>> +++ b/tools/testing/selftests/resctrl/resctrlfs.c
>> @@ -760,6 +760,31 @@ bool resctrl_mon_feature_exists(const char *feature)
>>  	return !!res;
>>  }
>>  
>> +/*
>> + * resource_info_file_exists - Check if a file is present inside
>> + * /sys/fs/resctrl/info/RESOURCE.
>> + * @resource:	Required resource (Eg: MB, L3, L2, etc.)
>> + * @file:	Required file.
>> + *
>> + * Return: True if the file exists, else false.
>
>How about "True if /sys/fs/resctrl/info/@resource/@file exists, else false"?

Sure. I was wondering what the best format of paths in the function comments
could be and that does look very sensible. I'll redo the other paths in the
comments of this series for consistency.

>
>Reinette

-- 
Kind regards
Maciej Wiecz?r-Retman