Received-SPF: pass (google.com: domain of linux-kernel+bounces-54495-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Lu Baolu <baolu.lu@linux.intel.com>, Joerg Roedel <joro@8bytes.org>, "Will
 Deacon" <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>, "Jason
 Gunthorpe" <jgg@ziepe.ca>, Jean-Philippe Brucker <jean-philippe@linaro.org>,
	Nicolin Chen <nicolinc@nvidia.com>
CC: "Liu, Yi L" <yi.l.liu@intel.com>, Jacob Pan
	<jacob.jun.pan@linux.intel.com>, Longfang Liu <liulongfang@huawei.com>,
	"Zhao, Yan Y" <yan.y.zhao@intel.com>, Joel Granados <j.granados@samsung.com>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>, "kvm@vger.kernel.org"
	<kvm@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, Jason Gunthorpe <jgg@nvidia.com>
Subject: RE: [PATCH v11 14/16] iommu: Track iopf group instead of last fault
Thread-Topic: [PATCH v11 14/16] iommu: Track iopf group instead of last fault
Thread-Index: AQHaU1R69Srcwc/GAk+an+ZmIUzfr7D9Bxtw
Date: Tue, 6 Feb 2024 08:31:51 +0000
Message-ID: <BN9PR11MB5276D08766EF06B55F471EDC8C462@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20240130080835.58921-1-baolu.lu@linux.intel.com>
 <20240130080835.58921-15-baolu.lu@linux.intel.com>
In-Reply-To: <20240130080835.58921-15-baolu.lu@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LEdT4SfViL3MKcqryNYqBR6ijN9HupH0jtPRenBxKorlZAppKctNHXkFjQZY?=
 =?us-ascii?Q?hKQL35Cexny4xoXMGrGSAuxq3D0x/fwMYBekTQuzf9oGV+FgYtID2v6mGNq1?=
 =?us-ascii?Q?ldExNKakdnhxoQIOLREWncIsR/k6GfU+CvGnxBxwZ+NILbmAIgeab5h1Bz3A?=
 =?us-ascii?Q?aDfSJqIrff2Vi8TyTPFkHmzmup5p8Wm9cMYfNMIH5PWfQ2DwcCFWb6rhwZ0q?=
 =?us-ascii?Q?zlgK9YteASn9Zhdt8cZRUG0i78PDzqhzwlMzATsTZ7lt08/LLFzllpoDvqWW?=
 =?us-ascii?Q?qoZUp2eEfrx5YWCPrWiP8870a7OlSjvZJi7xOxibFtxmFpnLdcdfqnp8FahH?=
 =?us-ascii?Q?L2h5XuNHo30SIqzuRulPqACaVkrGsUnWhhAJqTrIAtblBevNZiISDzPLuus6?=
 =?us-ascii?Q?hUxta8wRY1PSNI31Rw6/1/L+rWpjmz5bzs8irs2QK+H1QotzClv1bWYhJMoC?=
 =?us-ascii?Q?gxEa0goHq5Sa/k76rYAKU2/QraT5mIok4TXR+EJnKZUrLrLaEBh4R9RNMJAb?=
 =?us-ascii?Q?eHIf3TbFJIRzrGIpocIDqdGRO5YszokK/474E0sD6vkt0wSPirRN/5V19BhS?=
 =?us-ascii?Q?dcfU8v0zzpj57xhZZSh8bwq+Kweb+cFYx7YehJ5UAwLsfh45sPclTiREfpIT?=
 =?us-ascii?Q?lDhnl1gvo63A9ICEPtvEwQOZjx5H+gWfF8bFolSLubUqbnA33wgotMJilEwD?=
 =?us-ascii?Q?eC5OpA40xbUUEQBx9FiPBBAiF6wiy/4QIWR+98BwXPvrEOU5nJloEjNEBbc3?=
 =?us-ascii?Q?MOqT/b1pmHeEEVnRgH8uVbVvTIBxLXNynnDiHVZYeuUSAk6uip3HA0z4ooTJ?=
 =?us-ascii?Q?+Up8RvDq/7ejJmaNiljWIwgFmdwzeP4Z0FzNZd/EVDoWKrkud5tN0LmaV06+?=
 =?us-ascii?Q?gi0MpRSVK3U0Ic85Xxy+dIFs9D7ZVjY+2e6xTbGq40eJuVS1VpIl1d0k40+Z?=
 =?us-ascii?Q?0Atp4LoPY7ObK1WkNqUvXR192Gg9pVy62yLKRyBCfeJ6J0k6+HJ3sIW6zXOU?=
 =?us-ascii?Q?z6vgzjwEOvFc6gsTw9ehNaHTKsnFXTIU14EuyoR7xZWDtFzp//CRHf5Z829a?=
 =?us-ascii?Q?+yZGu9jgEf1Lc5heb7jp/Ol4hRBq/9LD836kviHmN9vLudDZ28qSxNsPfH2I?=
 =?us-ascii?Q?0U+8sQcMouYQDigSbYjGqmrVIorKJsocYdeyRjBHZsHKmpRwViX8aIwRyEch?=
 =?us-ascii?Q?GSF/FLUzUmmo9VdXHr8856GqkoSZ9Ur7vNwNEt1PGtcrGIhzJyh4Y3YD2REc?=
 =?us-ascii?Q?7dUuzJnO/YJPKwtu/ksabDajBOXwbyfiNxfQCMTc3TlNmJ3Vr7XSZJ4hVlwb?=
 =?us-ascii?Q?Z780X/wHo2zWXgxq7zNHjpUdqh9aWGxSs6RGgVlKkCUrhpdtZMZcNLqtcc9u?=
 =?us-ascii?Q?8mw8EV6S4TeRLKBxANh4slTSzWRjQeEz4c2gn/MZrOGUKf8zuEw4NeHNsLJg?=
 =?us-ascii?Q?jX/K+9Bq+sk6k2gWI7ZnOK00YKJlbFrtvFGN9vXWrfDsn8u817yZ84z58uF2?=
 =?us-ascii?Q?LsRpDHD2AyPKqxV43ZPp3TJhJ7PC8dko4KKTRwKq4Qe4ZWF1gw6Zzfjxsf2i?=
 =?us-ascii?Q?/Kns+ZTL4ZX4D0tz629SrurLZCa6spSm6PpGcYjM?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c42c7936-d9c4-4861-06aa-08dc26ee1141
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Feb 2024 08:31:51.2932
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: btNSiemUFGoY/XOWXuhH2hsfJw2+fHbOsK/0T4kW6j43Hn52y+Bjxkwa1biS5wo7Zzm/BwcrbRxnJspICV76aQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6296
X-OriginatorOrg: intel.com

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Tuesday, January 30, 2024 4:09 PM
>=20
> Previously, before a group of page faults was passed to the domain's iopf
> handler, the last page fault of the group was kept in the list of
> iommu_fault_param::faults. In the page fault response path, the group's
> last page fault was used to look up the list, and the page faults were
> responded to device only if there was a matched fault.
>=20
> The previous approach seems unnecessarily complex and not performance
> friendly. Put the page fault group itself to the outstanding fault list.
> It can be removed in the page fault response path or in the
> iopf_queue_remove_device() path. The pending list is protected by
> iommu_fault_param::lock. To allow checking for the group's presence in
> the list using list_empty(), the iopf group should be removed from the
> list with list_del_init().
>=20
> IOMMU_PAGE_RESP_PASID_VALID is set in the code but not used anywhere.
> Remove it to make the code clean. IOMMU_PAGE_RESP_PASID_VALID is set
> in the response message indicating that the response message includes
> a valid PASID value. Actually, we should keep this hardware detail in
> the individual driver. When the page fault handling framework in IOMMU
> and IOMMUFD subsystems includes a valid PASID in the fault message, the
> response message should always contain the same PASID value. Individual
> drivers should be responsible for deciding whether to include the PASID
> in the messages they provide for the hardware.
>=20
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> Tested-by: Yan Zhao <yan.y.zhao@intel.com>

Reviewed-by: Kevin Tian <kevin.tian@intel.com>