Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp2897834rdb; Tue, 6 Feb 2024 00:35:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IEkV6loxamd4vV9wUqLPCuos/G6TiWUcF6kxywQiUAWQXkNtqmDfN2DHAZlDl5B/Hd0Habp X-Received: by 2002:a17:906:fb06:b0:a37:e1e0:f2fc with SMTP id lz6-20020a170906fb0600b00a37e1e0f2fcmr946613ejb.12.1707208500067; Tue, 06 Feb 2024 00:35:00 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707208500; cv=pass; d=google.com; s=arc-20160816; b=n5ppEtIE52MuGTetnCWjmCd3bRzUxJ2jqQsFE1UxFuXh/ggvGolNkUy1yR8wUzv3I7 FtFfJrtmPDVWT9vYgtbsVtf3f5/+2oezb6KYNZog63eYBoL2ZOSKkAmc7MDDLCfkztdl 4YR0ztteAtNIpr6pXYXB5HYFEnzMiOdHsbCt54nfpE+Md3xb2DvBOC1bT1XPIBRyXaBV 5cvjqcKYEXQSBO4Kty42BG8HOpdftgFVI2CPOQhiUYv6avF3gzDlXsZd/SFNucC94IwN QP/okh+vYU9ykX4rhmTkyWWDugYgd1E6SwHfYDhC+AskJ4wHnTJqCBZDFfeD5We+zRt+ oo8w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Z2mwNLm1V8FlR00nmF3zbnb4bZ7trrAYANe+rIXrX8w=; fh=Y0xic/DLF9ZxkvpDw+oh9HwUJBMtEhhRNJkRJZzDjPc=; b=morHSYufSrb4FTE2EE/xpgVdmGALln3unsVGvLx0NeQB7dMDUEtbbAi7EHV/Y7v9LO LY0c1XapF10WD7k3/C+NAwyY6Z9r6SBXYU/GpDpumY+7v4i2XNG5EU7LXOPKBDcZuBvh lSOqm7OzJZG3S43wtfTSZEvqK4ZrZWENcJgcy27eYxEXFC/luIbJUJ/Fo13gM8D2KSdk z8ZrJgTIdYhOWCeX/hXjYmY0yPLgU7B/10b2aa8BSyI5h6JccjUTb0m8vTr7jTMzvkFy XIBd2KVcoIdR5Y7SKB5dXEBnYDh66eOKDYe9GUu7WVHykygioAMaqxL15CyRRu+ZaYAO t8hQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@atomide.com header.s=25mailst header.b=lYpWmurC; arc=pass (i=1 dkim=pass dkdomain=atomide.com); spf=pass (google.com: domain of linux-kernel+bounces-54498-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54498-linux.lists.archive=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=1; AJvYcCX5+0Esk7Tfx90cpD585olvSbHvz+gsCltWe52eOKO5xiFbGsE2JU8OV0qeoYrJfF2r5lA/+xw5IYDUiGZNr7Jw2XombWPdTXfQnaTBwg== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a20-20020a1709066d5400b00a3543f8bf9fsi791446ejt.587.2024.02.06.00.35.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 00:35:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-54498-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@atomide.com header.s=25mailst header.b=lYpWmurC; arc=pass (i=1 dkim=pass dkdomain=atomide.com); spf=pass (google.com: domain of linux-kernel+bounces-54498-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54498-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id BC1E61F25F48 for ; Tue, 6 Feb 2024 08:34:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8B1A112B169; Tue, 6 Feb 2024 08:34:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=atomide.com header.i=@atomide.com header.b="lYpWmurC" Received: from mail5.25mail.st (mail5.25mail.st [74.50.62.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCE892C877; Tue, 6 Feb 2024 08:34:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.50.62.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707208484; cv=none; b=Sdd8IMqGN3V0jaVI2bY9zOjDlvi9tz5MewuA9pFSxayzMUd7qiCQyId1TMPQTNvx/RDYOdykpU4IzantmjzbuqHXywKiOgiFRHH2SA6IwspnBM0mD5TQWSeJ2fZPiXxT/21zmJOJgrvUIVp64U5C/6caI4eO8WkhoCfJyK9GLeQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707208484; c=relaxed/simple; bh=Z2mwNLm1V8FlR00nmF3zbnb4bZ7trrAYANe+rIXrX8w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kOgO3SY78Ycc7WIpMPZclO8z9llZAqPBpt3OPQrtCB3rk6qNCAEgE1uVKliH+Ylw/HV+fIIbufSHSGPwsAIpv0Z9nA5dmxm+l1vYxgaZglHe3xHOl8Jy2AfNQA6EIaOiPR3Asl/c11cgMGl3e1+fhYdszDzxXmyHsoAl4AUhLIY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com; spf=fail smtp.mailfrom=atomide.com; dkim=pass (2048-bit key) header.d=atomide.com header.i=@atomide.com header.b=lYpWmurC; arc=none smtp.client-ip=74.50.62.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=atomide.com Received: from localhost (91-158-86-216.elisa-laajakaista.fi [91.158.86.216]) by mail5.25mail.st (Postfix) with ESMTPSA id 5605560372; Tue, 6 Feb 2024 08:34:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=atomide.com; s=25mailst; t=1707208476; bh=Z2mwNLm1V8FlR00nmF3zbnb4bZ7trrAYANe+rIXrX8w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lYpWmurC7xgUhLnvkqYDZtNWTEWv8TJdZgVrq96lA7NpuSvInAh3RVo7s10VgW+6i JgDMYQf4ya5c97mOpKUYXqbSKnTIneYPILPyQSRYWoKQYbqwD6Vbh0y2YLeOTQe2fR worb6xDW/zTmxajnqJ1fBDi1e9Hp5FZfd08/fzKnT+wf1jZbRlMSocsIpBEzpIXqXD wnTwhWTNlk4DCnEXsWZfTUhpIY0CnqnXSVdslOnx26ZYTXa+xNrpfV2sUH3mUhn4MS abVhX3Y3S40QjUyPt62LgW+737Z8RdOFyv06UHeKGr4Ig1J60623CHFmUlnjD1GomA YV6CfVYQ0eejA== Date: Tue, 6 Feb 2024 10:34:07 +0200 From: Tony Lindgren To: Yicong Yang Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, john.ogness@linutronix.de, andriy.shevchenko@linux.intel.com, tglx@linutronix.de, yangyicong@hisilicon.com, linuxarm@huawei.com, prime.zeng@hisilicon.com, jonathan.cameron@huawei.com, fanghao11@huawei.com Subject: Re: [PATCH v2] serial: port: Don't suspend if the port is still busy Message-ID: <20240206083407.GG5185@atomide.com> References: <20240206073322.5560-1-yangyicong@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240206073322.5560-1-yangyicong@huawei.com> * Yicong Yang [240206 09:37]: > Change since v1: > - Use port lock wrapper per John > - Flush the pending chars and return -EBUSY per Tony. Looks good to me thanks: Reviewed-by: Tony Lindgren