Received-SPF: pass (google.com: domain of linux-kernel+bounces-54502-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Lu Baolu <baolu.lu@linux.intel.com>, Joerg Roedel <joro@8bytes.org>, "Will
 Deacon" <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>, "Jason
 Gunthorpe" <jgg@ziepe.ca>, Jean-Philippe Brucker <jean-philippe@linaro.org>,
	Nicolin Chen <nicolinc@nvidia.com>
CC: "Liu, Yi L" <yi.l.liu@intel.com>, Jacob Pan
	<jacob.jun.pan@linux.intel.com>, Longfang Liu <liulongfang@huawei.com>,
	"Zhao, Yan Y" <yan.y.zhao@intel.com>, Joel Granados <j.granados@samsung.com>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>, "kvm@vger.kernel.org"
	<kvm@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, Jason Gunthorpe <jgg@nvidia.com>
Subject: RE: [PATCH v11 15/16] iommu: Make iopf_group_response() return void
Thread-Topic: [PATCH v11 15/16] iommu: Make iopf_group_response() return void
Thread-Index: AQHaU1R798c3cVWjI0SOx7NslDJDFbD9CJKw
Date: Tue, 6 Feb 2024 08:37:07 +0000
Message-ID: <BN9PR11MB5276F67A3A668B43B136E29C8C462@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20240130080835.58921-1-baolu.lu@linux.intel.com>
 <20240130080835.58921-16-baolu.lu@linux.intel.com>
In-Reply-To: <20240130080835.58921-16-baolu.lu@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gg35/+SW4D6po9GAaICU4xiiRdKwUMB1GerHoO8ecWcxZdCTp9Iz7TLA7mHP?=
 =?us-ascii?Q?IQtjp41OrHuM+BijLpnp6derh27eQP+5qbVMBacHmCbzmY//7Q2AWd7DnbwA?=
 =?us-ascii?Q?XCdVTrvRgjHVxws912otYf50y76FdwjxHy4Tx0ZdKpWQal9b1Mak0FgDk6Dt?=
 =?us-ascii?Q?jlR9yD03IEy10EyReetMc4XVOwVcLq1hG8R3MKxI52YerkJ5YHkHdD4vo4Iu?=
 =?us-ascii?Q?oK8cP4yv4fqHIy14KWOOBVv3c7gH/rd+mDZi7RYIiuiQED7v1M0X157F3ffq?=
 =?us-ascii?Q?UQS+xgKffOvgSGrBSnvsk2XF3ojI8zIZ4Ge8d7Jbes4vf2me7EUcqUJD95lW?=
 =?us-ascii?Q?wlUCCfvWdiACS2Kg3EpnLgz2WeIHCwO0Qe8pA/RmP1xC7jAg5WAoi5qbTDye?=
 =?us-ascii?Q?EzEjhN8DDmC5S8p7S2jTXSpToKZoAWZ+jH2inzhWAqJQPmE89+0iticIlY5s?=
 =?us-ascii?Q?m74RlZ5d1JHtEjlrXMyiKb/ikvqQz5S+cwTmoM8chfgVS8C2tCEcb/LiIZL9?=
 =?us-ascii?Q?H5ZklLWnsjJtgvOEZv6zO2QjAjTw6idhXwyULCTpN4DE6laHYQ0yf4j8lRB1?=
 =?us-ascii?Q?qTvtFmPtw+ASIRZ80Mevy+QCtJ7FxoAPebnv6jm05NQLltZuB6ZsyKecU+tV?=
 =?us-ascii?Q?CMEVf/I8T7OsBQTfowEJaatxTOq5Jww4G2duPwE+tpUukGnnOjRL+Mu8uxaa?=
 =?us-ascii?Q?u/eKcTdO4s16B3geQTKXL5C5ebW6cI6IwQ+CdfJRZ0d44zclR8FWXpkHo9rp?=
 =?us-ascii?Q?oscxHu/oV8KS4ZglGv/u2ddlFFUsUfPgHhBaQ8/lbw5g5pHqnhr+iuQ38K7+?=
 =?us-ascii?Q?pqU6kERJv6cRCKhO6NDtJeCkl5CMCBITSpT32Iv7LWmE03DFXUMDkXiZKpgw?=
 =?us-ascii?Q?yo3dw2L/rpJ+93n39HEaccD+OdDL21nQWwUUalb5HRkzGUFS/Lpq/Dc3/dUL?=
 =?us-ascii?Q?6dw4bN4cbQN2B8jpDBkYfGwxAU2ZZxEQ5oxCuXOHDcl4waK1IOFxiag/BnCZ?=
 =?us-ascii?Q?PZNev5YHS/HRy83twV8wgW+ddwrWeOz3Fa7+yBbIQr6/KwIrZyfW49zAfCeG?=
 =?us-ascii?Q?T/9A0w12G/G6CifHErJ/XiVkYK3w4JDCyfQyVCw8HkucgvxrdqsU9INr68SD?=
 =?us-ascii?Q?TxWP0We9Lp6ztzM4quQy1AdAB7weeeG20sNFd/Yhv5BF3cTHz9OHrCHDuMUo?=
 =?us-ascii?Q?ar6wwIQz4FdRL8BoNbxiDXFAcIUgt3xB6gVUcdNDdLqYMxPnV5Lcb07eXii5?=
 =?us-ascii?Q?xWvH1LuuZtuuJOnY5bxjXt7Yoy5OuhwjR97Ow4RQAoL7jNAUV1rNY6eEG2cT?=
 =?us-ascii?Q?W0MKZHj9vSmtykP9etxAerdXnDYeucYo2g3N43iNyuSaD3v7uvDft5n2jvn/?=
 =?us-ascii?Q?zZhHyCMxsWdYNF9Uir0gHq16AjLeUgfzqq9eRKKZo4bIBX7D9KexDMpzq+OI?=
 =?us-ascii?Q?d8iMpzF8Bo3mJff9f3I7yE/hik9WxYZkmIs9in1BQTvmKdJASse1BMWp6tyM?=
 =?us-ascii?Q?mC3alOzIM+njG9AwoJyaNZ25z8UTb2TkZg/hZr5xttXEeZEEwaldTePOxkgl?=
 =?us-ascii?Q?lqih9OIbSWEDM3CcMx6DnskOeVzKnhsZ30oJ379W?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eb568f00-06e5-430a-5b99-08dc26eecde7
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Feb 2024 08:37:07.7901
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +sZLqWG493h17vWSHcf8VY83/lLmxdtfKLGuuBrh1h8Bpmuipj4rKjjBGRv3QRvvSlLu7Hqmts840Y3Kk59Tig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB8130
X-OriginatorOrg: intel.com

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Tuesday, January 30, 2024 4:09 PM
>=20
> The iopf_group_response() should return void, as nothing can do anything
> with the failure. This implies that ops->page_response() must also return
> void; this is consistent with what the drivers do. The failure paths,
> which are all integrity validations of the fault, should be WARN_ON'd,
> not return codes.
>=20
> If the iommu core fails to enqueue the fault, it should respond the fault
> directly by calling ops->page_response() instead of returning an error
> number and relying on the iommu drivers to do so. Consolidate the error
> fault handling code in the core.
>=20
> Co-developed-by: Jason Gunthorpe <jgg@nvidia.com>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>

Reviewed-by: Kevin Tian <kevin.tian@intel.com>