Received-SPF: pass (google.com: domain of linux-kernel+bounces-54522-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <cc4ff2c9-4c1e-49f1-9297-2662d8ae4ae9@quicinc.com>
Date: Tue, 6 Feb 2024 14:15:39 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v14 0/9] Add multiport support for DWC3 controllers
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
CC: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring
	<robh+dt@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Wesley Cheng
	<quic_wcheng@quicinc.com>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        "Greg
 Kroah-Hartman" <gregkh@linuxfoundation.org>,
        Conor Dooley
	<conor+dt@kernel.org>,
        Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        Felipe Balbi
	<balbi@kernel.org>, <devicetree@vger.kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-usb@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <quic_ppratap@quicinc.com>,
        <quic_jackp@quicinc.com>
References: <20240206051825.1038685-1-quic_kriskura@quicinc.com>
 <CAA8EJpopE91TSCkworWts82tcD_6PLgLmes_FhVhnUovmQWz_w@mail.gmail.com>
 <f86cb527-3f91-4961-bbd5-4dc0e9a42df7@quicinc.com>
 <CAA8EJpqWt6a5mHcSyYKkEGu_nZ7vn5gjok07kSNe7mVzDE7gRA@mail.gmail.com>
Content-Language: en-US
From: Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>
In-Reply-To: <CAA8EJpqWt6a5mHcSyYKkEGu_nZ7vn5gjok07kSNe7mVzDE7gRA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 2/6/2024 2:13 PM, Dmitry Baryshkov wrote:
> On Tue, 6 Feb 2024 at 10:15, Krishna Kurapati PSSNV
> <quic_kriskura@quicinc.com> wrote:
>>
>>
>>
>> On 2/6/2024 1:30 PM, Dmitry Baryshkov wrote:
>>> Hi Krishna,
>>>
>>> On Tue, 6 Feb 2024 at 07:18, Krishna Kurapati <quic_kriskura@quicinc.com> wrote:
>>>>
>>>> Currently the DWC3 driver supports only single port controller which
>>>> requires at most two PHYs ie HS and SS PHYs. There are SoCs that has
>>>> DWC3 controller with multiple ports that can operate in host mode.
>>>> Some of the port supports both SS+HS and other port supports only HS
>>>> mode.
>>>>
>>>> This change primarily refactors the Phy logic in core driver to allow
>>>> multiport support with Generic Phy's.
>>>>
>>>> Changes have been tested on  QCOM SoC SA8295P which has 4 ports (2
>>>> are HS+SS capable and 2 are HS only capable).
>>>
>>> Thank you for your patches! Have you tested how this patchset
>>> interacts with the USB role-switching?
>>>
>>> I'm asking because it might be easier to define DT nodes for each of
>>> USB ports, which can carry the PHY properties (and also other DT
>>> properties if that's required, e.g. the ports / endpoints and
>>> usb-role-switch) rather than pushing all USB PHY links to the root DT
>>> node.
>>>
>>
>> Hi Dmitry,
>>
>>    Role switching doesn't work for Multiport controller as it is host
>> only capable. I don't think it will cause any issues for OTG capable
>> controllers because they only have one HS and SS phy present. So there
>> is no possibility or requirement for having endpoints per port in this case.
> 
> Is it going to remain host-only in future?
> 
> 
Yes. I believe these are designed that way. I don't know of any 
controllers that have multiple ports and device mode works. Device mode 
can work only on one port AFAIK.

Regards,
Krishna,