Received-SPF: pass (google.com: domain of linux-kernel+bounces-54584-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 6 Feb 2024 10:25:03 +0100
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Alexander Aring <aahringo@redhat.com>
Cc: Bo Liu <liubo03@inspur.com>, alex.aring@gmail.com,
 stefan@datenfreihafen.org, davem@davemloft.net, edumazet@google.com,
 kuba@kernel.org, pabeni@redhat.com, linux-wpan@vger.kernel.org,
 netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ieee802154: at86rf230: convert to use maple tree
 register cache
Message-ID: <20240206102503.760ecb64@xps-13>
In-Reply-To: <CAK-6q+jnZOkSAM8_BQH=CaQhfCQwm0P+segZ+0E6oLeX=BhLHQ@mail.gmail.com>
References: <20240202064512.39259-1-liubo03@inspur.com>
	<20240202085547.46c81c96@xps-13>
	<CAK-6q+jnZOkSAM8_BQH=CaQhfCQwm0P+segZ+0E6oLeX=BhLHQ@mail.gmail.com>
Organization: Bootlin
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi,

aahringo@redhat.com wrote on Mon, 5 Feb 2024 14:42:09 -0500:

> Hi,
>=20
> On Fri, Feb 2, 2024 at 2:56=E2=80=AFAM Miquel Raynal <miquel.raynal@bootl=
in.com> wrote:
> >
> > Hi Bo,
> >
> > liubo03@inspur.com wrote on Fri, 2 Feb 2024 01:45:12 -0500:
> > =20
> > > The maple tree register cache is based on a much more modern data str=
ucture
> > > than the rbtree cache and makes optimisation choices which are probab=
ly
> > > more appropriate for modern systems than those made by the rbtree cac=
he. =20
> >
> > What are the real intended benefits? Shall we expect any drawbacks?
> > =20
>=20
> I doubt it has really any benefits, only the slowpath is using regmap
> to set some registers. Maybe if you change phy setting frequently it
> might have an impact, but this isn't even a path considered to run
> fast.

Ok, thanks Alex for the info; in this case I'm fine:

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks,
Miqu=C3=A8l