Received-SPF: pass (google.com: domain of linux-kernel+bounces-54603-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 6 Feb 2024 09:36:59 +0000
From: Mark Brown <broonie@kernel.org>
To: =?utf-8?B?UGF3ZcWC?= Owoc <frut3k7@gmail.com>
Cc: Robert Marko <robimarko@gmail.com>, linux-spi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] spi: spidev: Add Qualcomm spidev device compatible
Message-ID: <ZcH9u7Vo2sFERIHJ@finisterre.sirena.org.uk>
References: <20240205191808.998754-1-frut3k7@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="C+ZbumJ7nzlgQ4kY"
Content-Disposition: inline
In-Reply-To: <20240205191808.998754-1-frut3k7@gmail.com>


--C+ZbumJ7nzlgQ4kY
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Feb 05, 2024 at 08:18:05PM +0100, Pawe=C5=82 Owoc wrote:
> Add compatible string for Qualcomm spidev device (used for QCA4024).

> --- a/drivers/spi/spidev.c
> +++ b/drivers/spi/spidev.c
> @@ -710,6 +710,7 @@ static const struct spi_device_id spidev_spi_ids[] =
=3D {
>  	{ .name =3D "spi-authenta" },
>  	{ .name =3D "em3581" },
>  	{ .name =3D "si3210" },
> +	{ .name =3D "spidev" },
>  	{},

Why?

>  	{ .compatible =3D "lwn,bk4", .data =3D &spidev_of_check },
>  	{ .compatible =3D "menlo,m53cpld", .data =3D &spidev_of_check },
>  	{ .compatible =3D "micron,spi-authenta", .data =3D &spidev_of_check },
> +	{ .compatible =3D "qca,spidev", .data =3D &spidev_of_check },

No, this needs to correspond to the hardware being controlled via spidev
not to an implementation detail.  Any new compatibles also need to be
documented.

I'm also missing patch 2 of this series so don't know what's going on
there.

--C+ZbumJ7nzlgQ4kY
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmXB/boACgkQJNaLcl1U
h9COOAf/Ys678Eo64BOror1BapTdw7+/zdCdwtU3Sg+PwIuUnOJ/39HpJ+BWTFy5
gu0eRpQqBQalAPN3R8KnRTpVV7518MKBRvHzGBoSoRxrml1S/ZWAoE/AqmRYHAz5
9BZjRlIQ+Kae/f3KFR8SprmNAK/KbSVKDEVc3hnadyYWQg3qK9zPOVesP90SRPh7
4Cn7oCjhW1JjFHkA7jdYyMYwztjUvbyCyhoiDyDCmOeiMPpGZejG8qdfB8Emvt12
xzQ7yIp8e0pIzYXPzq0T2oMFfi/TDJsmSuvFPKAJe4Cuc4eUZfiKca9R6sQYX77K
JC/eTWRmm3964LTympefNrcOfd8ntg==
=sxPE
-----END PGP SIGNATURE-----

--C+ZbumJ7nzlgQ4kY--