Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp2923163rdb; Tue, 6 Feb 2024 01:39:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IGNVf0fqZ5y4PiEbZhxmwPgHYHk9EfTi9Ig4Qh+13OnyMIqNyQHAexqrZvsZgNRP7xiBUBo X-Received: by 2002:a17:906:23e9:b0:a38:32cd:983c with SMTP id j9-20020a17090623e900b00a3832cd983cmr623763ejg.33.1707212340127; Tue, 06 Feb 2024 01:39:00 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707212340; cv=pass; d=google.com; s=arc-20160816; b=xm9WNPcnkNxjp81WmFdkJ8gDHKb31a2AV1Z2jMYzXnzGhbixTFpSxPYzEe/80wUTYa 5iasZf/hOWVsYeBOZeUnnVkiZFkAHT2/dGuVQKeaOSaFgOEId/rug/o7jiidSTZVUbnK slxLrgmyxueBbejiIc3Pcib0SkGqIVk2m/pSv8vqcTCqGbhtlGPh+kGupDyRDV7J9xA5 wWup5tXARPLJnZl9H3TI12To7xm+/AxLWZqlLvBvWgt7SZyEPUGJwQnuwwCmyiMa5lfp qgyewLYYzUol8DtN8KB31pVFl306gY7g2+LTpbrfHrnLsP+ZENvTBdcPS/GQFDsLYwxA JDNA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:organization:references :in-reply-to:message-id:subject:cc:to:from:date:dkim-signature; bh=R1JkbkHYZjBJccdGuVGW2VQafUHeELVUbK2T3y/y9DU=; fh=4X6U2yiDrUMVmikhwoVpSA+zq1QKI2GiIC5X9lFqzvM=; b=tPjvz0jX/2VbR0HACCoi10iRrhVEkeIn/2fx65wCtlHVslpQMnF0FbyI4lbyqi7e1A YIe1hTQlRBfIhXqq93RkcgtjsmebutKckIhROQTIzXU2WF9bx+G5Z/y9W/QpjB1Nzg8t K59fQltg0n9OEJ8zRGGUD1A4sDEyLD2fN1L/dKvLr2FGnrEPUltSfHODFyY6NXpf4N56 XT4jkiL6w7rYC+uhrC6WRwWHAAZx84HZj5fk2g2cL1nOGh1h3gUtYbSHsAVamx/+WDFN ogmOxfXR+zBZqFElqaKLk4NAWx1dL8JT06HyQ990ugcNCUjojNQ9ub5SNbZpu/G/KK1s jj8w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=dKXLtGPR; arc=pass (i=1 spf=pass spfdomain=bootlin.com dkim=pass dkdomain=bootlin.com dmarc=pass fromdomain=bootlin.com); spf=pass (google.com: domain of linux-kernel+bounces-54608-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54608-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com X-Forwarded-Encrypted: i=1; AJvYcCXTz4H82sP/hbdsavbnIPget9aVk0zwdsPWpVatUMfo/J2OIWUy6k7JGGLIklVUm5C+cFQw/Gvhc7aPUyt5gQ4MNBh02xHq2piqyNqfdw== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a22-20020a17090680d600b00a373890b79csi892334ejx.208.2024.02.06.01.39.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 01:39:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-54608-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=dKXLtGPR; arc=pass (i=1 spf=pass spfdomain=bootlin.com dkim=pass dkdomain=bootlin.com dmarc=pass fromdomain=bootlin.com); spf=pass (google.com: domain of linux-kernel+bounces-54608-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54608-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id D2F2A1F23621 for ; Tue, 6 Feb 2024 09:38:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A028712D750; Tue, 6 Feb 2024 09:38:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="dKXLtGPR" Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC7FE12D148; Tue, 6 Feb 2024 09:38:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707212327; cv=none; b=GgoN7f/HqddlxvYCgnxbf6LNeqtJr8ge6zXSul483yItAA81zgMXECvZb600LtFFhhr9HHxsigLmHUi0kgdB5FEPYNn5bhq5xhE1X5exuWx1+ijy2sKNGhm7bJNR98jTiND8qfopzNK5t00thHi5t2JlojlnrcAyv8OL/dQwLoA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707212327; c=relaxed/simple; bh=R1JkbkHYZjBJccdGuVGW2VQafUHeELVUbK2T3y/y9DU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NmeyYu621HewxSKlRSi80Ey6KEvpAplVjFC7o+eRQNxeJGY3gnqaNOF3L7sEs6joXb0et4+x93IKSnYj/QN3F1NsGeyA9E+I8I4aDrX7HhRFIbyTT58RPbX6IDhhhX6/F/9y+yS4KIKiDN+lPDw7C48gcIZPGELn3MgJse2sD5g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=dKXLtGPR; arc=none smtp.client-ip=217.70.183.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 26B2E1C0004; Tue, 6 Feb 2024 09:38:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1707212323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R1JkbkHYZjBJccdGuVGW2VQafUHeELVUbK2T3y/y9DU=; b=dKXLtGPRXyrAMOrPTXbdEyI20UREUIhUzE+Mf1Z5vpipNPJdGYMVPkrsUQeoigC1hwWnkb +sM/Si7s/HdqTv9NJGKDnsV0uLZobsBHMzgjmbD4K2wnudQJXaLBCBra8zBnv8j0xNA7kC 8vGEoiOuRG5cnA6VA9PtfySl3RUAvBpgybPSqe+1fsUeivB74y2RiRnOcRwyMSPcRb032N hOtgA17p2NVRic19T0+WnJSj06W4R2W6/zdYQQ1bcLS98kh3PkmcXJdgUjfn03M3Zfql6B Kb1Rtjq5ghJdvaH+4DpXNXzP2XvEKZl5yXAe4j3mW0eXFWOMNUP9ZRiKbIWvbg== Date: Tue, 6 Feb 2024 10:38:42 +0100 From: Maxime Chevallier To: Andrew Lunn Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ariel Elior , Manish Chopra , Jesse Brandeburg , Tony Nguyen , linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org Subject: Re: [PATCH 0/8] drivers: net: Convert EEE handling to use linkmode bitmaps Message-ID: <20240206103842.0a72ed27@device-28.home> In-Reply-To: <20240204-keee-u32-cleanup-v1-0-fb6e08329d9a@lunn.ch> References: <20240204-keee-u32-cleanup-v1-0-fb6e08329d9a@lunn.ch> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.39; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-Sasl: maxime.chevallier@bootlin.com Hello Andrew, On Sun, 04 Feb 2024 17:40:17 -0600 Andrew Lunn wrote: > EEE has until recently been limited to lower speeds due to the use of > the legacy u32 for link speeds. This restriction has been lifted, with > the use of linkmode bitmaps. This patchset convert some MAC drivers > still using the old _u32 to link modes, with the aim of soon being > able to remove the legacy _u32 members in the keee structure. Although I don't have proper hardware to test all these, I've read the patches and I didn't find any obvious issues besides the typo in patch 7. Regards, Maxime