Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp2927274rdb; Tue, 6 Feb 2024 01:50:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IHql+h7E8/a0Pi9kVYuQtplKtgm2//FfEej+bchsaMlChHhcE3j8powuH9Lv/Y+Gt5VVqI/ X-Received: by 2002:a17:903:1112:b0:1d9:65e6:4af7 with SMTP id n18-20020a170903111200b001d965e64af7mr1448090plh.30.1707213019142; Tue, 06 Feb 2024 01:50:19 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707213019; cv=pass; d=google.com; s=arc-20160816; b=RAd1+RgYiHGpmzVcIkCSLnj7D61rT0vSx2ehSYs+rAY1ODfqDjeIk1I9YhGoqUQuH8 E71GPAO7N3O1YUHiMoBs7ThOGFgcxrE4zJBmSh5RRjan8+4tcol3nDT+emRop/E80P9t WWvZuXc6NpfA/v6ZXoFL3vFcudueMsUjYvtewA400B4orkZcnbO8vpfHyI+Cxt/xAQb4 ZZM6+R+snR9PbLXiTC/Y5mTXSvVq2tje0FyX3A9UcTlFBVKiEdTmS0jZ8opjzo7qnPxV w/36ZroBOrDaa45Hl8pu0PFXjCqEbivK2aAHhPfGliHCVGbstdy2g4UaBLnB+e2CL1OX sYuA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:references:in-reply-to:subject:cc:to:from :dkim-signature; bh=ZECXte5D6jxim+3xK4HKfAtIsgXPnPOa+pKdouz7m2A=; fh=0jPOD0iX9NIoXTdBPdN2MjZQ3iPAUsCO/T4MlUWG9/s=; b=cXNQhKGijKXdUB25PLx2DU3TtrdIHYcSwbzXbWdTsg68Q6tmSGUXFpnFzdlwmefiTD MWxNhkwyZPowpEcNH62jEGh9t7VXGnBd8gqxII46K1cgwF3UaT6VtB3vh8uLnuohuTkn QRatvpV6wPdvPOvK67UQYvQppqoOptNp5127IDDK70mhfqfFTbVgINri2uW7uQvu5Ay+ AUN2IE0QzM2byzRPF+BHOsCS0AnHUtCGqJ5s/rzFj+2ybPtr1KC7UHXB7azCP6ou32vt JR4Xn/D4bDPyX2sZJ6xbWdIwv8p3+V+guFTwZmiOM1LiCgOOaG6PcS92Jp0am7Mf8PV2 zx0Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=h2Kpo4au; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-54620-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54620-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com X-Forwarded-Encrypted: i=1; AJvYcCUQnv/GbHr2GfPgBMqALow/MzK1f1e3AM1dEZOXfyS0LIYKW7nvSbWbwrKN129jDvS2rMWSqc+mC5kwlbhM2ey3PdaPgB2XMflHxzkeyw== Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id h2-20020a170902f54200b001d7204a84ccsi1359526plf.156.2024.02.06.01.50.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 01:50:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-54620-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=h2Kpo4au; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-54620-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54620-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 9F577B23F95 for ; Tue, 6 Feb 2024 09:48:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 37C0A12D76D; Tue, 6 Feb 2024 09:48:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="h2Kpo4au" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9F1512D15A for ; Tue, 6 Feb 2024 09:48:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707212923; cv=none; b=ir2S2ihHIzzUoSifrvy+ksLUPFRRW0BTaS+WSoUfd1rJRFwvwoLBu0pn2l69REmVYGz44wMhfqLLnSULCclZ3+ClIvbZ4t8ohdBEpvn+LwSpxfdyJqGPTVGAkPE16a8hLgvbEb34j2tmRWEv/0grclOLZTCIOys0a/EDWWNqpsM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707212923; c=relaxed/simple; bh=ZECXte5D6jxim+3xK4HKfAtIsgXPnPOa+pKdouz7m2A=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=UPPzi95PhBCZHO3iDysSpjoHJE1CsQdwTo4c6MMD9QV4eVKHUb65qz6PFVu8P+r0prb1Y0BxhAyiOnOKxPx46Iv0FlbB3xaeCJfKQrCIuLD7GEDRlAORH/OQFrnR1HOZCRUlAUuAEmTq7rEkHjAp5Oh5QcBXZ4jHjyQmq3MTuZw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=h2Kpo4au; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707212920; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZECXte5D6jxim+3xK4HKfAtIsgXPnPOa+pKdouz7m2A=; b=h2Kpo4au8g19SBUWo3a8Cx5lJg6nR1Lh8rSG51SzWkcH+1O1+lR1nyGFoSxBt4m9vtV3QP Kg5aYpyHnrNpMy/c57SJbBdD6CLppMH2y+OAL0+PpRl61/oT+4eA8Zh0MclHuO57A9c6gP DlyPVIrtAhrxvhls6tH6QUp8Jzm6M5U= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-249-F_pSe24gMzu4yDLKGfIusg-1; Tue, 06 Feb 2024 04:48:39 -0500 X-MC-Unique: F_pSe24gMzu4yDLKGfIusg-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7816bea8d28so71322185a.0 for ; Tue, 06 Feb 2024 01:48:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707212919; x=1707817719; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZECXte5D6jxim+3xK4HKfAtIsgXPnPOa+pKdouz7m2A=; b=RMVX9bad+A9U/UzkNoFxx+bnWgz8s/O7F9bi3n5u5d19On65lXbkcwaMAeiwbIhsmI sjegJ4mCaRqH9l4oW45pUl+ddX/6msCnrjrGcQnembOoMIDhzPVBJej19HAj/etar37U pBSc0FY9l8fRt69ejSw9zse4G/CH2kh2jTvXaBcHfRlRD8hlJXFKQxX6hkazOP4xbx3G bHwfDbIHT/heV38iHf+DfeX5C2JR3mavsD4e8jb5vx2jcjsje7ahgHAXIY4nECGFiVwW 2W1kbERZF2Y5Coe3IKsihwsH6mA+XG2lxqqOpTkzIOxMNUjHhAXBnhZjM9Y2AdKSXauX UF0w== X-Gm-Message-State: AOJu0Yyc/SMFNIlpxE8N39yPDtG2yLXhMW+4X9URoTyUPJ/R4U6CrAdS 1Cam1qKU0jJno41NvubQwZRjixg5OBsrcN8I1VWsZ35y6cX11cWrTU0KVSe/dJ6eCapMdxa9lYk zcuG4ZiiDCw+uNN2UPJwOQBI3za8SabTMT+KLpBVhlvYn2HHTl0j9CYqL+5sFzw== X-Received: by 2002:a05:620a:a0a:b0:785:440c:88d9 with SMTP id i10-20020a05620a0a0a00b00785440c88d9mr3132320qka.26.1707212919016; Tue, 06 Feb 2024 01:48:39 -0800 (PST) X-Received: by 2002:a05:620a:a0a:b0:785:440c:88d9 with SMTP id i10-20020a05620a0a0a00b00785440c88d9mr3132299qka.26.1707212918799; Tue, 06 Feb 2024 01:48:38 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWrwQH0hQVhe0VPR2hZe1xCBNzOga+tBypyXg9hbQvH1pSJTdI7ZgtdHVcgn6rRQl+DcDxogftvodzYEPMJcaE1n9N7qNBFDS0DzHuY5qac4HvBPl4xY1ZKtO+OG4//zVUqXI6pu9szxT6PbFd+Mg3/Q9NK+yt1QHl673JhfVjN68a+gsIW7JBv8B72s99yHahQdNhMJQCacc10tltod0G851RTWM9eydTsNB65V+244gDRPrxEs38kkuQhc6VsRrfWU8+x+p2KzxN+bFCXjenbh5UvaUgCP/k6wcRaVPZrJmqidM9WzpAXS3w4drJCjsCrAcyPeFlYA3KX3DIPbbrQYBfaanGCJ0r+tQvk66smv+0XgnTtph+0swz1geuaMIoW0VbyW6unIY58owxDU/xoismXsKre7CN8N+hBbz5NFQwr1kx4d9KCg+tBBCw9KWPXRf+Msue1u9Zrurx3kdKYb5j5P+NtCZ28MKScxPbx7tshK/gRorlyHgmpvKz39Q2Wr9OKV7QbVqKcQsTDAwFBNc6/VzBZYuROo9rQkomBdVIQMrxdgleexKu8XRwurJTaACHsWiMlbACtt6c7Aqv5VstSx/I8wnE6bQ== Received: from vschneid-thinkpadt14sgen2i.remote.csb (213-44-141-166.abo.bbox.fr. [213.44.141.166]) by smtp.gmail.com with ESMTPSA id vr11-20020a05620a55ab00b007815c25b32bsm764188qkn.35.2024.02.06.01.48.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 01:48:38 -0800 (PST) From: Valentin Schneider To: Onkarnarth , rafael@kernel.org, lenb@kernel.org, bhelgaas@google.com, viresh.kumar@linaro.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, r.thapliyal@samsung.com, maninder1.s@samsung.com, Onkarnath Subject: Re: [PATCH 2/2] kernel: sched: print errors with %pe for better readability of logs In-Reply-To: <20240206051120.4173475-2-onkarnath.1@samsung.com> References: <20240206051120.4173475-1-onkarnath.1@samsung.com> <20240206051120.4173475-2-onkarnath.1@samsung.com> Date: Tue, 06 Feb 2024 10:48:33 +0100 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On 06/02/24 10:41, Onkarnarth wrote: > From: Onkarnath > > instead of printing errros as a number(%ld), it's better to print in string > format for better readability of logs. > > Signed-off-by: Onkarnath I quick ripgrep tells me this is the only culprit in sched, so: Reviewed-by: Valentin Schneider