Received-SPF: pass (google.com: domain of linux-kernel+bounces-54622-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 6 Feb 2024 15:23:09 +0530
From: Jai Luthra <j-luthra@ti.com>
To: Markus Elfring <Markus.Elfring@web.de>
CC: <linux-media@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
        Mauro
 Carvalho Chehab <mchehab@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: ti: Use devm_platform_get_and_ioremap_resource()
 in ti_csi2rx_probe()
Message-ID: <5m4zr6d3geqdyxtr5owlur4ysn6ublauvc5km3boga2vnm2rwj@mflpsf4ql2yj>
References: <66d7218d-ed57-4dec-b6ac-630b01056b5e@web.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="ekxxjz6nz7mmacqj"
Content-Disposition: inline
In-Reply-To: <66d7218d-ed57-4dec-b6ac-630b01056b5e@web.de>

--ekxxjz6nz7mmacqj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Markus,

Thanks for the patch.

On Feb 05, 2024 at 13:20:30 +0100, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 5 Feb 2024 13:14:00 +0100
>=20
> A wrapper function is available since the commit 890cc39a879906b63912482d=
fc41944579df2dc6
> ("drivers: provide devm_platform_get_and_ioremap_resource()").
> Thus reuse existing functionality instead of keeping duplicate source cod=
e.
>=20
> This issue was detected by using the Coccinelle software.
>=20
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>=20
> diff --git a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c b/driv=
ers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
> index 2b078c5d7f5d..6ff066097346 100644
> --- a/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
> +++ b/drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
> @@ -1100,9 +1100,7 @@ static int ti_csi2rx_probe(struct platform_device *=
pdev)
>  	platform_set_drvdata(pdev, csi);
>=20
>  	mutex_init(&csi->mutex);
> -
> -	res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0);

As this "res" variable is not used anywhere else, it would be better to=20
drop the declaration for it and instead call:

    csi->shim =3D devm_platform_get_and_ioremap_resource(pdev, 0, NULL);

With that change,

Reviewed-by: Jai Luthra <j-luthra@ti.com>

> -	csi->shim =3D devm_ioremap_resource(&pdev->dev, res);
> +	csi->shim =3D devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>  	if (IS_ERR(csi->shim)) {
>  		ret =3D PTR_ERR(csi->shim);
>  		goto err_mutex;
> --
> 2.43.0
>=20

--=20
Thanks,
Jai

GPG Fingerprint: 4DE0 D818 E5D5 75E8 D45A AFC5 43DE 91F9 249A 7145

--ekxxjz6nz7mmacqj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEETeDYGOXVdejUWq/FQ96R+SSacUUFAmXCAYEACgkQQ96R+SSa
cUVs2RAAoDNeIAoxmXLJW69vzAgfsDK3nAP/f1l9xi0PCdI/tp9izoH56ZDdfqCg
meFeluBzx29ElvdWPOi0znO5fWzrsVh9y5TMT2xvXDYwtEbTlWRodSXOKivRVxnp
JO0auCuTtKNEdjtg6UDMx+LW/9umYpW6Nc9VS/EcYCLjAonDShUyLl2u3yFzeiFk
4Z4DKJGkVnOAo5Hmx5N8NPHhUpv+gzl60QB89Sbi07YCY39EG+nWM40VNN7FNvQG
KmgWrzvmEweVI6Rmi77c77Prr6fyLOxVPZjOyR1FOJpT3sTSWN+Is/eojt8lPaSQ
6zcADvpeKWBgnrZACmuSYH1yoAGI3SGYut+MZOalRVMjTHB7EQy84FMMQLDYlIq6
WfFwiRonozWcMo45bMtOoN5YnzAxYPM3HkssxdQfkIRND4cwS/MMBJAHhhfwdrlx
Ezilw2tPidOiKX/T3tNvE+7flAiyDCxfjjnmqyzJpx3lk/NsHQFF0j49BlFMtDHC
N/Oy3GBIBQpz5My4yXECcH8pGZ0Q2RyLlT9gVVk3GHwGrac53U1llAvtKChTp+gJ
vK9DWqXTl4KYyj9ksGRd3gKTTz7I+LAc6H9w6nvXmMz7R8SZKWsHZgD7MlT/Qfqa
OYlb0Y5uL0XTM3zN9JxLN3j/1+JAsakX7IJPLDLGrIWV/NtSUa0=
=MQR4
-----END PGP SIGNATURE-----

--ekxxjz6nz7mmacqj--