Received-SPF: pass (google.com: domain of linux-kernel+bounces-54704-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 6 Feb 2024 18:38:29 +0800
From: Shawn Guo <shawnguo2@yeah.net>
To: Frank Li <Frank.Li@nxp.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>,
	open list <linux-kernel@vger.kernel.org>, imx@lists.linux.dev
Subject: Re: [PATCH 2/2] arm64: dts: imx8dxl update edma0 information
Message-ID: <ZcIMJWKBrPW4Y5R8@dragon>
References: <20240129201633.234255-1-Frank.Li@nxp.com>
 <20240129201633.234255-2-Frank.Li@nxp.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240129201633.234255-2-Frank.Li@nxp.com>

On Mon, Jan 29, 2024 at 03:16:32PM -0500, Frank Li wrote:
> edma0 of iMX8DXL is difference with other imx8 chips. Update register's
> size, channel number and power-domain.
> Update i2c[0-3] channel number information.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  .../boot/dts/freescale/imx8dxl-ss-adma.dtsi   | 65 +++++++++++++++++++
>  1 file changed, 65 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8dxl-ss-adma.dtsi b/arch/arm64/boot/dts/freescale/imx8dxl-ss-adma.dtsi
> index 0a477f6318f15..f8fca86babda7 100644
> --- a/arch/arm64/boot/dts/freescale/imx8dxl-ss-adma.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8dxl-ss-adma.dtsi
> @@ -15,6 +15,63 @@ &adc0 {
>  	interrupts = <GIC_SPI 146 IRQ_TYPE_LEVEL_HIGH>;
>  };
>  
> +&edma0 {
> +	reg = <0x591f0000 0x1a0000>;
> +	#dma-cells = <3>;
> +	dma-channels = <25>;
> +	dma-channel-mask = <0x1c0cc0>;
> +	interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>, /* asrc 0 */
> +		<GIC_SPI 263 IRQ_TYPE_LEVEL_HIGH>,
> +		<GIC_SPI 264 IRQ_TYPE_LEVEL_HIGH>,
> +		<GIC_SPI 265 IRQ_TYPE_LEVEL_HIGH>,
> +		<GIC_SPI 266 IRQ_TYPE_LEVEL_HIGH>,
> +		<GIC_SPI 267 IRQ_TYPE_LEVEL_HIGH>,
> +		<GIC_SPI 0   IRQ_TYPE_LEVEL_HIGH>,
> +		<GIC_SPI 0   IRQ_TYPE_LEVEL_HIGH>,
> +		<GIC_SPI 327 IRQ_TYPE_LEVEL_HIGH>, /* spdif0 */
> +		<GIC_SPI 329 IRQ_TYPE_LEVEL_HIGH>,
> +		<GIC_SPI 0   IRQ_TYPE_LEVEL_HIGH>,
> +		<GIC_SPI 0   IRQ_TYPE_LEVEL_HIGH>,
> +		<GIC_SPI 189 IRQ_TYPE_LEVEL_HIGH>, /* sai0 */
> +		<GIC_SPI 189 IRQ_TYPE_LEVEL_HIGH>,
> +		<GIC_SPI 191 IRQ_TYPE_LEVEL_HIGH>, /* sai1 */
> +		<GIC_SPI 191 IRQ_TYPE_LEVEL_HIGH>,
> +		<GIC_SPI 193 IRQ_TYPE_LEVEL_HIGH>, /* sai2 */
> +		<GIC_SPI 199 IRQ_TYPE_LEVEL_HIGH>, /* sai3 */
> +		<GIC_SPI 0   IRQ_TYPE_LEVEL_HIGH>,
> +		<GIC_SPI 0   IRQ_TYPE_LEVEL_HIGH>,
> +		<GIC_SPI 0   IRQ_TYPE_LEVEL_HIGH>,
> +		<GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>, /* gpt0 */
> +		<GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH>, /* gpt1 */
> +		<GIC_SPI 270 IRQ_TYPE_LEVEL_HIGH>, /* gpt2 */
> +		<GIC_SPI 271 IRQ_TYPE_LEVEL_HIGH>; /* gpt3 */
> +	power-domains = <&pd IMX_SC_R_DMA_0_CH0>,
> +			<&pd IMX_SC_R_DMA_0_CH1>,
> +			<&pd IMX_SC_R_DMA_0_CH2>,
> +			<&pd IMX_SC_R_DMA_0_CH3>,
> +			<&pd IMX_SC_R_DMA_0_CH4>,
> +			<&pd IMX_SC_R_DMA_0_CH5>,
> +			<&pd IMX_SC_R_DMA_0_CH6>,
> +			<&pd IMX_SC_R_DMA_0_CH7>,
> +			<&pd IMX_SC_R_DMA_0_CH8>,
> +			<&pd IMX_SC_R_DMA_0_CH9>,
> +			<&pd IMX_SC_R_DMA_0_CH10>,
> +			<&pd IMX_SC_R_DMA_0_CH11>,
> +			<&pd IMX_SC_R_DMA_0_CH12>,
> +			<&pd IMX_SC_R_DMA_0_CH13>,
> +			<&pd IMX_SC_R_DMA_0_CH14>,
> +			<&pd IMX_SC_R_DMA_0_CH15>,
> +			<&pd IMX_SC_R_DMA_0_CH16>,
> +			<&pd IMX_SC_R_DMA_0_CH17>,
> +			<&pd IMX_SC_R_DMA_0_CH18>,
> +			<&pd IMX_SC_R_DMA_0_CH19>,
> +			<&pd IMX_SC_R_DMA_0_CH20>,
> +			<&pd IMX_SC_R_DMA_0_CH21>,
> +			<&pd IMX_SC_R_DMA_0_CH22>,
> +			<&pd IMX_SC_R_DMA_0_CH23>,
> +			<&pd IMX_SC_R_DMA_0_CH24>;
> +};
> +
>  &edma2 {
>  	interrupts = <GIC_SPI 288 IRQ_TYPE_LEVEL_HIGH>,
>  		     <GIC_SPI 289 IRQ_TYPE_LEVEL_HIGH>,
> @@ -48,21 +105,29 @@ &edma3 {
>  &i2c0 {
>  	compatible = "fsl,imx8dxl-lpi2c", "fsl,imx7ulp-lpi2c";
>  	interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH>;
> +	dma-names = "tx","rx";
> +	dmas = <&edma3 1 0 0>, <&edma3 0 0 FSL_EDMA_RX>;
>  };
>  
>  &i2c1 {
>  	compatible = "fsl,imx8dxl-lpi2c", "fsl,imx7ulp-lpi2c";
>  	interrupts = <GIC_SPI 223 IRQ_TYPE_LEVEL_HIGH>;
> +	dma-names = "tx","rx";
> +	dmas = <&edma3 3 0 0>, <&edma3 2 0 FSL_EDMA_RX>;

No FSL_EDMA_TX for "tx"?

Shawn

>  };
>  
>  &i2c2 {
>  	compatible = "fsl,imx8dxl-lpi2c", "fsl,imx7ulp-lpi2c";
>  	interrupts = <GIC_SPI 224 IRQ_TYPE_LEVEL_HIGH>;
> +	dma-names = "tx","rx";
> +	dmas = <&edma3 5 0 0>, <&edma3 4 0 FSL_EDMA_RX>;
>  };
>  
>  &i2c3 {
>  	compatible = "fsl,imx8dxl-lpi2c", "fsl,imx7ulp-lpi2c";
>  	interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_HIGH>;
> +	dma-names = "tx","rx";
> +	dmas = <&edma3 7 0 0>, <&edma3 6 0 FSL_EDMA_RX>;
>  };
>  
>  &lpuart0 {
> -- 
> 2.34.1
>