Received-SPF: pass (google.com: domain of linux-kernel+bounces-54722-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 6 Feb 2024 10:56:20 +0000
From: Mark Brown <broonie@kernel.org>
To: Louis Chauvet <louis.chauvet@bootlin.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
	thomas.petazzoni@bootlin.com,
	Miquel Raynal <miquel.raynal@bootlin.com>, yen-mei.goh@keysight.com,
	koon-kee.lie@keysight.com
Subject: Re: [PATCH 2/2] spi: omap2-mcspi: Add support for MULTI-mode
Message-ID: <ZcIQVKibMmGegw+j@finisterre.sirena.org.uk>
References: <20240126-spi-omap2-mcspi-multi-mode-v1-0-d143d33f0fe0@bootlin.com>
 <20240126-spi-omap2-mcspi-multi-mode-v1-2-d143d33f0fe0@bootlin.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="1uXBsuND+NmkCmGl"
Content-Disposition: inline
In-Reply-To: <20240126-spi-omap2-mcspi-multi-mode-v1-2-d143d33f0fe0@bootlin.com>


--1uXBsuND+NmkCmGl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Feb 06, 2024 at 11:00:50AM +0100, Louis Chauvet wrote:

> Introduce support for MULTI-mode in the OMAP2 MCSPI driver. Currently, the
> driver always uses SINGLE mode to handle the chip select (CS). With this
> enhancement, MULTI-mode is enabled for specific messages, allowing for a
> shorter delay between CS enable and the message (some FPGA devices are
> sensitive to this delay).

I have no idea based on this commit message what either of these modes
is or how this shorter delay would be achieved, these terms are specific
to the OMAP hardware AFAICT.  Please clarify this, it's hard to follow
what the change does.  It looks like this is just a CS per word thing?

Note that you may not have to tell the hardware the same word length as
the transfer specifies, so long as the wire result is the same it
doesn't matter.

--1uXBsuND+NmkCmGl
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmXCEFMACgkQJNaLcl1U
h9DKjAf/W41ubd9F4AL5xNDGXx0GXCzvwTgjG8n+1FoDhInLiggXU97xVnUGp63/
grVBFZCoJmEV6kXCzob8sRiOQyYTiIWq7g98voFlAbvprraMOniul0eZqmvKpNSy
HktuQR9QIbDuiNHCRD4a/qat06cgi/ij6oF/r5F9VdvOUu3UyAhMzVm46yEsFIqV
1PqA8y0/6DVGM+NUEwXevlAKx7pP2IYb2LBi51SHKBvwvxIhXIw99H4kQ9XdRJu1
zzp08wL8eWiZQNM1QOuhuLoa1sfvKQBRZmErHf0o0i99rfCblO5q0JqrvuT2qCsX
WrQ21twP7gkv1mwIVJIIut9LJGNZQg==
=rKBz
-----END PGP SIGNATURE-----

--1uXBsuND+NmkCmGl--