Received-SPF: pass (google.com: domain of linux-kernel+bounces-54744-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <ee6ec5a8-e2e3-4811-94f1-d6c25b981a38@oracle.com>
Date: Tue, 6 Feb 2024 11:05:59 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 2/3] iommu/iova: Reorganise some code
Content-Language: en-US
To: Robin Murphy <robin.murphy@arm.com>, joro@8bytes.org
Cc: will@kernel.org, pasha.tatashin@soleen.com, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org, rientjes@google.com,
        yosryahmed@google.com
References: <cover.1707144953.git.robin.murphy@arm.com>
 <d4753562f4faa0e6b3aeebcbf88fdb60cc22d715.1707144953.git.robin.murphy@arm.com>
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <d4753562f4faa0e6b3aeebcbf88fdb60cc22d715.1707144953.git.robin.murphy@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?bHdWcnhLMUFQRDVwVXUrbWlEL1ErV3J3ekdqbkU0ZWRQditRMmJ3V1RuR1ZO?=
 =?utf-8?B?K3NGa3EzdGdNZlVlR0NadmJkTjZ3WEdoOU92ajZZZi8yaHRjNXkxa1QwUnlz?=
 =?utf-8?B?VzlYZC9wT3Zkc28zQ2I4SGJmZlUzQlNQbHdhYnNiaGN0M3RKa2ZjakJESitX?=
 =?utf-8?B?Vy9aYnlpbEVra1FrYW1PanRtVVpOR0NzTVVlUEN4MS8rRjdKNW9vVUE4NlF5?=
 =?utf-8?B?RXQ4b0VpSGpUbHM2Rm0rZHdaTG9acHFTVkh3RkZkTE5GblpFc2htTlJnSXMy?=
 =?utf-8?B?OTRlMEw0K2hxdktPcXNHR1RTMFNtQ3FXL1VPaURmK2VwSm0zWE9OUDhwYjJQ?=
 =?utf-8?B?NTV2WGp4bUlZdFBYUEFXa0lsSkZ5aG55MnYyNW81SUp6b01WdHU4b3V0YTVl?=
 =?utf-8?B?Mk1LWG92SGFmQUtSQlNLQ2p3VVR2M1A4VmFwUE9jUzlaVnFMMzFaTXV5cnQw?=
 =?utf-8?B?U3U4VU10WHRVNys0Tnp6djNhQWNFa0VmMVlyREVnVmtITVE2SW9TSXUwbkNw?=
 =?utf-8?B?ZGM1NXVKT3E4L2k0ME9uNzVvRFlMRUtVR1VYMDdHcVN0SDArSDFRNXJXUWRL?=
 =?utf-8?B?bHF1K0dhNDhWampIa2p4MU44Z0ZKUG92Q2VxZGEvaVI1QnJnWnpPTEY1M3ox?=
 =?utf-8?B?cUt3TU5ycjdmdnc4QjFEelM4ZURXOTJYdjZ1UUp4SmdHejJKVWs3Y0JzS2lX?=
 =?utf-8?B?T3RLVFY2RjlHWDhjbjUxRlBxaWt4ZnhVcWowSkRSK2dPMFZ3UVRkUjNJeWh3?=
 =?utf-8?B?b002Q1ArY29iMTNhaUE3ZllHNWNsdnNQQTNnc1BTL3cyK3JrbThRZkdpcG5J?=
 =?utf-8?B?KzVXcFJqa1pnSnBDcEVvbHNIemM5VGd4T2RtWWVHZ2VwWEZxQnkvckhzZUg2?=
 =?utf-8?B?REdaNUdLd3k2OUFaZzViQWxmVWdLSHluendsZzBwVzZmMzQrWEJpNllMY3FT?=
 =?utf-8?B?dDJjUE1FN0xhVWlZalZIblBDeTJ0cUdpd1pSdFYyUnBPSjFqY1ZhUUlZaS9t?=
 =?utf-8?B?eFYzcGZJbVFaZUwrKzZmdnRIWUkwbGtHcHU0aVF2MkdGMHVEbnVtR2s2dVpL?=
 =?utf-8?B?S2FsTGE0QjkwcHBSU0FMU0hPeHZQNXlKZklmL3cybUZEOC9mZjhRTGl6TEw0?=
 =?utf-8?B?U1NYckMrdGY3azd2Y2FXYmQrT0NkRnJOcmNGcHJZbTlVZFpSdTRJdVUrSllv?=
 =?utf-8?B?bXFoaERQUWlGTXpoR1N2RjgxNjRCcmFGcWxHL2hURXQrUW1janFFQnNQTWFh?=
 =?utf-8?B?UmE0SURKOVpTRlNHTWZydHNoUVpQdGlTTS9JZkp1VlhISXozNXowMnIzaGlx?=
 =?utf-8?B?TXhrN2lZc0x6RkVWSVpmOFYvR2VWeGxEZWd5N3JaRmt3L2JIeVkwMFRUTS9R?=
 =?utf-8?B?MXFSanVvcXdYN0ErellPVTBVM0dCeGE3REd4VWxoS29BYjQ3TE42VDhRMm5a?=
 =?utf-8?B?Q0F0aHhwTDI3cUtFZEVDeXFPclNVMTlKNU53RGtrWE1GZEhqL3ZoVGNpaXhR?=
 =?utf-8?B?YWJJVHZ0NE9TcEJCVmF2ZEt5RjBZS050bzRCRUVnYnp0dW4rcFBmY3g2eXJ5?=
 =?utf-8?B?TW92OGJ2ZnRudG1WVWdJUkJBNzdPWDBEOERoQ0JOeTE2aGtOR1lEaEloN1I2?=
 =?utf-8?B?WktDOG8xNnNadVo0eWpuL0FKNTJzclprd0NuNDlFYVErenNmaFpPQXpxRzFP?=
 =?utf-8?B?SGdlMWRkY1I3RXZxMXgxcjZRbFBiWmM5dlMrZmc5UEhsaDRydzEyMnZ2SnBp?=
 =?utf-8?B?M2Flazk2bHJWSEdjWkhkRTBKSFlhZmszRFFjSTcwNktSVmYxcm9wTElNT29p?=
 =?utf-8?B?SWdoMDljM1VYWXUzYVEwM0dTNEpIL0pUNWtFYTJ2UDBVTXNsdWFoN1puNVA2?=
 =?utf-8?B?MVRUclQxcTd6YlFjYVdyQk9rUDQzYThiaVlucUlZekUxTXBwWVB4d2hJaDFE?=
 =?utf-8?B?R2tuZFU3U1R1Qlh6QlV2VDBId2Q1VkhiVzA3WU0wN2E0OUx2b2lTaGdnMU9o?=
 =?utf-8?B?SG1rVm4zZ0tNNFdmcjJiSG5lZVFTaVlPWElsT0F5bmUxTXJVbzFidWdBdWVx?=
 =?utf-8?B?ZjZ2SzJqU0xPUk9pdnA3c2QzTkduODd4Y1piT1BlOTZHNHRBd2xxSUUvMEpy?=
 =?utf-8?B?TG4yT3hrTmVCTmE5WlRuV1dhb0Jyd1NYRGk3R2tvS3YxaGp4UklzaG9iSEpj?=
 =?utf-8?B?aEE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	U0PO86Hmv7LX0JZrTvxYjph/PRHkjG3yQQguvGQKZF6m36G3iJ16nOEN4hLflCIUTH6WJzH3pI3XecjD7uP/FgykM0A43n4fKmDRz0XLYmq6WNG1zJoK1gN0Vet4fxgLfJ9436Tw6pRKxgkCBnQCWSgKh6+GvlTQvyUKWgxQwP2pjsorCeLr9cmCkxEgKkkB+h4BMcGjSMuS8K3UXlAdvltBjr0mJY1F81H1WNy4csmnvs4J6MgB9pVfC/RvO30J1pY6oe1p9ZLDK12iaAfMKVIBJEdIHttE13FPQuRff3SORb47Sv+q8MX8RDlzqN7ltGdbpfEv3Cmg/JkU0cRRmM9PcIe0w8+dDC2WCpz8+NEwzKKcHtafml9znAkjsIcWibbjcjRxinWID8f2B677kOoLIb3ia9c155bd4SLHt59xA+9mECO3MzR6pHLet7m2d/Rad6T5xmx4sbYuHUcdCOQApPaQm98Q1jcAc0HvkiKeUVbJdYKQgz2R7lvVRgtaT5WUrOijKVyeBo4NTxfvYTbJmLDe/CwSSdWiDeOGGRIMtTsEVbxDSlL3vLHUm2Wtc0gK0sFvrFQfWq6Gu7/aBPXnZWBPts/mfqyc3TZx15w=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f59766d-9708-4e6c-a4fa-08dc27039bd2
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2024 11:06:03.4512
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8AlOMj2FgbkAxyLc7IgDcwAWR0Oe6/5GzJmP4949/sOqWLXMhDEv7RFe1eF/4O0T3R9iwxmOu3TRIBJLOi/Y+A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5180
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-06_04,2024-01-31_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0
 mlxlogscore=791 bulkscore=0 mlxscore=0 phishscore=0 adultscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402060078
X-Proofpoint-GUID: 6hK_bJfQmQUYaiDZeyyCATKTRbG9SaSJ
X-Proofpoint-ORIG-GUID: 6hK_bJfQmQUYaiDZeyyCATKTRbG9SaSJ

On 05/02/2024 15:32, Robin Murphy wrote:
> The iova_cache_{get,put}() calls really represent top-level lifecycle
> management for the whole IOVA library, so it's long been rather
> confusing to have them buried right in the middle of the allocator
> implementation details. Move them to a more expected position at the end
> of the file, where it will then also be easier to expand them. With
> this, we can also move the rcache hotplug handler (plus another stray
> function) into the rcache portion of the file.
> 
> Signed-off-by: Robin Murphy<robin.murphy@arm.com>
> ---
FWIW:
Reviewed-by: John Garry <john.g.garry@oracle.com>