Received-SPF: pass (google.com: domain of linux-kernel+bounces-54746-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240205110244.676779-1-naresh.solanki@9elements.com>
 <8714b420-58b9-4d5b-a489-31670c8d325f@linaro.org> <CABqG17jfHpi5oDt+=E925Fp6DN2OftmDEjpmvb5=3nxMt+d2iw@mail.gmail.com>
 <47d66b4a-5608-4fc9-88bc-911f74d62819@linaro.org>
In-Reply-To: <47d66b4a-5608-4fc9-88bc-911f74d62819@linaro.org>
From: Naresh Solanki <naresh.solanki@9elements.com>
Date: Tue, 6 Feb 2024 16:37:37 +0530
Message-ID: <CABqG17gS6kdXKdVOc-CFEQp_BGJBANdCmEhUvQ1t=Tx=vw-9pg@mail.gmail.com>
Subject: Re: [PATCH] dt-bindings: mfd: Update pattern property case
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Patrick Rudolph <patrick.rudolph@9elements.com>, mazziesaccount@gmail.com, 
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

Hi Krzysztof,


On Tue, 6 Feb 2024 at 13:06, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 05/02/2024 15:00, Naresh Solanki wrote:
> > Hi Krzysztof,
> >
> >
> > On Mon, 5 Feb 2024 at 18:38, Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> >>
> >> On 05/02/2024 12:02, Naresh Solanki wrote:
> >>> Driver expects regulator child node in upper case.
> >>> Hence align with the same.
> >>
> >> Did the driver have DT support before? I think no, so why aligning that
> >> way? I would argue that driver should be aligned with bindings, the
> >> moment you add DT for the first time.
> > Yes the driver has DT support already.
> > This patch is to align with driver:
> > https://github.com/torvalds/linux/blob/master/drivers/regulator/max5970-regulator.c#L381
>
> That's not support for DT, but just naming regulators.
I'm not sure if I get your perspective right & please correct me if I'm wrong,
I'm just trying to adjust the dt binding of max5970 because found
errors related to
regulator child node SW0/SW1.
Regulator driver expects to have regulators child nodes as SW0/1(upper case)
But dt binding expects it to be lower case.
Thus there is misalignment & due to which, when running CHECK_DTBS for my
mainboard DTS, I see some errors.

>
> >
> > It was aligned but I missed on case sensitivity.
>
> I don't see the alignment. Where did you align it? Which commit?
The current patch is to address the regulators child node name with driver.

Regards,
Naresh
>
> > Driver expects it to be SW0/SW1
> > but DT had it as sw0/sw1.
>
>
> Best regards,
> Krzysztof
>