Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp2986188rdb; Tue, 6 Feb 2024 04:02:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IFjwvhAfHKqwNc6bvONTwRl9GN69c1BtUPGx4eKfGgl/DagIcm4ZUfo988T3sUUAUETSqFl X-Received: by 2002:a17:902:d512:b0:1d9:b0fc:6e70 with SMTP id b18-20020a170902d51200b001d9b0fc6e70mr1773461plg.58.1707220971756; Tue, 06 Feb 2024 04:02:51 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707220971; cv=pass; d=google.com; s=arc-20160816; b=jsMwLoOLWYijD33mDJiLQH9nhfItuqE2ML/z2llavNC5hWSpSG3ZYbRdfFLEDlnEG9 YI0He816Mt1OgP4Da5EC7iwwAodeqrNxGs7T/XudvhmYttheZY9QILjFfYrfFRKuOinL aDqWLCo3LVH9Y/alPwPT796Dh7C4eQ38fdf9T4qOeEdfTNRXjPret/MtCVffofNi96HC VVlLwySK99+8y7vsIfV7ynEx2JStJuW9tspRtENuA+hN5IBz1epYydkoJtjS5y09m9Y1 /CvN6Z61aLejEWdgdnqcoT8pv0cZlp5IZQJujRGNarQVWk1p9NZwvhzZPCHQnXGFu3gu RpIw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=LgStSMzzVGruMHl1t/Pl1KmMB+700dD4gEWkJUh5cH8=; fh=CO0Ffv8nVNmQZgixbuOqxXcYYdqd1BHzSGWOEEeShuc=; b=1B7W+O5dmchhFER8Gt7m01xtdXotLgAV7pdGeE/iiU3MEYorvqO66UIlEv9woKSiPZ U1S10yC02XrBIvdd/LzDa7P0BdOr37p+8QlSrmDB2yRsAUPo2DXAlS9SQQo1Mb0PaGea KYGMIoOjhvY1laghg/ZJE2CXzAWuC68mHXAEvPl3R6uz9UL9AqEP8vRWzVaGG3svyG0v 44N5vV8X+1R6mtVN8tBfEsm2W5JC7gaYsWd0ov0FANSt9Xx5soI9tnbC5to6Zb1AbD4Y GD7JaSFvf3MD9H+d2UuBvpN1xpher2FZKkd14lPR8VGaNhLLzKhC+Ezo7Zjh288CAPSZ Le9w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=T7ckRfl7; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-54831-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54831-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org X-Forwarded-Encrypted: i=1; AJvYcCVKLDt+1Z9LUolFwJHU2MWlCgokf6hzu6N3Kx7ktxNc5aIqZjjg5kX4/w14biaaenbuR8qrWh0VKZivJgTC0byJ0/uqZUUIcePKFGngLA== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id u17-20020a170903125100b001d95405344csi1588527plh.246.2024.02.06.04.02.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 04:02:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-54831-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=T7ckRfl7; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-54831-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54831-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3FEF32887DC for ; Tue, 6 Feb 2024 12:02:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BF596134743; Tue, 6 Feb 2024 11:47:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="T7ckRfl7" Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E210134725 for ; Tue, 6 Feb 2024 11:47:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707220026; cv=none; b=l03SrUtt7UHrXZgbzz3BMF9yCx4HEHxQZjKN43to8BjvmIF2FpWRnw0yLqkB+PBI8loUNEeDQUEZyWcAJnBp9eXIBPOtV7zEOQ4USiaCBqjD+F6Ge2VVwV28Tz624f+Irt6kzaBl4WwIbnhNSwMBUazlqzUCpcxFSIvcISOf0ss= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707220026; c=relaxed/simple; bh=LgStSMzzVGruMHl1t/Pl1KmMB+700dD4gEWkJUh5cH8=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=K5DYo3AQS7JaC3dSF1I8dV2lr/E+TOIEzFkZjOIjSezj5hO6kDvxg/WPXzSMj1nzaT5ep39geHhmDDm5kC9JnAlfkO8h1HK02RFPXlYvStnEt+NIka4NJ9oHC8/G6jhn6u+7WGBwrxo058s0OQky+SYSqRTZ574twkYYWn5r21w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=T7ckRfl7; arc=none smtp.client-ip=209.85.128.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-60460399a33so18881707b3.1 for ; Tue, 06 Feb 2024 03:47:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707220023; x=1707824823; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=LgStSMzzVGruMHl1t/Pl1KmMB+700dD4gEWkJUh5cH8=; b=T7ckRfl7+rz1Il39jNvgCpmjsYDy5v1j7Xb30fEStr+SYZulnz/LrqIup2lAEwh/dZ OVH05SmtkTmyInfa/6LWxNHAd7ErBCQyqETpVptwxBF2UF8Dj6lC2vA6KZiZW2eDw2xr AQdfxjpUPXiGYpODFJgQpyJMapJPLxmTmkDZlQdrNQWOWx7UqU8YgupQx08eO3n1ssTy 2zrKHL+6FD44jxLVpUqGbTkTqz5+Gq8o71dUv99kdjFOjChqxH+iyZOHfjc431D8hB9j zGV32E0gbo6Y7yp7S9JjQizQPO70A5lYbd10fXNshH+h85HvMveExZ6Thv2e8RY/rB94 /FPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707220023; x=1707824823; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LgStSMzzVGruMHl1t/Pl1KmMB+700dD4gEWkJUh5cH8=; b=sDm6AeQFrlcoc6fJo1u25a+6qUuSc49fL2Y2HPX3dl7W/HOcrq5Vfg5YS0RdEIR4S9 d1OeWXiW4C/lDvyWVL30U/oPVf6TZUutPGSxFKc/LU4i7OpYw2A2zg5jPdgyAaakiLwq HVLz9+qOeboxYNrNp29yKCwMlS4JqJKYXiSypu0mHL9gG0vU7c2b4J3ZiqOni0bkZ3zl 5sI23k2MaGD/mi0M64kClaK7YztlWpguooCKqTmCpDCceZeKsx6bNdfrzVM8Z4B3Cm3/ aMSh1nhr8FQhTRFqc6WyirBjFM2P9G+fnavVGnjf8qRWxKGCGXP4X6ONeBOr0Q+pqWx7 G8IQ== X-Gm-Message-State: AOJu0YwDsZ7hprBwltEJ1pAPgvr410UNaHScLS8R5ocpCg22KpRYskv5 jq6UtWzFpG8iFR1Wqdo/ZUPn+aWFIcKzshMMT+EbdapWRmrv2Ze+yfBTPZA4Ld4QGk44A5U4pHH zQUf8hotXOql1tKZRa8BDwlnfBpIFUapRZd8Emw== X-Received: by 2002:a0d:c1c7:0:b0:604:57e2:d87b with SMTP id c190-20020a0dc1c7000000b0060457e2d87bmr1263880ywd.40.1707220023286; Tue, 06 Feb 2024 03:47:03 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240127232436.2632187-1-quic_gaurkash@quicinc.com> <20240127232436.2632187-2-quic_gaurkash@quicinc.com> In-Reply-To: <20240127232436.2632187-2-quic_gaurkash@quicinc.com> From: Bartosz Golaszewski Date: Tue, 6 Feb 2024 12:46:52 +0100 Message-ID: Subject: Re: [PATCH v4 01/15] ice, ufs, mmc: use blk_crypto_key for program_key To: Gaurav Kashyap Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, andersson@kernel.org, ebiggers@google.com, neil.armstrong@linaro.org, srinivas.kandagatla@linaro.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, robh+dt@kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, kernel@quicinc.com, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, quic_omprsing@quicinc.com, quic_nguyenb@quicinc.com, konrad.dybcio@linaro.org, ulf.hansson@linaro.org, jejb@linux.ibm.com, martin.petersen@oracle.com, mani@kernel.org, davem@davemloft.net, herbert@gondor.apana.org.au Content-Type: text/plain; charset="UTF-8" On Sun, 28 Jan 2024 at 00:26, Gaurav Kashyap wrote: > > The program key ops in the storage controller does not > pass on the blk crypto key structure to ice, this is okay > when wrapped keys are not supported and keys are standard > AES XTS sizes. However, wrapped keyblobs can be of any size > and in preparation for that, modify the ICE and storage > controller APIs to accept blk_crypto_key. > > Signed-off-by: Gaurav Kashyap > Reviewed-by: Om Prakash Singh > Tested-by: Neil Armstrong > --- Reviewed-by: Bartosz Golaszewski