Received-SPF: pass (google.com: domain of linux-kernel+bounces-54996-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 6 Feb 2024 13:11:53 +0000
From: Mark Brown <broonie@kernel.org>
To: frut3k7 <frut3k7@gmail.com>
Cc: Robert Marko <robimarko@gmail.com>, linux-spi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] spi: spidev: Add Qualcomm spidev device compatible
Message-ID: <ZcIwGRU5NEZGpRy9@finisterre.sirena.org.uk>
References: <20240205191808.998754-1-frut3k7@gmail.com>
 <ZcH9u7Vo2sFERIHJ@finisterre.sirena.org.uk>
 <CAKEyCaB2Cw0Ey73je96xDgofuXDnsC4DgeS9=HkOM6Kufrwbaw@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="TSh9X79ekmcbSvmM"
Content-Disposition: inline
In-Reply-To: <CAKEyCaB2Cw0Ey73je96xDgofuXDnsC4DgeS9=HkOM6Kufrwbaw@mail.gmail.com>


--TSh9X79ekmcbSvmM
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 06, 2024 at 02:01:27PM +0100, frut3k7 wrote:
> On Tue, Feb 6, 2024 at 10:37=E2=80=AFAM Mark Brown <broonie@kernel.org> w=
rote:
> > On Mon, Feb 05, 2024 at 08:18:05PM +0100, Pawe=C5=82 Owoc wrote:

> > > +     { .compatible =3D "qca,spidev", .data =3D &spidev_of_check },

> > No, this needs to correspond to the hardware being controlled via spidev
> > not to an implementation detail.  Any new compatibles also need to be
> > documented.

> The device for which I want to add compatibility is originally used in the
> router and this is what the dts fragment looks like:

>=20
>       spi@3 {
>         compatible =3D "qca,spidev";
>         reg =3D <0x00>;
>         spi-max-frequency =3D <0x16e3600>;
>       };
>     };

> According to this commit, Qualcomm use this compatibility:
> https://github.com/dissent1/msm-2/commit/d6160218393552fea1b7973787f2bd15=
4f870ee2

This is out of tree, it's not exactly a good guide for mainline.  The DT
should describe the hardware, not how some particular software stack
chooses to drive it.

> > I'm also missing patch 2 of this series so don't know what's going on
> > there.

> The second patch was sent only to the devicetree bindings project:
> https://lore.kernel.org/all/20240205191828.998783-1-frut3k7@gmail.com/
> It's probably done wrong...

You should send the bindings change along with the driver change, they
usually get merged together.

--TSh9X79ekmcbSvmM
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmXCMBgACgkQJNaLcl1U
h9AHFgf9Hjyfancm2AjTLS+ltu1mmSm8WBQY0q55vUJxMgzqAJCL2zH/RerHkIB8
KZ49wUhsgB0qB094E2A//CFoI/js1ZtyMrBE25Q8jbBXjfG6oJnXsY6rCBCtnQFe
p9IkHYznA93Ku4HzfTG3FBd/zeXCPo8AChJ4IpDCUISdkaNwxOUXjpFKSQdSOmrR
4CDsRdxSwQhTsyjhS6Raj0GfZkPfuO//12V1PPSO43Wbxg/6C+29NGcNXl+9FcZs
93VOSOypdeOWCMcGksL2bTZJVbKJq3rb6tSweVulnrZF3D0snQM+AsLgEiNOlUH/
HeVI4O9cpr577WANG1Br1u+SYZOaAQ==
=6ka+
-----END PGP SIGNATURE-----

--TSh9X79ekmcbSvmM--