Received-SPF: pass (google.com: domain of linux-kernel+bounces-55006-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Valentin Schneider <vschneid@redhat.com>
To: David Vernet <void@manifault.com>, linux-kernel@vger.kernel.org
Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
 vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com,
 bristot@redhat.com, kernel-team@meta.com
Subject: Re: [PATCH v3 2/3] sched/fair: Do strict inequality check for
 busiest misfit task group
In-Reply-To: <20240206043921.850302-3-void@manifault.com>
References: <20240206043921.850302-1-void@manifault.com>
 <20240206043921.850302-3-void@manifault.com>
Date: Tue, 06 Feb 2024 14:17:22 +0100
Message-ID: <xhsmhbk8thgv1.mognet@vschneid-thinkpadt14sgen2i.remote.csb>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

On 05/02/24 22:39, David Vernet wrote:
> In update_sd_pick_busiest(), when comparing two sched groups that are
> both of type group_misfit_task, we currently consider the new group as
> busier than the current busiest group even if the new group has the
> same misfit task load as the current busiest group. We can avoid some
> unnecessary writes if we instead only consider the newest group to be
> the busiest if it has a higher load than the current busiest. This
> matches the behavior of other group types where we compare load, such as
> two groups that are both overloaded.
>
> Let's update the group_misfit_task type comparison to also only update
> the busiest group in the event of strict inequality.
>
> Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>

Reviewed-by: Valentin Schneider <vschneid@redhat.com>