Received-SPF: pass (google.com: domain of linux-kernel+bounces-55065-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240205191808.998754-1-frut3k7@gmail.com> <ZcH9u7Vo2sFERIHJ@finisterre.sirena.org.uk>
 <CAKEyCaB2Cw0Ey73je96xDgofuXDnsC4DgeS9=HkOM6Kufrwbaw@mail.gmail.com> <ZcIwGRU5NEZGpRy9@finisterre.sirena.org.uk>
In-Reply-To: <ZcIwGRU5NEZGpRy9@finisterre.sirena.org.uk>
From: frut3k7 <frut3k7@gmail.com>
Date: Tue, 6 Feb 2024 14:57:49 +0100
Message-ID: <CAKEyCaCQk+iL_zOr_0LFOA4Fw+SwyuzSWOvVgmO0Tn8Ygv-4hw@mail.gmail.com>
Subject: Re: [PATCH 1/2] spi: spidev: Add Qualcomm spidev device compatible
To: Mark Brown <broonie@kernel.org>
Cc: Robert Marko <robimarko@gmail.com>, linux-spi@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 6, 2024 at 2:11=E2=80=AFPM Mark Brown <broonie@kernel.org> wrot=
e:
>
> On Tue, Feb 06, 2024 at 02:01:27PM +0100, frut3k7 wrote:
> > On Tue, Feb 6, 2024 at 10:37=E2=80=AFAM Mark Brown <broonie@kernel.org>=
 wrote:
> > > On Mon, Feb 05, 2024 at 08:18:05PM +0100, Pawe=C5=82 Owoc wrote:
>
> > > > +     { .compatible =3D "qca,spidev", .data =3D &spidev_of_check },
>
> > > No, this needs to correspond to the hardware being controlled via spi=
dev
> > > not to an implementation detail.  Any new compatibles also need to be
> > > documented.
>
> > The device for which I want to add compatibility is originally used in =
the
> > router and this is what the dts fragment looks like:
>
> >
> >       spi@3 {
> >         compatible =3D "qca,spidev";
> >         reg =3D <0x00>;
> >         spi-max-frequency =3D <0x16e3600>;
> >       };
> >     };
>
> > According to this commit, Qualcomm use this compatibility:
> > https://github.com/dissent1/msm-2/commit/d6160218393552fea1b7973787f2bd=
154f870ee2
>
> This is out of tree, it's not exactly a good guide for mainline.  The DT
> should describe the hardware, not how some particular software stack
> chooses to drive it.
>
Will changing from "spidev" to "qca4024" be enough?

> > > I'm also missing patch 2 of this series so don't know what's going on
> > > there.
>
> > The second patch was sent only to the devicetree bindings project:
> > https://lore.kernel.org/all/20240205191828.998783-1-frut3k7@gmail.com/
> > It's probably done wrong...
>
> You should send the bindings change along with the driver change, they
> usually get merged together.