Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp3068781rdb; Tue, 6 Feb 2024 06:26:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IEWA3pP6NxVLaPk/giR1ykyicrT6Cqrdom3ZnRCPMDLR6+DAUAkoq1Fvic6H0UJiGijjhLL X-Received: by 2002:a05:622a:5c9:b0:42c:2cad:5610 with SMTP id d9-20020a05622a05c900b0042c2cad5610mr2948040qtb.12.1707229602833; Tue, 06 Feb 2024 06:26:42 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707229602; cv=pass; d=google.com; s=arc-20160816; b=gugEFLdZuU4omZPGgHfEg7pnm3zt4ncq3tCsdJuaP1WIVNp24ikZlK/yULCDb9TOGO ITvWD8n5H9YvphZmyOU56hljXDYVVM69u+V9rcwJ/3kt4oEdBComUS38TddeJRa8GlI5 S4BXlFO3s0Ll3JdS2dy8CHW6deaRqDSje/PYqCCS5aG03cA7mDR13CvKB+167h8g5FnN Ucb8HlXdI8SNxpMYV5jzYvRzpP3F/7kv9jQmkKGstxAlUxm5Ki2307v+NVg9LZ0upA89 btxub96cfevc9SUPq41dKm1W2xOqMlNeRjBI8CaJ4WTw31qksVrfw5y23fywPNRPh/Qp GWpQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=v9k+wXSjFP1gf2hdsJ6BF7YhNnlmP4KyBwDgOaZfcbI=; fh=q73Qc1raFLdPgPu7fMgY6Tvlrai6FbaXanrct/SdcVQ=; b=SjXghKtuGE00I5iwHS7OpFu278wiu5rKWotbBEBMP0lqRk9do/BUmXhAFWsys9bsM+ pyJ2KJWQqRbODKv05uZ18rpvFY6HUN+inNlBEoYzVr3ZqtkQjbJl+TduUSxMFYaLTe1S A3j7rtEAb73fLQ90HfokgEcXqkoPpq4bWUAVZmkTT3QTOXapu5moOzrFpwrU3X3Yeu5s bV/qETipRQ3XP/aXh1DfK8RszSxAQq2He1E7DTTOi5h84PM+QURuYCFuBzbR1kd2ogIH TuE5F5wQctLDDpx3TispcIzFqmT+ZIYgziLdE/1QLyqinNzgigE9j5JAoXVxRQbo/ixu cBiQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=b7vrV39A; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-55108-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55108-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch X-Forwarded-Encrypted: i=1; AJvYcCVBcAVT+y7urLA4F4+hso12XaMaB7XoDOt4Sd4tQT/zXGS8eAf84Nwx3f1SoNvOMytMicxw4cTlLEMDZnNBRfP/g9EWx8wZHcRjUb7YAw== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id g11-20020ac87f4b000000b0042c1bc530e1si2453927qtk.624.2024.02.06.06.26.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 06:26:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-55108-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=b7vrV39A; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-55108-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55108-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 9453D1C22AE8 for ; Tue, 6 Feb 2024 14:26:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 20050132C39; Tue, 6 Feb 2024 14:26:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="b7vrV39A" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 901DB132C09; Tue, 6 Feb 2024 14:25:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707229561; cv=none; b=l60z6sr4oDVXCv2HmwJRhdWtpsgj78vKquZT09/0t2jFOLXgZrxKDX0l3N2/ON5tPXrz66QEJdw0RcwPqsHDFKUKdUSroldBGkoCyzyknUEG8xEHVvz98Mv+qnPmpIOozWRXK0fXvXAvn9jWJ1j62TYXnzUGtueKUFUY/IaVFx4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707229561; c=relaxed/simple; bh=5J1DHXhtJMQ4CbzsyxiP+MOl0UOFuDY+e2LH/+A+T00=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=StAGX7qCjC2gx5SierhdhSfmqdqbCySkt7njTfOSIEELTqSPEvpDMMllhLHiqvyPtRzO8pKMPQSoGBHGL/F/BAncZBvDR4sHRY9gPNkvTZJr6q8haq7VZWVSj4Myvo5O84CKlDE69Akty04+I9qowv+xaHWROKRrimI0BwRGoqM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=b7vrV39A; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=v9k+wXSjFP1gf2hdsJ6BF7YhNnlmP4KyBwDgOaZfcbI=; b=b7vrV39A71XHo6t/G+sJWupZJm Iaveyf5gWkytLfoRXY2yzy15yPlqA9DSPGb72mGmuMsrpJVQOSFtmPKx8LhiPF18kSZY4OHH51UfY EwS/sUZpA7wyPzfy4Z1N/rOUhayCf15zB7y6UHnKIqzkMnCAjluSKRxLreZtmgl61rks=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rXMOD-0078nm-UA; Tue, 06 Feb 2024 15:25:33 +0100 Date: Tue, 6 Feb 2024 15:25:33 +0100 From: Andrew Lunn To: Maxime Chevallier Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ariel Elior , Manish Chopra , Jesse Brandeburg , Tony Nguyen , linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org Subject: Re: [PATCH 7/8] net: intel: igb: Use linkmode helpers for EEE Message-ID: References: <20240204-keee-u32-cleanup-v1-0-fb6e08329d9a@lunn.ch> <20240204-keee-u32-cleanup-v1-7-fb6e08329d9a@lunn.ch> <20240206103425.28e64a8f@device-28.home> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240206103425.28e64a8f@device-28.home> > > - adv100m_eee = !!(edata->advertised_u32 & ADVERTISE_100_FULL); > > - adv1g_eee = !!(edata->advertised_u32 & ADVERTISE_1000_FULL); > > + adv100m_eee = linkmode_test_bit( > > + ETHTOOL_LINK_MODE_100baseT_Full_BIT, > > + edata->advertised); > > + adv1g_eee = linkmode_test_bit( > > + ETHTOOL_LINK_MODE_100baseT_Full_BIT, > > Probably a typo, I think it should be ETHTOOL_LINK_MODE_1000baseT_Full_BIT > here :) Yes, good catch. Thanks. Andrew --- pw-bot: cr