Received-SPF: pass (google.com: domain of linux-kernel+bounces-55142-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 6 Feb 2024 14:50:21 +0000
From: Greg KH <gregkh@linuxfoundation.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Wesley Cheng <quic_wcheng@quicinc.com>, srinivas.kandagatla@linaro.org,
	mathias.nyman@intel.com, perex@perex.cz, conor+dt@kernel.org,
	corbet@lwn.net, lgirdwood@gmail.com, andersson@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, Thinh.Nguyen@synopsys.com,
	broonie@kernel.org, bgoswami@quicinc.com, tiwai@suse.com,
	robh+dt@kernel.org, konrad.dybcio@linaro.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-sound@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, linux-doc@vger.kernel.org,
	alsa-devel@alsa-project.org
Subject: Re: [PATCH v13 32/53] ALSA: usb-audio: Check for support for
 requested audio format
Message-ID: <2024020617-limb-name-f852@gregkh>
References: <20240203023645.31105-1-quic_wcheng@quicinc.com>
 <20240203023645.31105-33-quic_wcheng@quicinc.com>
 <87wmrhvir7.wl-tiwai@suse.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87wmrhvir7.wl-tiwai@suse.de>

On Tue, Feb 06, 2024 at 02:12:44PM +0100, Takashi Iwai wrote:
> On Sat, 03 Feb 2024 03:36:24 +0100,
> Wesley Cheng wrote:
> > 
> > Allow for checks on a specific USB audio device to see if a requested PCM
> > format is supported.  This is needed for support when playback is
> > initiated by the ASoC USB backend path.
> > 
> > Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
> 
> Just cosmetic:
> 
> > +struct snd_usb_stream *snd_usb_find_suppported_substream(int card_idx,
> > +			struct snd_pcm_hw_params *params, int direction)
> > +{
> > +	struct snd_usb_audio *chip;
> > +	struct snd_usb_substream *subs;
> > +	struct snd_usb_stream *as;
> > +	const struct audioformat *fmt;
> > +
> > +	/*
> > +	 * Register mutex is held when populating and clearing usb_chip
> > +	 * array.
> > +	 */
> > +	mutex_lock(&register_mutex);
> > +	chip = usb_chip[card_idx];
> > +	if (!chip) {
> > +		mutex_unlock(&register_mutex);
> > +		return NULL;
> > +	}
> > +
> > +	if (enable[card_idx]) {
> > +		list_for_each_entry(as, &chip->pcm_list, list) {
> > +			subs = &as->substream[direction];
> > +			fmt = snd_usb_find_substream_format(subs, params);
> > +			if (fmt) {
> > +				mutex_unlock(&register_mutex);
> > +				return as;
> > +			}
> > +		}
> > +	}
> > +	mutex_unlock(&register_mutex);
> 
> I prefer having the single lock/unlock call pair, e.g.
> 
> 	struct snd_usb_stream *as, *ret;
> 
> 	ret = NULL;
> 	mutex_lock(&register_mutex);
> 	chip = usb_chip[card_idx];
> 	if (chip && enable[card_idx]) {
> 		list_for_each_entry(as, &chip->pcm_list, list) {
> 			subs = &as->substream[direction];
> 			if (snd_usb_find_substream_format(subs, params)) {
> 				ret = as;
> 				break;
> 			}
> 		}
> 	}
> 	mutex_unlock(&register_mutex);
> 	return ret;
> }
> 
> In this case, we shouldn't reuse "as" for the return value since it
> can be non-NULL after the loop end.

Why not just use guard(mutex) for this, making it all not an issue?

thanks,

greg k-h