Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp3084963rdb; Tue, 6 Feb 2024 06:53:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IGBzEri5km89Ap6YhzQJrPUgoULg51G+d+kqnfSR3Qbmq5Xix4L8khCp6AwxAWYa4iLrr5m X-Received: by 2002:a17:907:7e9b:b0:a38:4de9:1077 with SMTP id qb27-20020a1709077e9b00b00a384de91077mr474281ejc.7.1707231185221; Tue, 06 Feb 2024 06:53:05 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707231185; cv=pass; d=google.com; s=arc-20160816; b=B6m2Tq3VdpgZolRziaRVCikp02iWUfN/HE84ANtvIDjGWLrEajLUkd6KW7EBZcIQUQ DClo6ch7+CY7Tbrl6syAyVl+NblAhU47DGsRfqNEHlpSE8uuUenbRaUot8HIO9P9lkHg 2nL4KngWPgJzAIZ7JFnlfwvEr3qGbEVYveX/hJ0BITjNmuhJBm0PTuZkA3IzWX/I/DWK J/jLd2V1SM1mG+XCewIerOZX9lfZttJiQ5ZFyuLb51SfYhsAuFWZ3caJBsgi7d48yELv kHySheqiyRgRpayEZCLPra703yF3IZ2VwmQXGUWUIlXm+jZmGmaBNa6q9RbhzKMbFY+C pdVA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:feedback-id:dkim-signature:dkim-signature; bh=Fd2EgqbFxvtE/GJ2R79t8CbsMl7dcUlSu6Hik69SEuI=; fh=54ZZNnr1UlaQ1OfPE/Bk1BEGDCDF6aK9ozDbn173ifA=; b=gRBYeSuyPb55BUYhqLTjOxgyGFY9s+qD5MFFFUlnRM9ZbLQDghc4leTt9CZ5kJcDMf fc/lyuPi92RrlEvGOMHICv6O7JDIrxdbD7HSZOthj3VBo3DY/o9rGXbpB74E04os0B4E m+FFrvjuClZUvxlvbP6b3sMyV2d3wMMu9ROpdX1aMNS2ntMT92wqKBLXK0wrxlOMT1cc a/KmJMkZGcJnofCRAG0SOcHoP4nYTnk2CuZp1WrC2dBMtCQZS/62qCsPaOnnu5xEa2ma i9NQwi8+/KdUsOc2cgwzq0I7Pew3EeXQrttYTuOoLQ4P54pkqR6LIYsqIXiJLyd8cUcR z+YA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@tycho.pizza header.s=fm2 header.b=2hNU11hz; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=PxhQtply; arc=pass (i=1 spf=pass spfdomain=tycho.pizza dkim=pass dkdomain=tycho.pizza dkim=pass dkdomain=messagingengine.com); spf=pass (google.com: domain of linux-kernel+bounces-55145-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55145-linux.lists.archive=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=1; AJvYcCXwmIn9pLVsexuRB+2Rrkyw3HcCkGpiTcEJ+bnIGl9k3Q9g7RtHHWmmEmg8nB6mNru2V+xDj5JRb2Yi8335ZbJ9I9atpLkfR4q+f/aA5g== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id j11-20020a1709066dcb00b00a3814482d95si1025391ejt.329.2024.02.06.06.53.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 06:53:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-55145-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@tycho.pizza header.s=fm2 header.b=2hNU11hz; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=PxhQtply; arc=pass (i=1 spf=pass spfdomain=tycho.pizza dkim=pass dkdomain=tycho.pizza dkim=pass dkdomain=messagingengine.com); spf=pass (google.com: domain of linux-kernel+bounces-55145-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55145-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id F39871F26947 for ; Tue, 6 Feb 2024 14:53:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 607591332A0; Tue, 6 Feb 2024 14:52:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tycho.pizza header.i=@tycho.pizza header.b="2hNU11hz"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="PxhQtply" Received: from fhigh7-smtp.messagingengine.com (fhigh7-smtp.messagingengine.com [103.168.172.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20408131E53; Tue, 6 Feb 2024 14:52:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.158 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707231164; cv=none; b=FBMk2PVSUVsP/qmPphUFC6NmGaVrMKkXH0v740YSHrZwcpnyvsBA1keOhoy+Z6SkmhnlNrIiwzxkXQ8nb5rA3AURtN1WKsp+2MFGh70jlLhudyVbHc2WLd7YYqETe9hG9Ty23I9JGQ/4Ef80ECD5ry5dJcsmhxpndC5+hCEiSF0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707231164; c=relaxed/simple; bh=R/742LRkouuAuethox2x2vtIJsIKE4T+HK1LMPu93+s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VBCbwrF/FcxWrBFMQkgCLye6iAhYC3skKHEgsICaOJn0OZZvksV1oXDCCgVgv0hWSLmCkUzmDhkhd7VBK437oK4Cr3/Jtyk7XtL384QWrRfNp/UXnm4Pdvwaj4YoImx3RzOq0AQRx27mSGudNycEW/Nh2FNIqSRlThbqykktkno= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tycho.pizza; spf=pass smtp.mailfrom=tycho.pizza; dkim=pass (2048-bit key) header.d=tycho.pizza header.i=@tycho.pizza header.b=2hNU11hz; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=PxhQtply; arc=none smtp.client-ip=103.168.172.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tycho.pizza Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tycho.pizza Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 0DDF5114008D; Tue, 6 Feb 2024 09:52:41 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 06 Feb 2024 09:52:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tycho.pizza; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1707231161; x=1707317561; bh=Fd2EgqbFxv tE/GJ2R79t8CbsMl7dcUlSu6Hik69SEuI=; b=2hNU11hze/lK2HnZ81Yq+0e3X0 WzYn3FVaMIa8MOVt9PNrgJxS7KJ/VR+q+bTlfHfw0ZoAcaHapXgEDeMNnjq7nfyK Doa09EyBz+2cuF4H/uHe6I6C2Oum8CPQ/Kug75/foHx4h7aRgidAjpBmbw60lmdr 4QO5inVfGlDaX0aWe9qDiKAqb8RcsRIK5NFcZIRWTDAXD5ifRacv1IYYBWFwyLvz JD4x/UuKP4ECVVq9HIXl7WzpNFXa16afqWJyDZi8A1X5HBqxdb6/3Elarm7zQqhf yyjC27G9NVVb86aHVhOx0ML6l2AF2CxVI0xz5qig+kSFsqN1g0KWW9Ks7W5w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1707231161; x=1707317561; bh=Fd2EgqbFxvtE/GJ2R79t8CbsMl7d cUlSu6Hik69SEuI=; b=PxhQtplyTcojFzSGgmYlbpBx7uOUQyhGtdJG/0ttwfeO qUB2ekHR9YirbggSssgFSi3i1xTDho8n0hT4OMZDfVII9ps+yhIb8w5j8lG69FF1 J+/+GuRqOZnqiLwXEQqIPdqBnqT2e7h4EouoX9A+E7915tBLPVG8xvRuwWAxXSF3 O7sc8ukp/zA1EKA4N3tl0Vrsn8ObCpgi8lThdidM/NgC/fPGU9WwVZr+U/mbY2Fn 6Amak1Bl7cF6qxaiX+2F0cD4G1ZQDgUEo3808F//jI+y83oC8ycg19PWNW4ELmTT cuFtEg4MZtCC6twI91NOleCKhncYwVANcyv/vifaLw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrtddtgdegtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehttdortddttddvnecuhfhrohhmpefvhigthhho ucetnhguvghrshgvnhcuoehthigthhhosehthigthhhordhpihiiiigrqeenucggtffrrg htthgvrhhnpeelffekveduvefftdejkefhtefhgeduhffghfejtdehieevjedtkeejveej keeuieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hthigthhhosehthigthhhordhpihiiiigr X-ME-Proxy: Feedback-ID: i21f147d5:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 6 Feb 2024 09:52:39 -0500 (EST) Date: Tue, 6 Feb 2024 07:52:38 -0700 From: Tycho Andersen To: Oleg Nesterov Cc: Christian Brauner , Andy Lutomirski , "Eric W. Biederman" , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pidfd: clone: allow CLONE_THREAD | CLONE_PIDFD together Message-ID: References: <20240205145532.GA28823@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240205145532.GA28823@redhat.com> On Mon, Feb 05, 2024 at 03:55:32PM +0100, Oleg Nesterov wrote: > copy_process() just needs to pass PIDFD_THREAD to __pidfd_prepare() > if clone_flags & CLONE_THREAD. > > We can also add another CLONE_ flag (or perhaps reuse CLONE_DETACHED) > to enforce PIDFD_THREAD without CLONE_THREAD. > > Originally-from: Tycho Andersen Goes without saying I suppose, but, Reviewed-by: Tycho Andersen as well. Tycho