Received-SPF: pass (google.com: domain of linux-kernel+bounces-55170-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <7b472cb2-6658-446a-ae47-411d08798cca@wolfvision.net>
Date: Tue, 6 Feb 2024 16:05:15 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 6/7] ASoC: dt-bindings: xmos,xvf3500: add XMOS XVF3500
 voice processor
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Matthias Kaehlcke <mka@chromium.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
References: <20240206-onboard_xvf3500-v3-0-f85b04116688@wolfvision.net>
 <20240206-onboard_xvf3500-v3-6-f85b04116688@wolfvision.net>
 <ZcJDFi+iIQOWzgYw@finisterre.sirena.org.uk>
Content-Language: en-US
From: Javier Carrasco <javier.carrasco@wolfvision.net>
In-Reply-To: <ZcJDFi+iIQOWzgYw@finisterre.sirena.org.uk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VERoWUpzcUp6SStBcjRCQmRFL0MvdXRxcWxhcC82VFM3V2FMUVBDZTNLQnZ6?=
 =?utf-8?B?VDNlMEFlbWhzc0tac0ppVUtCdGhRbkNyZEZoN2U1MGhYRVBmZVhydmhGQ0Jn?=
 =?utf-8?B?aGxFWUJyQjhVOWp6T1FZdXZrZmFsRnVTUUVrQWNnRGU4WE9lc0U3eW1RcjVz?=
 =?utf-8?B?UGR4UjJzcGN4eGw4Z1J1UEFDTFh5UFJROFpGRmlScVU3WDF1V0REQS9DM0RI?=
 =?utf-8?B?QnlzaXJrMTVQUlh1T2x2ZXBMRHk3dmFnMXRFdllPQ2xhTkFOZlNtMnFuS29F?=
 =?utf-8?B?VEdoSHhnVkUrdmpvRDZoSyt1VzBCVEV1bGx6WjZyd2VwRXBoNmFSZVFHYUhO?=
 =?utf-8?B?WXNwNDFPdm5NZ2R3Q3BUM08rRFFHSFNqMXhDbkVQeUM1dWRka052am92UVJV?=
 =?utf-8?B?c1E3UVhNTytKeTlydlArYldRTTlyMmdMVXNKN2hHU0gwYWlDekJJUUI2S1Yr?=
 =?utf-8?B?YTJaNVU1elY1TEQ2OHdOYmNhNUd0b1k2YW9pWWtQMFVQY1dUZSt3eGluSFRn?=
 =?utf-8?B?RkFHVnIwYzBXRy9YMTBxVU9nRC96RHFiQWg3cEdmWHNRL3FnREhjMkRFRC81?=
 =?utf-8?B?UFJFVVlCZGw4S21nVmswZllHVWpLR1pFNW1XVzJ3TFFVR1paTXpBc092RkxY?=
 =?utf-8?B?dG9BQitEbzhIMkRnVzI3dzUrREdDT3Z0cnZzajNOY3R6ZHkyOENpdUI4Z0ZZ?=
 =?utf-8?B?YVlnRzVFaEt5cElYMHZwWGpOdk1SODZpT0FSakQ2U3Q5Vi9Sd3UrbEJOUVg2?=
 =?utf-8?B?dllXYjlXM1Y0ejQ4Y1M5U1czU1FMNGZncHRBdEZweEw4bnFoVHZZeTBpMm1J?=
 =?utf-8?B?UzIzSTZDejJObUpaRDkzR3BMbkNrdVJWZlVQNUM2eFFoc0ErWjlOWGNVZGti?=
 =?utf-8?B?YkZnSUo0aVR4VVRzSFVpSFo5c1NxeVFXb09vRlJFa1lNVThkOE1HQVR3MHZC?=
 =?utf-8?B?UjU0NnVGM0lkK3VWbERDa0tRL2ROL1ZJYmcyOVRyQkdXTDZRU1V2Z0xRZ3Jh?=
 =?utf-8?B?Z29hblhHcjN6TFlRS3JzNjJwUFppV29wVzdQUVIzYmoydm9hNE9CUFRYVGJB?=
 =?utf-8?B?MXhoOFI3SHZyNmZPT21JMGtvcEhFTVVYOVJXNDN1dTI5S3FRbDFSSmd6ckRB?=
 =?utf-8?B?Rnl5Y3h1UytnQ2FrcmtzQmtiU3F5WFduT1hHenQvcGwyS1FwZnVUR25XUTdT?=
 =?utf-8?B?N0czM0tNTVJuSDZlMTFURndtdHVmcVowVXBtMURoS1UrUm5telo2Y1lxZGx2?=
 =?utf-8?B?eDNqUDh4YU9JOXFacEJ0QTZFdEZuVWxndXg1YTVlc3JXWUFxdUZZenlKYnhV?=
 =?utf-8?B?RklKMmRvU3pTVnlIRHE0UDhvaXpDYUozaWJZbVNZUGNGazNPSmZKOEg0Nzdy?=
 =?utf-8?B?cE5PYjNKdjlRc1VjL3d0UFViQ0JQbi80VG5BYjZkd1VXZHVYK2QvaGZtd2NQ?=
 =?utf-8?B?dWo3UTVPUWJoTkVLYWVoV0dxTlZkbVBFSWcyL295ejlQUE1lZ0wzSFdKMjha?=
 =?utf-8?B?NFNEeVZkU3grVW9NcWNyNjNDWHh4dU90OC9kYWN2Ri9FcXU5NFB2YWFjTWxT?=
 =?utf-8?B?dGFIY1BicCt1QTZOL0ZubjNUTzMvQ012K1JPOXRTVVIwTi80UXlRVGNYZUZW?=
 =?utf-8?B?aHRCSC9VbHpDK3I3VjRWc2JkVWZSNHNSQ3hMVXJBK0hiL3dtRmlyMmJDM3I4?=
 =?utf-8?B?MlVySVkydDYzbXJCemlkbVN1T3F4WGZjZTlMRE5IL3ZEVDVTYkYwWjZGanV1?=
 =?utf-8?B?Z1d4Y2VhQm1xU1VHdVpaWVQ5OGNlK1F3ZXNsMnZGU3Z1ZkhLbTBDb3IweURq?=
 =?utf-8?B?MnJBQTlKQnI2Z2RDV1ZNa1RTbjA5TnRiN0R6K1pvN0R3bTJGQ2dLaDM2MWE1?=
 =?utf-8?B?WEREN3VnNklreFFCNS8xQmEvVGN5TU1GSzlmN3FjblJRTHo5bnFsTGhXOWtp?=
 =?utf-8?B?eU1qa082c3ZJTlVhQVUxaE1Fc3JKZFFNcFRqWUZOZDNLQ0pDekxCWWZtU1Np?=
 =?utf-8?B?N1dTYW1QWkY2SmJQWk5JQTQ2VG83RHFYWm84R3lML0thd3gyOVdNS1JYcVY0?=
 =?utf-8?B?U2NsV0tEUTJFbkkrZi8xT0I2aVkwYzQ5ZStiOVB5RVhOY0RRQnF6VEFZZGVQ?=
 =?utf-8?B?QzNpZFJ2VkpxR0piS0NxcDAzMzJqSVlSd20wN0tOd1JQUDcvQ2dZK29vYmRD?=
 =?utf-8?Q?RlHANYBQNmXo+i/kkwYTI10=3D?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 8216a4c3-a3a1-431d-93fa-08dc27250780
X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4974.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2024 15:05:17.4151
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tW7Gy416mRZWfTQiNTqkU9lyeGS7JchMzpIsxsH8Al0tV1bu0vRnYV1ZO3JXkOqrfQ3e8C4Y68JHHSee+wCjQKqlG3v1pzDU7JkYwkvQCsQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA6PR08MB10443

On 06.02.24 15:32, Mark Brown wrote:
> On Tue, Feb 06, 2024 at 02:59:34PM +0100, Javier Carrasco wrote:
> 
>> The XMOS XVF3500 VocalFusion Voice Processor[1] is a low-latency, 32-bit
>> multicore controller for voice processing.
> 
> Acked-by: Mark Brown <broonie@kernel.org>
> 
> though...
> 
>> +  vdd-supply:
>> +    description:
>> +      Regulator for the 1V0 supply.
>> +
>> +  vdd2-supply:
>> +    description:
>> +      Regulator for the 3V3 supply.
> 
> ...it's a bit weird that the supplies are named like this, usually
> there'd be some sort of meaningful name (even if it's just VDD_1V0 and
> VDD_3V3 or something).  Are you sure these are the actual names?

The names in the datasheet are vdd for the 1V0 supply and vddio for the
3V3 supply. I named the latter vdd2 instead because this device does not
have its own driver and instead it uses the onboard_usb_hub generic
driver, where the supplies are named vdd and vdd2.

Those are the names used for devm_regulator_bulk_get(). Is that not the
right way to match them?

Thank you and best regards,
Javier Carrasco