Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp3112811rdb; Tue, 6 Feb 2024 07:32:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IGWvPLCb7rIfRVbRMOutO1LbihHfuGgs7/qCc7YcCEwyQixk8M0qg7ynwP2yXgjHgovwyce X-Received: by 2002:a62:d113:0:b0:6de:1cae:a53b with SMTP id z19-20020a62d113000000b006de1caea53bmr2435226pfg.8.1707233535687; Tue, 06 Feb 2024 07:32:15 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707233535; cv=pass; d=google.com; s=arc-20160816; b=QC+L3EjKz3+bzEC0uAnj+FnPJ2+CSi/3PppJGENfnkkBgaKbCRTvMIg55fUPskCLzq r5LhFUUOgEBRAmO0vf8rKia8qBABoY4fd2P/8LjD598FnmfRqdGBHXIWFpoDAP9V7wft xSv+9kF7EjKXYs/Lig4ndwiLR9VXADLWcycVJGADNutkRw9ttqHj/pyq+jsxBL55PjYo 0bsqS7wgUNTCj44iYQEQFPC++XmRaIIaIqiWHAhrtDO+1A3jfspl4N+l4CccyCDs+Kyy qMSUCYSWYxeTooa/Og8hsfqjQrC7rezq1W42ai+rVl707RtWU0WTdglzt+g6DLrk1lVJ 1dwg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:subject:cc:to:from :date:dkim-signature; bh=RJx+G1wVIpoDp54UknuGNZ6MibUT5pY6iL9LNpYAWVs=; fh=i6nLNeK9NnGQX+75CSHdaj8ottNlF7/xqnFf7odI1X8=; b=u9zJekVEm2f9mavO2QCAKBylniBWMPeo6hiVcEs3fxxpDFUs1mmy7KrK71kkypPOnK edUjq7MeyKLptlDQ/IdvjSSA1U26DpPWPpk0HjTikqddvs6CBLj4WnG6t81tzXjr/sBo mHEZOME01LduFT2IQ9onuO+gW7NcXN8bD+F2fF5zLT2nGb51YMGjSN0r48dtNVfJsCpx dNLm32TwjNKFBOws/xz4QxZiLLYaNTfUOJoPvldv2hlz+MrcJ0kl2ti5zrJMOeetC60W KeCZ4eTQVPwwwKuaf9qt5RD9rLpIeQ25n8A0Zl3JHbP5QruzoqoWrgDAfYu8ZrM9JUZE lwQg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XB8r44SO; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-55243-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55243-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=1; AJvYcCWhGgEWces7LeCuUJflGSDrkv6uJF5TMQJbjVfGMe9VV1/PTOSbI6diKnPCDyr8jrdNETn/4iTbfgQTVNGgXw8xsDunIwCif50IjUHglg== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id h20-20020a63e154000000b005d8b7c3a02bsi1896385pgk.175.2024.02.06.07.32.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 07:32:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-55243-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XB8r44SO; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-55243-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55243-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 585C5293252 for ; Tue, 6 Feb 2024 15:32:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2FD9313342F; Tue, 6 Feb 2024 15:32:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XB8r44SO" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A99E132C3E; Tue, 6 Feb 2024 15:32:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707233527; cv=none; b=PbRylqqvs34VMjjpAId6xBoMfnjs1e/sS14TK9oX+g1h2PjZctx6nL4UGeslVUjsyVB7glqmjetSeO4ZKZ5pkf0k3FqIXFv7N3wUWuf5AV9/8VC3uf4LM2cH/hpmXDIfIH0Khci/B1ePy847IcYUIWIwdfOIqfMr4Je+wfedFK8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707233527; c=relaxed/simple; bh=adqj0rvLx6dUnNPm8VQXCTdQ6CPnE2MNoTeYzdrXCCw=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=QceH9ciakGkXRh0yHWr/NNoVAgoONI1BH51e0XeSB5QADNnp0NQmjMIFf4+G+DwSBuf+mAnUqkRQ1OnaGHUoOERPgbwcRb5mmaI7y+ZnbMyhN/hbuzUg83ckp3eLNe8C2FG6jn94feK3gOdZXEEBCaaxfBIfpjjiKf6LcSuCI5I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XB8r44SO; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5BA45C433C7; Tue, 6 Feb 2024 15:32:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707233526; bh=adqj0rvLx6dUnNPm8VQXCTdQ6CPnE2MNoTeYzdrXCCw=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=XB8r44SOOA7MhA2w0L/9UHK7PDUNke/XV4Gohw3i2Zm5z94RzlBoGTgJ9NkTjctnP /fINxugc8LjwhikLCfMn/Na19KVn8KMcDNwCRUCZTjqm5oitjMg+IKq0UTk+pbJuwQ qbPMdbp5FYu2bE6sm7NvA9Xe7S04T34a5p6npttT31BG2X+XtyrFRypIAEv1yBjR13 TtCfljU9hZMjACnPKGQ3p/H0h7ozT2U+ETIPiTLbxpoJRHIAHVoBkRPGouDNJmmcCI L2kfAqC526nqiUUNEbxsxB0DdAO+ZR4j7lsHUfgf0bfus3TNctfPKN3bZmcu0Emrhi bRBiU/l2rJ/ug== Date: Tue, 6 Feb 2024 09:32:04 -0600 From: Bjorn Helgaas To: Onkarnarth Cc: rafael@kernel.org, lenb@kernel.org, bhelgaas@google.com, viresh.kumar@linaro.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, r.thapliyal@samsung.com, maninder1.s@samsung.com Subject: Re: [PATCH 1/2] drivers: acpi: use %pe for better readability of errors while printing Message-ID: <20240206153204.GA866166@bhelgaas> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240206051120.4173475-1-onkarnath.1@samsung.com> On Tue, Feb 06, 2024 at 10:41:19AM +0530, Onkarnarth wrote: > From: Onkarnath > > As %pe is already introduced, its better to use it inplace of (%ld) for > printing errors in logs. It would enhance redability of logs. s/its/it's/ s/inplace/in place/ s/redability/readability/ In the subject line, run "git log --oneline drivers/acpi" and pick something that fits with the history instead of just encoding the file path. Same for the sched patch. Bjorn