Received-SPF: pass (google.com: domain of linux-kernel+bounces-55251-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 6 Feb 2024 15:35:44 +0000
From: Mark Brown <broonie@kernel.org>
To: Javier Carrasco <javier.carrasco@wolfvision.net>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Matthias Kaehlcke <mka@chromium.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v3 6/7] ASoC: dt-bindings: xmos,xvf3500: add XMOS XVF3500
 voice processor
Message-ID: <ZcJR0LrwaS5GAf5h@finisterre.sirena.org.uk>
References: <20240206-onboard_xvf3500-v3-0-f85b04116688@wolfvision.net>
 <20240206-onboard_xvf3500-v3-6-f85b04116688@wolfvision.net>
 <ZcJDFi+iIQOWzgYw@finisterre.sirena.org.uk>
 <7b472cb2-6658-446a-ae47-411d08798cca@wolfvision.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="yHkGcuLiRp18RW+b"
Content-Disposition: inline
In-Reply-To: <7b472cb2-6658-446a-ae47-411d08798cca@wolfvision.net>


--yHkGcuLiRp18RW+b
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Feb 06, 2024 at 04:05:15PM +0100, Javier Carrasco wrote:

> The names in the datasheet are vdd for the 1V0 supply and vddio for the
> 3V3 supply. I named the latter vdd2 instead because this device does not
> have its own driver and instead it uses the onboard_usb_hub generic
> driver, where the supplies are named vdd and vdd2.

> Those are the names used for devm_regulator_bulk_get(). Is that not the
> right way to match them?

The binding should really use vddio instead of vdd2 but if that's an
existing binding then it gets more annoying, probably that existing
binding is wrong too since vddio does sound like an entirely plausible
standard name for a 3.3V supply. :/  At the very least the binding
should document the weird mapping, though ideally the driver would be
tought to request names matching the datasheet if the compatible is the
one for this device.  Doing the better naming might be too much hassle
though.

--yHkGcuLiRp18RW+b
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmXCUcsACgkQJNaLcl1U
h9DpOQf/e2VJ3sICtCkXqELdceSjZb2aBilKyDRW+yrS9zM+XjePLiGl0BCmvQCo
9xKfaleXD/fevcqAQKlB1JelXF2reqrMZ6zG0eFPXXXEPsLuCj5eHgGrP3hnRrTK
Y8r3GXf5L7FdtB4hm3IOZu+1tEKOhJCAGpSEXgKsSheE0sTCDl7OzE6mwDJCRAR5
1Ewbd9va+gUBu9y8k7UjWvqDvRX0uxmxw3Ducq7QM74MjysXrwBIwk0Fz3WOqUUK
VxMDwpa7jySK0g9bisyhlZxnTtO9nKyOfAB+4IbiaECQ1yW/5TeJvD04kh9fgdts
it0qrPmYBtvT5+nR/fdydnBAe4YEUA==
=CAS2
-----END PGP SIGNATURE-----

--yHkGcuLiRp18RW+b--