Received-SPF: pass (google.com: domain of linux-kernel+bounces-55235-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 6 Feb 2024 10:22:58 -0500
From: Frank Li <Frank.li@nxp.com>
To: Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc: alexandre.belloni@bootlin.com, conor.culhane@silvaco.com,
	devicetree@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	imx@lists.linux.dev, Jiri Slaby <jirislaby@kernel.org>,
	joe@perches.com, krzysztof.kozlowski+dt@linaro.org,
	krzysztof.kozlowski@linaro.org, linux-i3c@lists.infradead.org,
	LKML <linux-kernel@vger.kernel.org>,
	linux-serial <linux-serial@vger.kernel.org>,
	miquel.raynal@bootlin.com, robh@kernel.org,
	zbigniew.lukwinski@linux.intel.com
Subject: Re: [PATCH v7 6/8] i3c: target: func: add tty driver
Message-ID: <ZcJO0u8rKgrIH4k8@lizhi-Precision-Tower-5810>
References: <20240205233326.552576-1-Frank.Li@nxp.com>
 <20240205233326.552576-7-Frank.Li@nxp.com>
 <9b5bb389-4238-0a32-5e16-3c62ea6c00e7@linux.intel.com>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <9b5bb389-4238-0a32-5e16-3c62ea6c00e7@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?iso-8859-1?Q?UfXdN5IgbIHYjHGFrHxTAjTZK/ics5mdUtfmdNiMkDs561BWuNXhXtuoFF?=
 =?iso-8859-1?Q?7Py/2GsdKFnIbXC7QW0UF9YJmhwBTzdQwWOms3lVrVuoufDhmsa3zT3/+k?=
 =?iso-8859-1?Q?whMZJAxc4KtmZcXgokZw5vuQKWmE7jKSTvsbG20MJnpSLvhg1lvIDtKGul?=
 =?iso-8859-1?Q?emSr/7v74NJOUL6qpgoOes7qq70+h5KQaeD1fPSC9tCstwIsAYwZ5H5FC6?=
 =?iso-8859-1?Q?eZBuJu/rJUt1Q0UfYVDgpcVcexKq5e5NmcrbvpKyBdwMS2i7xxaRuQPWPh?=
 =?iso-8859-1?Q?Ph4F4kB6hF7YmTB5vJTFd5g2B4o/dDS8P9D9SK63+GS+6jE18tVnojSKvZ?=
 =?iso-8859-1?Q?rCBkpxhZ5qbwxkt13CoiJFTkpL9DjnKrC/cKzjoxRIj0XHAoJc7zpl0mA0?=
 =?iso-8859-1?Q?Wr4VTwvQsH908uI+xbODAQ+oi1fT1w545COopJyHulUH/YbS/dvH7WfJTq?=
 =?iso-8859-1?Q?ocbleyuE7SIrYbRCMZlEoDyLE1aEAJxUmLX5vAsHxcJX7JD3KXPKS+XQb8?=
 =?iso-8859-1?Q?LvxA9UgqKsFw3Jz4vZWkSSqpCqGlA0vivilWctp85THkLpF/zTE0SGeKZ3?=
 =?iso-8859-1?Q?COkaDk8fu9CeKBEAD0zi2YqaRC91rRlkL05gw98sd0h8MjWovVjR6rB7Wx?=
 =?iso-8859-1?Q?WBMTPtQo93D/poASucllwdTT5n6UfrzKbFSfw3LLi5U6y7PytTnSXQVp/E?=
 =?iso-8859-1?Q?a1sXPjDcDvoo+llD+5AxN6Axb8CMEFu2hj6gv0DnkMdJj9Gk7gCEQX4umZ?=
 =?iso-8859-1?Q?2Jh/03XZtc/+1Z0TVyR8/dFKoHNA/roJab26Spw0DVkiDqSeHM4BKNVFfw?=
 =?iso-8859-1?Q?Ub6Qv4DpH6E5MANnFz8LX7ZLjahlu/jZBg23H96mqZypCqDYymS5iaW/V4?=
 =?iso-8859-1?Q?wwAV90Xnd3AaOXhEp0NZ+mDcOQB79VpoznmZs0YXtqpsPD7MYqUozKKRBC?=
 =?iso-8859-1?Q?hs0PbiwI5p0m0nT4KjdXK2WvSlpNmMx63n6zVwl5tCjXtVz1+LpeGpu2QR?=
 =?iso-8859-1?Q?o0L67bVpdtP+jDXWVyDWOS19R3RYHtNZJa1klUGJkSRMZd9+kDdwTv9Sp3?=
 =?iso-8859-1?Q?+r+Q5Hq6gbkTL+komr3IgR1WfoOS3BmwULJW+Fbc+5TJmGW5gdY2BMghdk?=
 =?iso-8859-1?Q?P3xoraGZ5ifk9sxnJvWaOrVmf+TyyCFQQSZnxPaQXuJ2CNQZYSpm202e6E?=
 =?iso-8859-1?Q?RG7QmjTW+Ux+m1iJEhBr+QOtkLAgMkNvvU7/F3FStxI7b2huPrR8qp2Wlb?=
 =?iso-8859-1?Q?XnsDu1R/QQjX9pV+kHn7IunyxZKvDyurY66sYBJzXZak5vj/xfoPKU4X0z?=
 =?iso-8859-1?Q?btGV+ciu+Lz34h65nfV3RVBXm/rlmHcz80bdWEdNVXttpiKw0uAWfq27u+?=
 =?iso-8859-1?Q?HGTvaUxIGPreJLj7bjb6hgjvC6bWeQBS0WY/Mzf+WTZ2RH6lbDhir9YJbq?=
 =?iso-8859-1?Q?FKbZoMwWSp2EothIRyb4+KuS0L1vR4bkxVyHjj05rV+znlLmA42/KlDEAG?=
 =?iso-8859-1?Q?DgmvnoC52qNCmVo+X44ZtLPJcb35NPj1C9SOiWsuzkHafRL/32iHGF6LoN?=
 =?iso-8859-1?Q?yKZWIJPmzobrVORIfYYP9n99bEdoaBXVC2EQVkegTlwFT6KmW+iivRIods?=
 =?iso-8859-1?Q?g0EG4Bazy5jUFlXnjK07a1GrFaPtCWG14Q?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 884cfaad-1066-44d7-abfa-08dc272784e9
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2024 15:23:06.8389
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7NJpFkVIWPU6OndC7OYzLjQVmSj56ZHRqG3wxM4scO15JWk7VxnVwW3h2GYjOr4aB6T14/YAXnzSE3kSs/4BKg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8882

On Tue, Feb 06, 2024 at 01:54:42PM +0200, Ilpo J?rvinen wrote:
> On Mon, 5 Feb 2024, Frank Li wrote:
> 
> > Add tty over I3C target function driver.
> > 
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > 
> > Notes:
> >     Change from v4 to v5
> >     - remove void*
> >     - include bitfield.h
> >     - remove extra ()
> >     - oneline for struct ttyi3c_port *sport
> > 
> >  drivers/i3c/Kconfig       |   3 +
> >  drivers/i3c/Makefile      |   1 +
> >  drivers/i3c/func/Kconfig  |   9 +
> >  drivers/i3c/func/Makefile |   3 +
> >  drivers/i3c/func/tty.c    | 474 ++++++++++++++++++++++++++++++++++++++
> >  5 files changed, 490 insertions(+)
> >  create mode 100644 drivers/i3c/func/Kconfig
> >  create mode 100644 drivers/i3c/func/Makefile
> >  create mode 100644 drivers/i3c/func/tty.c
> > 
> > diff --git a/drivers/i3c/Kconfig b/drivers/i3c/Kconfig
> > index d59a7eb83d13a..fca808cda87b3 100644
> > --- a/drivers/i3c/Kconfig
> > +++ b/drivers/i3c/Kconfig
> > @@ -48,3 +48,6 @@ config I3C_TARGET_CONFIGFS
> >  	  the target function and used to bind the function with a target
> >  	  controller.
> >  
> > +if I3C_TARGET
> > +source "drivers/i3c/func/Kconfig"
> > +endif # I3C_TARGET
> > diff --git a/drivers/i3c/Makefile b/drivers/i3c/Makefile
> > index c275aeae8970c..11f026d6876fe 100644
> > --- a/drivers/i3c/Makefile
> > +++ b/drivers/i3c/Makefile
> > @@ -4,3 +4,4 @@ obj-$(CONFIG_I3C)		+= i3c.o
> >  obj-$(CONFIG_I3C_TARGET)                += target.o
> >  obj-$(CONFIG_I3C_TARGET_CONFIGFS)       += i3c-cfs.o
> >  obj-$(CONFIG_I3C)		+= master/
> > +obj-$(CONFIG_I3C_TARGET)	+= func/
> > diff --git a/drivers/i3c/func/Kconfig b/drivers/i3c/func/Kconfig
> > new file mode 100644
> > index 0000000000000..7115129eb7d5a
> > --- /dev/null
> > +++ b/drivers/i3c/func/Kconfig
> > @@ -0,0 +1,9 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +
> > +config I3C_TARGET_FUNC_TTY
> > +	tristate "I3C target tty driver"
> > +	depends on I3C_TARGET
> > +	help
> > +	  I3C Target TTY Function Driver.
> > +
> > +	  General TTY over I3C target controller function drivers.
> > diff --git a/drivers/i3c/func/Makefile b/drivers/i3c/func/Makefile
> > new file mode 100644
> > index 0000000000000..16b3b9301496b
> > --- /dev/null
> > +++ b/drivers/i3c/func/Makefile
> > @@ -0,0 +1,3 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +
> > +obj-$(CONFIG_I3C_TARGET_FUNC_TTY)              += tty.o
> > diff --git a/drivers/i3c/func/tty.c b/drivers/i3c/func/tty.c
> > new file mode 100644
> > index 0000000000000..50673bfb6a003
> > --- /dev/null
> > +++ b/drivers/i3c/func/tty.c
> > @@ -0,0 +1,474 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright (C) 2023 NXP
> > + * Author: Frank Li <Frank.Li@nxp.com>
> > + */
> > +
> > +#include <linux/bitfield.h>
> > +#include <linux/iopoll.h>
> > +#include <linux/i3c/target.h>
> > +#include <linux/serial_core.h>
> > +#include <linux/slab.h>
> > +#include <linux/tty_flip.h>
> > +
> > +static DEFINE_IDR(i3c_tty_minors);
> > +
> > +static struct tty_driver *i3c_tty_driver;
> > +
> > +#define I3C_TTY_MINORS		8
> > +
> > +#define I3C_TX_NOEMPTY		BIT(0)
> > +#define I3C_TTY_TRANS_SIZE	16
> > +#define I3C_TTY_IBI_TX		BIT(0)
> 
> This is #include <linux/bits.h>
> 
> ...which will include <vdso/bits.h> that contains the actual definition.
> 
> #include <bitfield.h> is for FIELD_GET/PREP(), etc.
> 
> > +struct ttyi3c_port {
> > +	struct tty_port port;
> > +	int minor;
> > +	struct i3c_target_func *i3cdev;
> > +	struct completion txcomplete;
> > +	spinlock_t xlock;
> > +	void *buffer;
> > +	struct work_struct work;
> 
> This file seems to also lack some includes. Please go through your 
> #include in the series and add those you use.

Do you have tools to check?  It is easy to missed some header files.

Frank

> 
> -- 
>  i.
>