Received-SPF: pass (google.com: domain of linux-kernel+bounces-55253-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <42106e0c-109c-4ba2-a703-f95df92db5e3@wolfvision.net>
Date: Tue, 6 Feb 2024 16:35:54 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 6/7] ASoC: dt-bindings: xmos,xvf3500: add XMOS XVF3500
 voice processor
Content-Language: en-US
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>,
 Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
References: <20240206-onboard_xvf3500-v3-0-f85b04116688@wolfvision.net>
 <20240206-onboard_xvf3500-v3-6-f85b04116688@wolfvision.net>
 <ZcJDFi+iIQOWzgYw@finisterre.sirena.org.uk>
 <7b472cb2-6658-446a-ae47-411d08798cca@wolfvision.net>
 <ZcJOrvmbukDubcuM@google.com>
From: Javier Carrasco <javier.carrasco@wolfvision.net>
In-Reply-To: <ZcJOrvmbukDubcuM@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?b1RiTUttTWNYbUJCLzVybWJYQVhoaU53dXJjd0ZCNkwvS2QvSkJ3TWJhK0w0?=
 =?utf-8?B?cWtxL2s3SFdrQldTUDljY29uN3M0SENvay9zSm9UbG9oMnZwYjAxRXBRdjlx?=
 =?utf-8?B?NUdXZ3ZkZ2NMeGEvTEwzZ2NnZUVnd3E2LzkzWWhEaUd4Z21JWS8wZGgvU2Jh?=
 =?utf-8?B?a3ZzTHJlbmIvUitXa0lGSlhhYmtSOWNBeHIvYXpsYmVsWFV4bUNZbEpDYUlL?=
 =?utf-8?B?bDFVbU9aMko4MkNQaU9oaGVJSlBUTi9Pci9od2ZKbTZmSGs4MTFCajNxUVZo?=
 =?utf-8?B?R2tXVmIvL3F0UzdmSUdteFEzcFlXcFBaU09PMGFHRlpTZ21kVktSQzVOS2FB?=
 =?utf-8?B?djhwWHRQZklhaGlLOGFlZmF1Sm9nLzJtc2VMMWEwWit0Rko5YzhrSktwOTQy?=
 =?utf-8?B?VS9hMytWNHZrZllTMWZGZTNNa1RxbCtIQ2gzNGNmUXFmaHEvU1YvNjJWSXph?=
 =?utf-8?B?dWtnTTZVMmZuTXQva095SWxrUm5PNU1uR1d5U2JuUWJOTmx4aFBlcDZhWUtl?=
 =?utf-8?B?SmRkQm0rRnN3ak82SW8yT2lSUUczTy9UeHE4UjN5ZEdTQnRYYVZydnE3TUJt?=
 =?utf-8?B?akU4NzQwSnlGZnV5dERpZ3o1c2tFSTdzTDZUb3dDU0hSWmRSb1QzeEdadWxi?=
 =?utf-8?B?ZkFRaVBHeXJxdVQ1RGY5NFU5WXBvRVlXM2tSdzF5MXJsUllFN2t3ZGJ5bTVo?=
 =?utf-8?B?UmlyRVNLa1FYL1JsSEpxU1JSd29CRE5wUVdnVlV6TTJWcFVKaUF3b3JJQ2Rt?=
 =?utf-8?B?NWNvRVZsRCtUT0ZxUEV2Y1VqOUZMWFdhUXM3UzJncjNRT3d0V05IZUNmK3FF?=
 =?utf-8?B?Mnk5MHVXdU5VMGxVZnlFS2ZQdEl2MnRBTk5CWW5TNnZmRnkzZ2s5Zzg4Q2pR?=
 =?utf-8?B?NEVaQ3JFWEYyWVZQaUpTaXV3Mjd0Qi9SVlRVTmVsLzl0V2ZqNFFFZ0Y5ZkIv?=
 =?utf-8?B?THJsUFZpWGhXaWh4OWxNL3NBajRrVWhCTDlyTWxHTkVsRGVvNWRNRXVmNTgz?=
 =?utf-8?B?VHFURVpnNnpnZStUcml1VmlNTlYyT2JuY2trTStPWDAwbExtU0xmbnh3aXhI?=
 =?utf-8?B?LzlkZGlzdmJQRS9ZY3MxTW45Q2ZuSVdWVkg1YXRkeHUyYjhzUE5OeDcxbkJV?=
 =?utf-8?B?am9QdSs1UC8xSlZmZEd2SGtJSTgxNmRIbEl6R1J0Q1FUM3l3UTAzMHZ3a292?=
 =?utf-8?B?ZEJ3K29DSzNhU3NKV2JtdzF1Mmh6WmpaenRIa0k2d0VnVWxnKyttQnlBRmIw?=
 =?utf-8?B?MVhWVUQ5Mjd2dEh6VS80R2ZYNHJteVBweDlUS04vVVVpV0pkWWFBdHdleVNm?=
 =?utf-8?B?aTVRK3NKTzlzeWxFL1BHT09xUC9FcGFZb1dFS0pvcXIyWDQwUVc3L2pua2dZ?=
 =?utf-8?B?QTQ0amxwT0xFUnN3eks5ZVJNMTdOb3dScmZuc0Z5aHVLN2laZUdRZG9TWDZ2?=
 =?utf-8?B?clMwajJYRTFPREtDUHJDYzlkSEpYYjFsZzFxelFhSllrTUZ5bTdMVU5Tc21p?=
 =?utf-8?B?S0htcUxUM2tOTXI5QWZHUm0rTGhsVmlGb0Zvb25zUFA1VzJoWUYvYXVaTVBq?=
 =?utf-8?B?bmEvY2VxME83Zk9NSmtxeWNZOXM3ZXJKdi8rUE10TWEzMVlpY2FqdnJqbUcw?=
 =?utf-8?B?bkhjTGRjaVBFMGpIVnZtVzczdXhnVkZMWlR1bVQxVFUrVHF6WDlZRmkyRERU?=
 =?utf-8?B?NEpYUWRqZXI4djV3Q3dOdmt2WTVqY0FNTnZ2NVk0d1A4THI4YnlaS0JoSEVW?=
 =?utf-8?B?WURYaS9yZDdCMkY1cnVwVTNCNCs0ZmVvTVg3U3laOVRXNGVXTGE0TVRNYiti?=
 =?utf-8?B?N1loTDBkWEhxeGJ5VlExdnozUVpRaVpHZ0VHQU1qMnRiclVkMDZ4Y0xHMkh2?=
 =?utf-8?B?UThiV1ZyMWRERWR6YzBralRYUUVMc3VEM1ExTFZFeDBidDZDU1hvMGE4YTlm?=
 =?utf-8?B?a0wxL2hrcVVkazJTeC9tZUJIOVhmamh6RG1rY0xrVlRlMXBnTk1ENHNuWFJV?=
 =?utf-8?B?VzRaRS9pSlpQY3EyWkhRNlRTR3RsbElpeUR1VzFWYnE1dkVpbWtDWnQrb3JC?=
 =?utf-8?B?TW5jOG12VEx3OU12K0RhRUd1ZWxjeU1lVjFNd0MrcytOZ09MZ3hrQnl2SVZP?=
 =?utf-8?B?elZELytQY0ZNYmkzaVE1aEphN0ZpbEhRaUZqQ2wyL2crS3VhY1pUNVJ4V3Yy?=
 =?utf-8?Q?cJlpgkd6KcKg5u2t+tJ8uXU=3D?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 59b22ff2-526f-4dc2-0ddd-08dc27294f83
X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4974.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2024 15:35:56.2156
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: r/zKdW8cfX4AVq7E21+qUA3PeOUfv4sb466ImvBId3f022wDIhXuJxVa1C+ir8tWfkcdrLjWq5HVIg3v+DO4pSx7XFuUnGngt3FGAWAYfdI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB10763

On 06.02.24 16:22, Matthias Kaehlcke wrote:
> On Tue, Feb 06, 2024 at 04:05:15PM +0100, Javier Carrasco wrote:
>> On 06.02.24 15:32, Mark Brown wrote:
>>> On Tue, Feb 06, 2024 at 02:59:34PM +0100, Javier Carrasco wrote:
>>>
>>>> The XMOS XVF3500 VocalFusion Voice Processor[1] is a low-latency, 32-bit
>>>> multicore controller for voice processing.
>>>
>>> Acked-by: Mark Brown <broonie@kernel.org>
>>>
>>> though...
>>>
>>>> +  vdd-supply:
>>>> +    description:
>>>> +      Regulator for the 1V0 supply.
>>>> +
>>>> +  vdd2-supply:
>>>> +    description:
>>>> +      Regulator for the 3V3 supply.
>>>
>>> ...it's a bit weird that the supplies are named like this, usually
>>> there'd be some sort of meaningful name (even if it's just VDD_1V0 and
>>> VDD_3V3 or something).  Are you sure these are the actual names?
>>
>> The names in the datasheet are vdd for the 1V0 supply and vddio for the
>> 3V3 supply. I named the latter vdd2 instead because this device does not
>> have its own driver and instead it uses the onboard_usb_hub generic
>> driver, where the supplies are named vdd and vdd2.
>>
>> Those are the names used for devm_regulator_bulk_get(). Is that not the
>> right way to match them?
> 
> If desired the driver could be extended to support device specific regulator
> names through struct onboard_hub/dev_pdata.

the onboard_usb_hub driver as well and their supplies are named vdd and
vdd2:
Documentation/devicetree/bindings/usb/cypress,hx3.yaml

I took a look at its datasheet and there is no vdd2 as such, so I think
we are in a similar situation here. Actually that device requires five
supplies and they have been grouped into vdd and vdd2 according to their
voltage level.

Best regards,
Javier Carrasco