Received-SPF: pass (google.com: domain of linux-kernel+bounces-55256-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 6 Feb 2024 07:37:59 -0800
From: Jakub Kicinski <kuba@kernel.org>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>, Eric Dumazet
 <edumazet@google.com>, Paolo Abeni <pabeni@redhat.com>, Michal Swiatkowski
 <michal.swiatkowski@linux.intel.com>, Marcin Szycik
 <marcin.szycik@linux.intel.com>, Wojciech Drewek
 <wojciech.drewek@intel.com>, Yury Norov <yury.norov@gmail.com>, Andy
 Shevchenko <andy@kernel.org>, "Rasmus Villemoes"
 <linux@rasmusvillemoes.dk>, Alexander Potapenko <glider@google.com>, Jiri
 Pirko <jiri@resnulli.us>, Ido Schimmel <idosch@nvidia.com>, Przemek Kitszel
 <przemyslaw.kitszel@intel.com>, "Simon Horman" <horms@kernel.org>,
 <linux-btrfs@vger.kernel.org>, <dm-devel@redhat.com>,
 <ntfs3@lists.linux.dev>, <linux-s390@vger.kernel.org>,
 <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
 <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v5 00/21] ice: add PFCP filter support
Message-ID: <20240206073759.4d948d1e@kernel.org>
In-Reply-To: <c90e7c78-47e9-46d0-a4e5-cb4aca737d11@intel.com>
References: <20240201122216.2634007-1-aleksander.lobakin@intel.com>
	<c90e7c78-47e9-46d0-a4e5-cb4aca737d11@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 6 Feb 2024 13:46:44 +0100 Alexander Lobakin wrote:
> > Add support for creating PFCP filters in switchdev mode. Add pfcp module
> > that allows to create a PFCP-type netdev. The netdev then can be passed to
> > tc when creating a filter to indicate that PFCP filter should be created.  
> 
> I believe folks agreed that bitmap_{read,write}() should stay inline,
> ping then?

It's probably fine, IMHO. I mean, I think we agree that the rarely used
inlines should not sit in a header included by half of the kernel (not
an exaggeration). But IMHO a better fix would be to move out whatever
cpumask.h xarray.h and other common headers depend on to a cut-down
version rather than making your helpers not inline.

So I think all we need for now is for people to ack the respective
patches? Looks like cio and ntfs and missing acks, so are some of 
the bitops core patches.