Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763558AbXLTWEY (ORCPT ); Thu, 20 Dec 2007 17:04:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1764015AbXLTWDz (ORCPT ); Thu, 20 Dec 2007 17:03:55 -0500 Received: from pasmtpb.tele.dk ([80.160.77.98]:39456 "EHLO pasmtpB.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764003AbXLTWDx (ORCPT ); Thu, 20 Dec 2007 17:03:53 -0500 Date: Thu, 20 Dec 2007 23:05:47 +0100 From: Sam Ravnborg To: "linux-os (Dick Johnson)" Cc: Lennart Sorensen , Linux kernel Subject: Re: Trying to convert old modules to newer kernels Message-ID: <20071220220547.GA5641@uranus.ravnborg.org> References: <20071219202323.GH2310@csclub.uwaterloo.ca> <20071220150255.GE2308@csclub.uwaterloo.ca> <20071220182815.GA5438@uranus.ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1820 Lines: 47 On Thu, Dec 20, 2007 at 04:27:37PM -0500, linux-os (Dick Johnson) wrote: > > On Thu, 20 Dec 2007, Sam Ravnborg wrote: > > >> > >> It never gets to the printk(). You were right about the > >> compilation. Somebody changed the kernel to compile with > >> parameter passing in REGISTERS! This means that EVERYTHING > >> needs to be compiled the same way, 'C' calling conventions > >> were not good enough! > > > > How did you build the module. It reads like you failed to use > > kbuild to build your module which is why you did not pass > > correct options to gcc - correct? > > > > If you did not use kbuild - why not? > > Is there anything missing you need? > > > > Sam > > > > I need to get rid of -mregparm=3 on gcc's command line. It > is completely incompatible with the standard calling conventions > used in all our assembly-language files in our drivers. We make > very high-speed number-crunching drivers that munge high-speed > data into images. We need to do that in assembly as we have > always done. That I understand. So you need a CONFIG_ option to switch off -regparm=3 and pray that the kernel assembly supports it. And then I assume you avoided kbuild because it added -regparm=3 which is why your simple module broke. As you are well aware there is not any testing of a kernel without -regparm=3 these days so you should strongly consider making your assembly module comply with -regparm=3. And no - I dunno how much work that is and what impact it has on your number chrunching stuff. But it looks like the only sane long-term solution to me. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/