Received-SPF: pass (google.com: domain of linux-kernel+bounces-55211-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 6 Feb 2024 07:12:25 -0800
From: Ira Weiny <ira.weiny@intel.com>
To: "Fabio M. De Francesco" <fabio.maria.de.francesco@linux.intel.com>, "Peter
 Zijlstra" <peterz@infradead.org>, Dan Williams <dan.j.williams@intel.com>,
	<linux-kernel@vger.kernel.org>
CC: <linux-cxl@vger.kernel.org>, Dave Jiang <dave.jiang@intel.com>, "Jonathan
 Cameron" <Jonathan.Cameron@huawei.com>, Ingo Molnar <mingo@kernel.org>,
	"Fabio M. De Francesco" <fabio.maria.de.francesco@linux.intel.com>, Ira Weiny
	<ira.weiny@intel.com>
Subject: Re: [PATCH 1/2 v3] cleanup: Add cond_guard() to conditional guards
Message-ID: <65c24c5915370_38985a294d3@iweiny-mobl.notmuch>
References: <20240206121301.7225-1-fabio.maria.de.francesco@linux.intel.com>
 <20240206121301.7225-2-fabio.maria.de.francesco@linux.intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240206121301.7225-2-fabio.maria.de.francesco@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kKGn4sAlvNH+NSNwPK3Rt8C7ChnYGq46XZLC+Ca5RBTl4Su0EIDbNdcuGhFg?=
 =?us-ascii?Q?VI7UTK40V02r3jsYMdPheX/iZFGBpu+DbXLMGDuUORlJsml0MO4u2G7qxvDJ?=
 =?us-ascii?Q?N2J1pCbfK9v1eVirfwa9up2e14cKEmiwki5prJvwIYjFHPH8Ee6ruFsBOYQ/?=
 =?us-ascii?Q?GxwmB1XNi1z/AbVhG7LEnKTmGVaR7lEYetANnhYepOvlfOyq7TXkmMlVk6Hz?=
 =?us-ascii?Q?rVIxImBSOQPIsgArU5iLomo3AFiitToPHvOzb/ipmbDKnQMUjVEc7wUM0dVd?=
 =?us-ascii?Q?5m06SSP9LNQc2ffbbMaOeJBD9RIki3K96y5mFJGbYrB+RvDY+ioKq12FTROw?=
 =?us-ascii?Q?pprjGBSx8iDRq2UPAzcAQORN+oKsImd+LYnVzkAgYfjk/Zs9upYSTkZx1EyM?=
 =?us-ascii?Q?GrTKDHKADZGi+wfGTreQBNpZrvDaAVZuAoCe2jTNmJ/3Pp190QHAEZRD2vXa?=
 =?us-ascii?Q?ukwbts28hMHrk7iHepS8Q1u6UTjF4XEGqC3aH5C/7Brt0angsqsg5zjPfdWD?=
 =?us-ascii?Q?QMatUeg9/3fxW2ZH0Clm3V4AFGdwQAP2IKjOY93ve0M+iIgJpbneVP/VmRQR?=
 =?us-ascii?Q?dK4ftbFX3wtcggn6eJVVgk9jbjiHwPkRJ83USs/dy4MINF1BSdSKJuZWqrWv?=
 =?us-ascii?Q?12/3hxRiCIKh8UUuBb22/2SCeBb03g9yckCqPAC3m1vD89pns2IUQbnLj+8k?=
 =?us-ascii?Q?YiYnaS76j3IK7qlvXhGEmvPUXwmq5+wJ/9/LOYM11vDK3txxj6d5emVFKNDA?=
 =?us-ascii?Q?VNRXuTQieax/7nfiM/ocWh0Z8C/bMvDpTJM6Jh+nOcUBf4A/eOgSy/VNclax?=
 =?us-ascii?Q?oKSSLl4B8B9+R6hef+AfewwmuCl2KmW4qRff3ZqFR99jc659qHwRcsPw7u+4?=
 =?us-ascii?Q?9q7+JIrOnFZaXD4kzVZFbH4o6hbNsZ13sywoYEHjeiTP8oo6N1QHNQWwWqPW?=
 =?us-ascii?Q?XUzRQGJISMDX5SHdbs5h5XHdjdnIGtWTRyqaHz/5djQqhjoIEqDWl3gE0663?=
 =?us-ascii?Q?eMtzAYe5CIuUWnwYH0oiU6jbI4lrhUZhyYUnO9/A1vxSFH02X28gTperrm7D?=
 =?us-ascii?Q?A65Hx5FCAUtdDaQI+x5pdJA1Xgv8XohBHlJtE6d04bgXa+HKpsE5dUhpLnt6?=
 =?us-ascii?Q?j95Xr8p128uewDcYDYQuDLdkIKniooSV7e4oOwJ4oU0lRRtt6ieIo0x7L+F6?=
 =?us-ascii?Q?BKIexqbHDe49ODZUwLNdNVL0KYkNvN/D345LQd1McEPEAa3jaIQa7NgNjy5f?=
 =?us-ascii?Q?tmhkqG9SKBoh7K8pnP9PX6xpZ2DO9H2FvGfXtA2hKxxdXmVXRG0hWkAvP/YD?=
 =?us-ascii?Q?zjdP+mee130qKgBka8/dsNi05SvVaEjb544cRtu1i43n6lkpOBNpfLo3b+Wg?=
 =?us-ascii?Q?A5Zml8nes6Nvp4tCIlwM1mQ8GhuikyX6TISySZOxEAwEp/Y+V7thI/5rxfnk?=
 =?us-ascii?Q?roc4GKo+4YWaSyGKC7Pa7VqQykN8g+qOnqdAyrwujwYBqmMv/MNF9JykmdhR?=
 =?us-ascii?Q?1J9QzjzUStX41qL4bwDMjWUWB6q1qTmiKzbhk02d3b8Z1zoR+/rFUYrpuWma?=
 =?us-ascii?Q?uEOal4cFVg4Y0vzuVksafVUMPjhEiWEkAiWZRBO2?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f126414a-da03-40a0-258f-08dc272608c5
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2024 15:12:29.1042
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: a2lh+5Ej549lhWi683MAA2G8k9K8uY4HjcrZsXFrE8mv9jhwR6FekR5PCshTvQ8fUfPwC6jCm8XHKYND3DH3lA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8384
X-OriginatorOrg: intel.com

Fabio M. De Francesco wrote:
> Add cond_guard() macro to conditional guards.
> 
> cond_guard() is a guard to be used with the conditional variants of locks,
> like down_read_trylock() or mutex_lock_interruptible().
> 
> It takes a statement (or statement-expression) that is passed as its
> second argument. That statement (or statement-expression) is executed if
> waiting for a lock is interrupted or if a _trylock() fails in case of
> contention.
> 
> Usage example:
> 
> 	cond_guard(mutex_intr, return -EINTR, &mutex);
> 
> Consistent with other usage of _guard(), locks are unlocked at the exit of the
> scope where cond_guard() is called.
> 
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Suggested-by: Dan Williams <dan.j.williams@intel.com>
> Suggested-by: Ira Weiny <ira.weiny@intel.com>

Thanks for the revisions!

Reviewed-by: Ira Weiny <ira.weiny@intel.com>