Received-SPF: pass (google.com: domain of linux-kernel+bounces-55258-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <920c2c18-6cf9-4a88-84a5-eb1208ad1d42@wolfvision.net>
Date: Tue, 6 Feb 2024 16:38:39 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 6/7] ASoC: dt-bindings: xmos,xvf3500: add XMOS XVF3500
 voice processor
Content-Language: en-US
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Matthias Kaehlcke <mka@chromium.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
References: <20240206-onboard_xvf3500-v3-0-f85b04116688@wolfvision.net>
 <20240206-onboard_xvf3500-v3-6-f85b04116688@wolfvision.net>
 <ZcJDFi+iIQOWzgYw@finisterre.sirena.org.uk>
 <7b472cb2-6658-446a-ae47-411d08798cca@wolfvision.net>
 <ZcJR0LrwaS5GAf5h@finisterre.sirena.org.uk>
From: Javier Carrasco <javier.carrasco@wolfvision.net>
In-Reply-To: <ZcJR0LrwaS5GAf5h@finisterre.sirena.org.uk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bnVVcjRMamhXZEIvRUVMOWVMbUgwNnordm42VnhOQ0hsTGZtaEwxNTRwUDAr?=
 =?utf-8?B?aWRLSmU4OWY1UHh5UGZtZnVjdXZiVllCR3FXZ3FPR1o5bHA0US9CQzRlY3d5?=
 =?utf-8?B?ZTV4dXIxWmlqVWpIR01FekJaWm42TjhvUURFbmpJRjNRWUNBa0c1c0cwMk5H?=
 =?utf-8?B?UnIrekFPbkVSWHM3LzJma3d1d0VCaXREbE9WVWFHeEk5MGtSblZCL3pPY2N5?=
 =?utf-8?B?bEJuVVlRNHpVZzNMcUJxZk5jTkk1YnVPdVRLK3Q5eC9zMHU2V25FdGhScG9G?=
 =?utf-8?B?Vm9icnA4OVRyLzBVc2MwQ01kSmZZSEwwRmRmcS8wSzhnekJZQ2pFM3krcXVQ?=
 =?utf-8?B?L042dFRTR3JOTXBXbHVWM3VZQVV1QmdjY0lpTVlLOFBSUXVkYUJ1ek9TU1Vw?=
 =?utf-8?B?emZPQno2N3d4cVgrWVU4R0VWVmFuQklnV29raHE2RHpMaXlwYnhhWk9jMHR5?=
 =?utf-8?B?QlVQdG53OXl2ZFhFczVpQ2EwR3lyb3FadzI0UGJDU0RLOFVIM2Y2Y0lnUDJB?=
 =?utf-8?B?aGI2OGkwUmpwSGdkQm5DaXdUd21LQ3p0Vks3aTJVazRKanoyZ2lBdUJFU0tw?=
 =?utf-8?B?Ty9ERGNIdXlsK1lpaXlZQUVtN1FHZWd0MVBEay9JTUpzUVd4bmZtMVY5T0M5?=
 =?utf-8?B?bTlLQTFWOUx1Q0dQZy80ZWRTVHhoVEM4bDlOaDBFdU9mSmJIN0xET3NDYWtW?=
 =?utf-8?B?OVgvUG5zUnBlTmg4c0UwblJDR3dNY2ZGQk9SQUNwWW9OOEs2L2VtZEg0SzFy?=
 =?utf-8?B?TjEvVXlxaThPanRqTDJXRGtCSEl5MnpBdkZBWmZlaUs5aFZlMFZFNHg3VEF4?=
 =?utf-8?B?VlpkNzV5bnhlWGF1Z1d6ay9aTGNiRng2bHJtRUFLQ0p4OEtmY2tFeVAvMUJL?=
 =?utf-8?B?aXJZQlBucXlIMEl2THNteWgxL2FrVmMvaWdpcENhUTkra2JlQ01rNFlKSWFx?=
 =?utf-8?B?c09BT2R6QUt4cCtVRW9vN05VY2tGRDc0THJweWh3VjhPOWtPeVEwOEJiZStw?=
 =?utf-8?B?dkVyRXd5TlF6bkUwYWVMWHBCUk1HVUxac0RUYWpOdkFkc2lBNGNWR2ErQk42?=
 =?utf-8?B?VUR2aFo2R3Y0VHViQ05FcEptNVdyTFExVFpranVYaHhRUURPSkZGQ1Z0L05k?=
 =?utf-8?B?R1A5N2EvTGQwVDFkSjhzbi9Tb0ZWT29OUWhIbmtLR1ltcmhJbHBBWVduMjVV?=
 =?utf-8?B?ay82WWFxbDcyd0xQcUkyYXFmT05Xc2dKT0U2akdKY1p1dkE0YmwxWTZJc0sx?=
 =?utf-8?B?TDVlRUhDdGhkeGxSdVlQc3R0MERYMzY1SVNRZnhuVXpxQ1J5SVZnNkZiS3Vw?=
 =?utf-8?B?cmFadlRXMXZZdm9IeTBmLzFjbUpRZHRsbmlvdlNkUG8wTFlLTk9DeFVRbUJz?=
 =?utf-8?B?V0lIOWNlUlhSeEh1UVRPYUltL1ZmMCt4RmJIMkluNkNIWE4rWlljMUc0bng0?=
 =?utf-8?B?anZkM3JaTFNwbmgxYldIK2lZaWhhU05HVFNTbHRYem5RYmFjeVFDWE9tS0kv?=
 =?utf-8?B?WFBaYk1ZcXB0cHJZM1p3MVhZWWNuVFBsRmpzZ01DVmh6blN2SkpWRE1ta1RO?=
 =?utf-8?B?cWFUK0o0aUFyRzlZYmZXdFhCaHYwTHRtSjVUYlU5MXRTSS9ZQnBGMWdsT291?=
 =?utf-8?B?cUx6VkcvVzF4elFQNi9kSllQZWdXVUtUelM1b204UXJpNW9MMThZK2F6V2sv?=
 =?utf-8?B?VkdpVjlGYXF5MUZ6N0d6UThRQSt4aS9hUGduQW5IbXh4dHhaWlBvbjl1OVB5?=
 =?utf-8?B?enRRTTk0OGg1Mkh1VE1ZQ3p2blowWWN3WFBsNjVZUjRJdnFtZ0M5cnVaSzRp?=
 =?utf-8?B?VVRGVW9oZFRUQmNNTkJuNmxRakV2a1U1aFU3eTJaRkdKdW5kc3N4SE1idTlr?=
 =?utf-8?B?K3h4WWdQU0pkazdlcUFwSHJKYVVJd0p6OWtxemgxWUFPS0ZrdVlYNXZoSStq?=
 =?utf-8?B?d2tKSkRnMkJ1UnpJbDJ3d2wzYzZUM3dGRldKR0RyVjZqNGJkTGk2a2Q1TW5Q?=
 =?utf-8?B?Y0NiWEZ1Yll1WWJqUTJBSTlqd3VqOGVmclhMZ2VkdFFIcWlYbWFRSnliekRH?=
 =?utf-8?B?NlJPSW9UVElmektDTlZVeEhRVEtsSHhTTElFcUFxS28yZm9ZNitqK2xJWGNE?=
 =?utf-8?B?RHlmRG04T01sWVpsNjV0cGo5TGw4aFJ4VWNFaWJETVBLbXN6dTFRUTg1OGx5?=
 =?utf-8?Q?sdJxkMj6XiydO3u137tq9O8=3D?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a27da28-a719-4f30-5b3c-08dc2729b1ba
X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4974.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2024 15:38:40.9666
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9GSTzWsGcEcH+3go6+lBd9nC4aPDTOmlYe6Ydd4L06oG76/T+uJg7qmv+9cFmO/arAbKYt3chjdmvS7ijf7gvGcQCRQlpW6yOz8fyCIOHM8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB10763

On 06.02.24 16:35, Mark Brown wrote:
> On Tue, Feb 06, 2024 at 04:05:15PM +0100, Javier Carrasco wrote:
> 
>> The names in the datasheet are vdd for the 1V0 supply and vddio for the
>> 3V3 supply. I named the latter vdd2 instead because this device does not
>> have its own driver and instead it uses the onboard_usb_hub generic
>> driver, where the supplies are named vdd and vdd2.
> 
>> Those are the names used for devm_regulator_bulk_get(). Is that not the
>> right way to match them?
> 
> The binding should really use vddio instead of vdd2 but if that's an
> existing binding then it gets more annoying, probably that existing
> binding is wrong too since vddio does sound like an entirely plausible
> standard name for a 3.3V supply. :/  At the very least the binding
> should document the weird mapping, though ideally the driver would be
> tought to request names matching the datasheet if the compatible is the
> one for this device.  Doing the better naming might be too much hassle
> though.

That is in line with my last reply, where the bindings I used as an
example mention the real names of the supplies as they are defined in
the datasheet.

I can add that for the next version.

Best regards,
Javier Carrasco