Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp3159930rdb; Tue, 6 Feb 2024 08:47:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IGJtrt3PiUrbgtf9GbltPseoUOQ9bIetSjX1n1YjgyiJ16o5Gu2RSAgdTjcD4jp943SKqAK X-Received: by 2002:a1f:7d4e:0:b0:4b7:185a:d8d with SMTP id y75-20020a1f7d4e000000b004b7185a0d8dmr108404vkc.1.1707238030224; Tue, 06 Feb 2024 08:47:10 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707238030; cv=pass; d=google.com; s=arc-20160816; b=sonPgTARz1LeT6Fa2UFeQpQitNw13eKabXuupNCdpJSJqMfIkfymr4iApQrL7X0AHm KZKi5JgNAxAF5YKobo4C6UxMVx/fC56CpvZzTcXuwWOstWjcNkX2jabGMcveM4WKd5Wm RvrEFTNebaPLB5YQxKbDqPXJeVy6WCePSGxk/BYuZwV00sfsaYq8IUOqrPCmpkljA6x7 SYbWoFkPTpyh6yr7i3ihtcspbrc0aloQxDN0rNQ1utBvYmlIXUGA1r8kEu80jR4JKDit ZX4C6qKIMgr3ehGe4R4A+79jhLXCA2o9zPvs53YguLPJtzbnt2yp47IrtsEI27YNxe6y kICw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=QsTqw3rZD8KSu/UjCpoOOeyYU8QIjntjeM2AmeSeb0w=; fh=hBmph5rpK0De1ck/pgeKjl/k8W97NHpDg0U/ZmxKmF4=; b=ThqJeyhFLKQN4lNZr0rhWUPQA3gGI/uPjFwkrW0+rmucaxYs6h+Lu9/ynR13AhpX9D p3EsnhIr1UkBayvHzSNhBDdqAx219puhpCtzwEv2koTwLFDwe2bSgQfkOlu+YNF+YDlk IhViiUDIXGiylwgAfxV8vBC/RDGvkd6Hmgq5s8EExQB94eWgzkziTD1a4+RYHF6Y4V7b b9jQ/qfxyqOiXDc6QGfbJQtqhtlZA5Bhj/gkEwPxEi22TLFHS3PwoMHopEz9mXX6uKDD kmzltNIjJO9SY4xFQtQ0Egl/bIMpfJxHRe/vfr3HmOky6cciUxGOuQcJ1Dr3rd5mka3C US1w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=kYMDHaqh; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-55334-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55334-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Forwarded-Encrypted: i=1; AJvYcCWvZgv6XWAC8SUI98mwvcKulUNewGg0bUJ15nysmzkEFkNFVmJVVttbKq3BckqN9CZAwtJZKM4oN37BIguvEtYrGlw1UOHceDPuXnGtPw== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id ke10-20020a056214300a00b0068c7aacf0basi3080058qvb.354.2024.02.06.08.47.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 08:47:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-55334-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=kYMDHaqh; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-55334-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55334-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id F000E1C2430A for ; Tue, 6 Feb 2024 16:47:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A00C1611B; Tue, 6 Feb 2024 16:46:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="kYMDHaqh" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71A204A15; Tue, 6 Feb 2024 16:46:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707238017; cv=none; b=QDuJVBE2OYQF3uIOM8X8Nwz3tBqIeHKDHCNbUq9L+me5Mdda+5EnttMYIAFRAsnRQCtUsRciBgAV/oKujcjBVLvKzVeXz3nyr1oTNIdAdpNuFVQMLxr9nxITsecNU4kJdDo3qLB+H0GOCoGIKjjBYl9VrnMzAX9VewmNsKG36q8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707238017; c=relaxed/simple; bh=USPZtu7vxjk1ebvcOxNJKhO0fXx2MLMuxDfhFtm/z84=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oci5wMc+Qgyy04Jv0l+PwmJ8ipmOL/rJzU6h1YRc/whNa2s/8kAYTDPlDbZi265j5KWohf1AwHrjRls/s0AAjZ9UZcGipqQcNZ8I8lhdRYfA9RM0qUjIbzCzbG9CusLpZXK+96nmugDdcTSlVPhE7tEaya1hOi9t9LYbGGZ8wZc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=kYMDHaqh; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707238016; x=1738774016; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=USPZtu7vxjk1ebvcOxNJKhO0fXx2MLMuxDfhFtm/z84=; b=kYMDHaqhX6IoTu0VXfJSwq45DbvH6NRX6keJD1lrTVLOtDxWbnK14cRf VLt/g4glmaY3FFhOrSvUn9zeOxE8r77peqdylkeY7MokWDEFipVHmMwRX QKmDll+XRIxwNgkyc4XoD8nWo2t2mmF1vT/xd7CzGVelNGeXU07C56ikz 1COvb2UwUFn/95nGRQB31mOevZW4gT54ZnA+bUqkaw8ELbZCH9M+SrGgU 6yNS1r53pCBiP7OXVBSWK/ZlYCnLydlGq2HbJ3LfFuabBZJlFzCWLltgZ Q1pkCmNNRThiRSnIsavmhMSK2pg0l4j5OvAdvEhIkaYHOq4EaIi78w3SU g==; X-IronPort-AV: E=McAfee;i="6600,9927,10976"; a="12146629" X-IronPort-AV: E=Sophos;i="6.05,247,1701158400"; d="scan'208";a="12146629" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2024 08:46:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,247,1701158400"; d="scan'208";a="1102749" Received: from jingjing-mobl1.ccr.corp.intel.com (HELO localhost) ([10.254.215.110]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2024 08:46:48 -0800 Date: Wed, 7 Feb 2024 00:46:39 +0800 From: "Wang, Qingshun" To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org, chao.p.peng@linux.intel.com, erwin.tsaur@intel.com, feiting.wanyan@intel.com, qingshun.wang@intel.com, "Rafael J. Wysocki" , Len Brown , James Morse , Tony Luck , Borislav Petkov , Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , Bjorn Helgaas , Mahesh J Salgaonkar , Oliver O'Halloran , Miaohe Lin , Shiju Jose , Adam Preble , Li Yang , Lukas Wunner , Kuppuswamy Sathyanarayanan , Smita Koralahalli , Robert Richter , linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, linux-edac@vger.kernel.org Subject: Re: [PATCH v2 2/4] PCI/AER: Handle Advisory Non-Fatal properly Message-ID: References: <20240125062802.50819-3-qingshun.wang@linux.intel.com> <20240205232616.GA831017@bhelgaas> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240205232616.GA831017@bhelgaas> On Mon, Feb 05, 2024 at 05:26:16PM -0600, Bjorn Helgaas wrote: > In the subject, "properly" really doesn't convey information. I think > this patch does two things: > > - Prints error bits that might be ANFE > - Clears UNCOR_STATUS bits that were previously not cleared > > Maybe the subject line could say something about those (clearing > UNCOR_STATUS might be more important, or maybe this could even be > split into two patches so we could see both). > Good idea, thanks. I think splitting it into two patches would be the better approach.