Received-SPF: pass (google.com: domain of linux-kernel+bounces-55345-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20231221071109.1562530-1-linan666@huaweicloud.com>
 <20231221071109.1562530-3-linan666@huaweicloud.com> <3b240652-580e-73d5-a318-612984902aad@huaweicloud.com>
 <a92ca042-b981-4f35-beec-ebf416e4239b@leemhuis.info>
In-Reply-To: <a92ca042-b981-4f35-beec-ebf416e4239b@leemhuis.info>
From: Song Liu <song@kernel.org>
Date: Tue, 6 Feb 2024 09:00:47 -0800
Message-ID: <CAPhsuW5ZhW3fR8LwKsMrRV6bVMbXJfonkBqVMVQqw=FAJg3V4A@mail.gmail.com>
Subject: Re: [PATCH 2/2] md: create symlink with disk holder after mddev resume
To: Linux regressions mailing list <regressions@lists.linux.dev>
Cc: Yu Kuai <yukuai1@huaweicloud.com>, linan666@huaweicloud.com, 
	linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com, 
	houtao1@huawei.com, yangerkun@huawei.com, "yukuai (C)" <yukuai3@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 6, 2024 at 6:46=E2=80=AFAM Linux regression tracking (Thorsten
Leemhuis) <regressions@leemhuis.info> wrote:
>
> Hi, Thorsten here, the Linux kernel's regression tracker.
>
> On 21.12.23 09:49, Yu Kuai wrote:
> > =E5=9C=A8 2023/12/21 15:11, linan666@huaweicloud.com =E5=86=99=E9=81=93=
:
> >> From: Li Nan <linan122@huawei.com>
> >>
> >> There is a risk of deadlock when a process gets disk->open_mutex after
> >> suspending mddev, because other processes may hold open_mutex while
> >> submitting io. For example:
> >> [...]
> > Nice catch! This patch looks good except that the new flag
> > 'SymlinkCreated' doesn't look accurate, perhaps 'HolderLinked'
> > will make more sense.
> >
> >> Fix it by getting disk->open_mutex after mddev resume, iterating each
> >> mddev->disk to create symlink for rdev which has not been created yet.
> >> and moving bd_unlink_disk_holder() to mddev_unlock(), rdev has been
> >> deleted from mddev->disks here, which can avoid concurrent bind and
> >> unbind,
> >>
> >> Fixes: 1b0a2d950ee2 ("md: use new apis to suspend array for ioctls
> >> involed array reconfiguration")
>
> Hey, what happened to that patch? It looks a lot like things stalled
> here. I'm asking, because there is a regression report that claims
> 1b0a2d950ee2 to be the culprit that might or might not be causes by the
> problem this patch tries to fix:
> https://bugzilla.kernel.org/show_bug.cgi?id=3D218459

Thanks for the heads-up. Replied to the thread.

Song