Received-SPF: pass (google.com: domain of linux-kernel+bounces-55347-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Feedback-ID: i21f147d5:Fastmail
Date: Tue, 6 Feb 2024 10:03:41 -0700
From: Tycho Andersen <tycho@tycho.pizza>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Christian Brauner <brauner@kernel.org>,
	Andy Lutomirski <luto@amacapital.net>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pidfd: change do_notify_pidfd() to use
 __wake_up(poll_to_key(EPOLLIN))
Message-ID: <ZcJmbUzox6Rd3587@tycho.pizza>
References: <20240205141348.GA16539@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240205141348.GA16539@redhat.com>

On Mon, Feb 05, 2024 at 03:13:48PM +0100, Oleg Nesterov wrote:
> rather than wake_up_all(). This way do_notify_pidfd() won't wakeup the
> POLLHUP-only waiters which wait for pid_task() == NULL.
> 
> TODO:
>     - as Christian pointed out, this asks for the new wake_up_all_poll()
>       helper, it can already have other users.
> 
>     - we can probably discriminate the PIDFD_THREAD and non-PIDFD_THREAD
>       waiters, but this needs more work. See
>       https://lore.kernel.org/all/20240205140848.GA15853@redhat.com/
> 
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>

Reviewed-by: Tycho Andersen <tandersen@netflix.com>