Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp3200996rdb; Tue, 6 Feb 2024 09:56:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IFgiLsusIkAjFNyICI5gy7ALG9uz0nC6xZ42qJFtqBY8Oyp3YThnyojJjkilNohMok2yL/X X-Received: by 2002:a2e:8043:0:b0:2cd:5cfd:b19 with SMTP id p3-20020a2e8043000000b002cd5cfd0b19mr2891846ljg.19.1707242192167; Tue, 06 Feb 2024 09:56:32 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707242192; cv=pass; d=google.com; s=arc-20160816; b=M9e5dB+7S4zwR+xB4PZH+oyZ1+T9P7IesqrfoJd+WO6DUpEaooZjjxVBryJYeiAKqW xj6vExl4eAkUGNxYrEczWcMqIoYHtmu2YoC8f3I9sXTfPl9R8hSfrxIo7IPeFXPx1r9x ksAXSPsGjTzj6KUDgFYxq+oNY2r7M0+KNIvCnf7/SZ8Is2zbsrHR4SdSWR7v1uI/ZygV 1+i5n+WW33x/pD9fLW4pyVNA88AeN6hPdaYF9gtZ9PbGgLzbO3dpCoLTPKuwLmzPCgJX dwrlS4NBgkzE3uOCcsVV80ktxx8t6qq8QBCc2rV5gO0OPlCvdF/vwX/C+vzjGcZe7UtK VwLg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=QsRDCnt3gs6N+xlV4O38PY25gyey4PY+PnBtDMR0nIo=; fh=vLq4AZQ8b4iS/AfcpqKZR3ZTb4GMfZg82rb/hp35s8g=; b=KNfuL+q8+H/tFrZb2urjbGioGGt25YDx4+KeOPeyw7+tVaYD+TjX05YldIcUh4+LcH xJT94zWZ3C+mAvWk3Xo2mNA5sN3Hhvd+RANeTVojVb82jG+Ys8ITXQwz793pdg/9tDgh 3b83WuSMdZyzw8rnOrq6oLobrj6l00DxbsO1nYG2iW2ovWIJPBBhbL45dW+gL4KUOXjh SWzzx/XK5QRMHYKcBscNlZddcdr2Z1k1BRQVfP3tMTef4Jd7rY25SPeaKl+XbJVxDECn wgT2qHCh3rLcrHKv8ZFSXH3S6LEUIsI/KJhtqkI5SC9F9D4krbWjyJQejK9o3lpvsHgP Pvsw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YkL8A1xC; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-55428-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55428-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=1; AJvYcCWTyuJZZZYzjeRjnKA+v3WTcNLyVK0lqvDd0v78VaY8h4B4EBcxVH4nJH+FK/Njiloe4W6+gAwXov0QJgMhBJ+widXvDrirmp95gd5nJw== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id w19-20020a056402071300b0055f885218f0si1336624edx.356.2024.02.06.09.56.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 09:56:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-55428-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YkL8A1xC; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-55428-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55428-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 215BD1F261D2 for ; Tue, 6 Feb 2024 17:56:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 90C0DDF60; Tue, 6 Feb 2024 17:56:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YkL8A1xC" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B62C0DDD2; Tue, 6 Feb 2024 17:56:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707242179; cv=none; b=OEq+siMHuhe0XUJSeJ6H9+sBzBimeNtUnRjLutfW5uAbnRh0YkbxDVBr+GKvgO4OrRw4GpgtX51V61X3XnburwLwJO7HpThXsGl5Hx1aLk4diGWYQuH6qd76M+AvqyI9QyMTHD1kkIArvHmsJRJXCD40euhZHqEnCc8Gf9wRlsA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707242179; c=relaxed/simple; bh=pfj+UtF7zsGS/RC9920xUYfQDQHC6Qd17Xl6bNbnKh4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Oc1r4QuFKAPb7n7Zzn9S8VH2MDWb6BcD6+uPk0RkeP4WmFgtrp02RAo8+5hcWExyzU9VNxPvTK6VXBvgxS6SQpxSHWIvw2wjVIw7RxJ85H7MlZZrqF6i6Vynfcv66rTeHU3HdjbkaJ16XU2PFKSi9t6Bv6iAjm2ddXr6FBvv6g4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YkL8A1xC; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D310C433F1; Tue, 6 Feb 2024 17:56:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707242179; bh=pfj+UtF7zsGS/RC9920xUYfQDQHC6Qd17Xl6bNbnKh4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YkL8A1xCK0+Q8mu7fIAhPgxsg0BCU5dMof1kXXldS7Ki51Z9Ze2qQMRwIrXEQCouz GYZLOxMJ/g5yv78xOVHLW/xgh9r9WfvDyeiIzCjZ0v9u37i2fxUBPZb3PPQ2dQMts0 t8bkiuj+7axEN9eb8o/aLMQaFPr/en/7DWosQbJKi7a767GgRe32N38Upmn94XRg5Q aXRzwyiU0rDPSMTumPihS0NLXZ3/1Tgbi83NO7u38Rcyf1NXvrCGtpfhZKASR2DVoE 0NXl0L65ld/0yhc1wIujXGek5T3fRqQxnqxvvW4pKqf0ZHTHPt1OCoHNnMF+u4snHR VunpOzorCPgVw== Date: Tue, 6 Feb 2024 17:56:14 +0000 From: Simon Horman To: Masahiro Yamada Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, Jon Maloy , Ying Xue , linux-kernel@vger.kernel.org, tipc-discussion@lists.sourceforge.net Subject: Re: [PATCH] net: tipc: remove redundant 'bool' from CONFIG_TIPC_{MEDIA_UDP,CRYPTO} Message-ID: <20240206175614.GG1104779@kernel.org> References: <20240204131226.57865-1-masahiroy@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240204131226.57865-1-masahiroy@kernel.org> On Sun, Feb 04, 2024 at 10:12:26PM +0900, Masahiro Yamada wrote: > The 'bool' is already specified for these options. > > The second 'bool' under the help message is redundant. > > While I am here, I moved 'default y' above, as it is common to place > the help text last. > > Signed-off-by: Masahiro Yamada Thanks Yamada-san, this looks good to me. Reviewed-by: Simon Horman